public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [PATCH 0/1] vbt child device size fix
Date: Fri, 21 Aug 2015 16:52:00 +0300	[thread overview]
Message-ID: <cover.1440165040.git.jani.nikula@intel.com> (raw)

Since I had to revert David's commit from v4.2, we'll have to add it
back to drm-intel-next-fixes for v4.3. So it's a good occasion to
reflect on it.

I think it's problematic to be so strict with the VBT child device
size. We generally go for really verbose error and debug messages in the
dmesg and plunge on even when almost all hope is lost; it seems rather
silly to effectively stop trying to get displays lit up if the VBT child
device size is larger than expected. Hey, new stuff gets added at the
end all the time. So log what happened, and move on.

Here's a modified version of David's patch to do just that.


BR,
Jani.

David Weinehall (1):
  drm/i915: Allow parsing of variable size child device entries from VBT

 drivers/gpu/drm/i915/intel_bios.c | 37 +++++++++++++++++++++++++++++++++----
 drivers/gpu/drm/i915/intel_bios.h |  6 ++++--
 2 files changed, 37 insertions(+), 6 deletions(-)

-- 
2.1.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2015-08-21 13:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-21 13:52 Jani Nikula [this message]
2015-08-21 13:52 ` [PATCH 1/1] drm/i915: Allow parsing of variable size child device entries from VBT Jani Nikula
2015-08-21 14:24   ` Ville Syrjälä
2015-08-24  7:40     ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1440165040.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox