From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [maintainer-tools RFC PATCH 00/17] dim: function based subcommand handling
Date: Tue, 26 Jan 2016 16:32:13 +0200 [thread overview]
Message-ID: <cover.1453818220.git.jani.nikula@intel.com> (raw)
I propose to change the dim tool to handle subcommands via functions
matching the subcommand. Each 'dim sub-command' would be handled by a
function named dim_sub_command. Only functions handling subcommands
would have the dim_ prefix.
Patches 1-11 are mostly renames to follow the proposed naming scheme.
Patch 12 separates handling of aliases to an independent piece of code.
Patch 13 actually starts handling subcommands via the defined
functions. Some of the benefits of the approach are covered in the
commit message.
Patches 14-17 starts abstracting subcommand cases to functions. This is
mostly mechanical work, and I didn't bother with it until I get an ack
on the approach.
I've only tested this lightly, thus RFC.
BR,
Jani.
Jani Nikula (17):
dim: rename dim_push to dim_push_branch
dim: rename dim_apply to dim_apply_branch
dim: rename dim_co to dim_checkout
dim: rename dim_shell_checkpatch to shell_checkpatch
dim: rename dim_checkpatch to checkpatch_commit
dim: rename dim_checkrange to dim_checkpatch
dim: rename setup_dim to dim_setup
dim: rename create_workdir to dim_create_workdir
dim: rename update_nightly to dim_rebuild_nightly
dim: rename magic_patch to dim_magic_patch
dim: move dim_pull_request parameter check to the function
dim: separate handling of aliases
dim: handle subcommands through functions
dim: abstract dim_nightly_forget
dim: abstract dim_update_branches
dim: abstract dim_for_each_workdirs
dim: abstract dim_push_*
dim | 239 ++++++++++++++++++++++++++++++++++++--------------------------------
1 file changed, 128 insertions(+), 111 deletions(-)
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2016-01-26 14:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 14:32 Jani Nikula [this message]
2016-01-26 14:32 ` [maintainer-tools RFC PATCH 01/17] dim: rename dim_push to dim_push_branch Jani Nikula
2016-01-26 14:32 ` [maintainer-tools RFC PATCH 02/17] dim: rename dim_apply to dim_apply_branch Jani Nikula
2016-01-26 14:32 ` [maintainer-tools RFC PATCH 03/17] dim: rename dim_co to dim_checkout Jani Nikula
2016-01-26 14:32 ` [maintainer-tools RFC PATCH 04/17] dim: rename dim_shell_checkpatch to shell_checkpatch Jani Nikula
2016-01-26 14:32 ` [maintainer-tools RFC PATCH 05/17] dim: rename dim_checkpatch to checkpatch_commit Jani Nikula
2016-01-26 14:32 ` [maintainer-tools RFC PATCH 06/17] dim: rename dim_checkrange to dim_checkpatch Jani Nikula
2016-01-26 14:32 ` [maintainer-tools RFC PATCH 07/17] dim: rename setup_dim to dim_setup Jani Nikula
2016-01-26 14:32 ` [maintainer-tools RFC PATCH 08/17] dim: rename create_workdir to dim_create_workdir Jani Nikula
2016-01-26 14:32 ` [maintainer-tools RFC PATCH 09/17] dim: rename update_nightly to dim_rebuild_nightly Jani Nikula
2016-01-26 14:32 ` [maintainer-tools RFC PATCH 10/17] dim: rename magic_patch to dim_magic_patch Jani Nikula
2016-01-26 14:32 ` [maintainer-tools RFC PATCH 11/17] dim: move dim_pull_request parameter check to the function Jani Nikula
2016-01-26 14:32 ` [maintainer-tools RFC PATCH 12/17] dim: separate handling of aliases Jani Nikula
2016-01-26 15:56 ` Daniel Vetter
2016-01-26 14:32 ` [maintainer-tools RFC PATCH 13/17] dim: handle subcommands through functions Jani Nikula
2016-01-26 14:32 ` [maintainer-tools RFC PATCH 14/17] dim: abstract dim_nightly_forget Jani Nikula
2016-01-26 14:32 ` [maintainer-tools RFC PATCH 15/17] dim: abstract dim_update_branches Jani Nikula
2016-01-26 14:32 ` [maintainer-tools RFC PATCH 16/17] dim: abstract dim_for_each_workdirs Jani Nikula
2016-01-26 14:32 ` [maintainer-tools RFC PATCH 17/17] dim: abstract dim_push_* Jani Nikula
2016-01-26 14:42 ` [maintainer-tools RFC PATCH 00/17] dim: function based subcommand handling Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1453818220.git.jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox