Re: [PATCH v4 1/4] drm/i915/dsi: don't pretend we support SC GPIOs

Jani Nikula
2016-04-26T10:22:50Z

On Thu, 07 Apr 2016, Jani Nikula <jani.nikula@intel.com> wrote:
> False ideas introduced in
>
> commit 1d96a4a8ace6c1b08c7d203d9533b14e59f2200b
> Author: Jani Nikula <jani.nikula@intel.com>
> Date: Fri Mar 18 13:11:10 2016 +0200
>
> drm/i915/dsi: add support for DSI sequence block v2 gpio element
>
> Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Pushed this one to dinq.

BR,
Jani.

> ---
> drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
> index 9cfc62765f6e..9c7b98c58e85 100644
> --- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
> +++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
> @@ -209,7 +209,8 @@ static void vlv_exec_gpio(struct drm_i915_private *dev_priv,
> if (gpio_source == 0) {
> port = IOSF_PORT_GPIO_NC;
> } else if (gpio_source == 1) {
> - port = IOSF_PORT_GPIO_SC;
> + DRM_DEBUG_KMS("SC gpio not supported\n");
> + return;
> } else {
> DRM_DEBUG_KMS("unknown gpio source %u\n", gpio_source);
> return;

--
Jani Nikula, Intel Open Source Technology Center