Re: [Intel-gfx] [PATCH 5/5] drm/i915: split out i915_gem.c declarations to i915_gem.h

Jani Nikula
2022-09-06T13:59:14Z

On Mon, 05 Sep 2022, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> On 05/09/2022 16:00, Jani Nikula wrote:
>> +/* FIXME: All of the below belong somewhere else. */
>
> For the series:
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Thanks, pushed to drm-intel-next.

> (((
> I think historically i915_gem.h started as a stash for random bits which
> felt obviously wrong to put elsewhere, but it should be fine to
> "upgrade" it to a more important status now that you are working on
> cleaning things up, especially i915_drv.h.
>
> Where this "somewhere else" place could be is a bit tricky - I suspect
> there isn't any great urgency to re-home them. If one day splitting
> i915_gem.c into functional parts comes on the agenda so I guess then.
> But it's not that huge even so don't think it's top priority.
> )))

Mostly it's a bunch of debug/trace helpers that perhaps shouldn't have
been called GEM_ anything to begin with. i915_debug.h?

BR,
Jani.

--
Jani Nikula, Intel Open Source Graphics Center