From: Jani Nikula <jani.nikula@intel.com>
To: dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, jani.nikula@intel.com,
Carlos Eduardo Gallo Filho <gcarlos@disroot.org>,
Maxime Ripard <mripard@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Jeff Johnson <quic_jjohnson@quicinc.com>
Subject: [PATCH 0/2] drm: revert some framebuffer API tests
Date: Tue, 17 Sep 2024 20:43:50 +0300 [thread overview]
Message-ID: <cover.1726594684.git.jani.nikula@intel.com> (raw)
The tests consistently trigger WARNs in drm_framebuffer code. I'm not
sure what the point is with type of belts and suspenders tests. The
warnings *are* the way to flag erroneous API usage.
Warnings in turn trigger failures in CI. Filtering the warnings are
error prone, and, crucially, would also filter actual errors in case the
kunit tests are not run.
I acknowledge there may be complex test cases where you'd end up
triggering warnings somewhere deep, but these are not it. These are
simple.
Revert the tests, back to the drawing board.
BR,
Jani.
Cc: Carlos Eduardo Gallo Filho <gcarlos@disroot.org>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>
Jani Nikula (2):
Revert "drm/tests: Add test for drm_framebuffer_free()"
Revert "drm/tests: Add test for drm_framebuffer_init()"
drivers/gpu/drm/drm_framebuffer.c | 1 -
drivers/gpu/drm/drm_mode_object.c | 1 -
drivers/gpu/drm/tests/drm_framebuffer_test.c | 134 -------------------
3 files changed, 136 deletions(-)
--
2.39.2
next reply other threads:[~2024-09-17 17:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 17:43 Jani Nikula [this message]
2024-09-17 17:43 ` [PATCH 1/2] Revert "drm/tests: Add test for drm_framebuffer_free()" Jani Nikula
2024-09-17 17:43 ` [PATCH 2/2] Revert "drm/tests: Add test for drm_framebuffer_init()" Jani Nikula
2024-09-17 19:01 ` ✗ Fi.CI.SPARSE: warning for drm: revert some framebuffer API tests Patchwork
2024-09-17 19:10 ` ✓ Fi.CI.BAT: success " Patchwork
2024-09-18 8:44 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-09-24 10:06 ` [PATCH 0/2] " Simona Vetter
2024-09-24 11:54 ` Maxime Ripard
2024-09-24 13:37 ` Guenter Roeck
2024-09-24 13:56 ` Maxime Ripard
2024-09-24 15:09 ` Guenter Roeck
2024-09-24 15:56 ` Jani Nikula
2024-09-24 16:35 ` Guenter Roeck
2024-09-24 16:57 ` Maxime Ripard
2024-09-24 17:37 ` Guenter Roeck
2024-09-25 9:41 ` Jani Nikula
2024-09-25 12:59 ` Maxime Ripard
2024-09-25 15:57 ` Guenter Roeck
2024-09-25 11:52 ` Simona Vetter
2024-09-25 13:05 ` Maxime Ripard
2024-09-25 16:04 ` Guenter Roeck
2024-09-26 7:05 ` Maxime Ripard
2024-10-02 12:10 ` Jani Nikula
2024-10-03 12:04 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1726594684.git.jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gcarlos@disroot.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).