[PATCH] drm/i915/perf: document field usage of drm_i915_perf_oa_config

[PATCH] drm/i915/perf: document field usage of drm_i915_perf_oa_config

[Lionel Landwerlin]

Document the expected length register config pointers (tuple of u32
values).

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
 drivers/gpu/drm/i915/i915_perf.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
index 3d34c6a4313d..4409cea57607 100644
--- a/drivers/gpu/drm/i915/i915_perf.c
+++ b/drivers/gpu/drm/i915/i915_perf.c
@@ -3200,6 +3200,11 @@ static int create_dynamic_oa_sysfs_entry(struct drm_i915_private *dev_priv,
  * Validates the submitted OA register to be saved into a new OA config that
  * can then be used for programming the OA unit and its NOA network.
  *
+ * drm_i915_perf_oa_config has 3 pointers fields (mux_regs_ptr,
+ * boolean_regs_ptr, flex_regs_ptr) to buffers of tuples (register address,
+ * value) of u32 values. The number of tuples is given respectively by
+ * n_mux_regs, n_boolean_regs and n_flex_regs fields.
+ *
  * Returns: A new allocated config number to be used with the perf open ioctl
  * or a negative error code on failure.
  */
-- 
2.14.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/perf: document field usage of drm_i915_perf_oa_config

[Chris Wilson]

Quoting Lionel Landwerlin (2017-09-18 12:10:38)
> Document the expected length register config pointers (tuple of u32
> values).
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_perf.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
> index 3d34c6a4313d..4409cea57607 100644
> --- a/drivers/gpu/drm/i915/i915_perf.c
> +++ b/drivers/gpu/drm/i915/i915_perf.c
> @@ -3200,6 +3200,11 @@ static int create_dynamic_oa_sysfs_entry(struct drm_i915_private *dev_priv,
>   * Validates the submitted OA register to be saved into a new OA config that
>   * can then be used for programming the OA unit and its NOA network.
>   *
> + * drm_i915_perf_oa_config has 3 pointers fields (mux_regs_ptr,
s/pointers/pointer/

> + * boolean_regs_ptr, flex_regs_ptr) to buffers of tuples (register address,
> + * value) of u32 values. The number of tuples is given respectively by
> + * n_mux_regs, n_boolean_regs and n_flex_regs fields.

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

But I would suggest this would better for describing the uabi in
i915_drm.h.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/perf: document field usage of drm_i915_perf_oa_config

[Lionel Landwerlin]

On 18/09/17 12:27, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2017-09-18 12:10:38)
>> Document the expected length register config pointers (tuple of u32
>> values).
>>
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>> ---
>>   drivers/gpu/drm/i915/i915_perf.c | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
>> index 3d34c6a4313d..4409cea57607 100644
>> --- a/drivers/gpu/drm/i915/i915_perf.c
>> +++ b/drivers/gpu/drm/i915/i915_perf.c
>> @@ -3200,6 +3200,11 @@ static int create_dynamic_oa_sysfs_entry(struct drm_i915_private *dev_priv,
>>    * Validates the submitted OA register to be saved into a new OA config that
>>    * can then be used for programming the OA unit and its NOA network.
>>    *
>> + * drm_i915_perf_oa_config has 3 pointers fields (mux_regs_ptr,
> s/pointers/pointer/
>
>> + * boolean_regs_ptr, flex_regs_ptr) to buffers of tuples (register address,
>> + * value) of u32 values. The number of tuples is given respectively by
>> + * n_mux_regs, n_boolean_regs and n_flex_regs fields.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> But I would suggest this would better for describing the uabi in
> i915_drm.h.

I was wondering about put it in i915_drm.h, I think it's better.
Let's me just send another patch for the uapi instead.

Thanks!

> -Chris
>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.BAT: failure for drm/i915/perf: document field usage of drm_i915_perf_oa_config

[Patchwork]

== Series Details ==

Series: drm/i915/perf: document field usage of drm_i915_perf_oa_config
URL   : https://patchwork.freedesktop.org/series/30511/
State : failure

== Summary ==

Series 30511v1 drm/i915/perf: document field usage of drm_i915_perf_oa_config
https://patchwork.freedesktop.org/api/1.0/series/30511/revisions/1/mbox/

Test gem_exec_suspend:
        Subgroup basic-s3:
                pass       -> INCOMPLETE (fi-skl-6260u)
                pass       -> INCOMPLETE (fi-kbl-r)
Test gem_ringfill:
        Subgroup basic-default-hang:
                dmesg-warn -> INCOMPLETE (fi-pnv-d510) fdo#101600
Test kms_addfb_basic:
        Subgroup small-bo:
                pass       -> DMESG-WARN (fi-kbl-7500u)
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                pass       -> INCOMPLETE (fi-kbl-7500u)

fdo#101600 https://bugs.freedesktop.org/show_bug.cgi?id=101600

fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:442s
fi-bdw-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:474s
fi-blb-e6850     total:289  pass:224  dwarn:1   dfail:0   fail:0   skip:64  time:419s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:522s
fi-bwr-2160      total:289  pass:184  dwarn:0   dfail:0   fail:0   skip:105 time:278s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:510s
fi-byt-j1900     total:289  pass:254  dwarn:1   dfail:0   fail:0   skip:34  time:494s
fi-byt-n2820     total:289  pass:250  dwarn:1   dfail:0   fail:0   skip:38  time:489s
fi-cfl-s         total:286  pass:222  dwarn:32  dfail:0   fail:0   skip:31 
fi-elk-e7500     total:289  pass:230  dwarn:0   dfail:0   fail:0   skip:59  time:418s
fi-glk-2a        total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:595s
fi-hsw-4770      total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:427s
fi-hsw-4770r     total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:406s
fi-ilk-650       total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:431s
fi-ivb-3520m     total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:491s
fi-ivb-3770      total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:460s
fi-kbl-7500u     total:245  pass:222  dwarn:2   dfail:0   fail:0   skip:20 
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:585s
fi-kbl-r         total:118  pass:97   dwarn:0   dfail:0   fail:0   skip:20 
fi-pnv-d510      total:156  pass:113  dwarn:0   dfail:0   fail:0   skip:42 
fi-skl-6260u     total:118  pass:105  dwarn:0   dfail:0   fail:0   skip:12 
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:748s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:492s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:478s
fi-snb-2520m     total:289  pass:251  dwarn:0   dfail:0   fail:0   skip:38  time:573s
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:1   skip:39  time:418s

099f750f912b9dc16d15832b8fc048a4c918e384 drm-tip: 2017y-09m-18d-11h-57m-58s UTC integration manifest
80e0f1f0f9f6 drm/i915/perf: document field usage of drm_i915_perf_oa_config

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5728/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx