From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 5/6] drm/i915: refactor ring error state capture to use arrays Date: Tue, 11 Oct 2011 16:57:58 +0100 Message-ID: References: <1318343954-14607-1-git-send-email-daniel.vetter@ffwll.ch> <1318343954-14607-5-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id D59629EFD2 for ; Tue, 11 Oct 2011 08:58:00 -0700 (PDT) In-Reply-To: <1318343954-14607-5-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Tue, 11 Oct 2011 16:39:13 +0200, Daniel Vetter wrote: > The code already got unwindy and we want to dump more per-ring ^ unwieldly > registers. > > Only functional change is that we now also capture the video > ring registers on ilk. > > Signed-off-by: Daniel Vetter Ah, I see why now the space had to go. But we still need that space at the other callsite. Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre