From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 3/5] drm/i915: fall through pwrite_gtt_slow to the shmem slow path Date: Sun, 30 Oct 2011 08:35:34 +0000 Message-ID: References: <1316285749-30130-1-git-send-email-daniel.vetter@ffwll.ch> <1316285749-30130-4-git-send-email-daniel.vetter@ffwll.ch> <20110920113556.GA2865@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id E6BDA9ED8A for ; Sun, 30 Oct 2011 01:35:40 -0700 (PDT) In-Reply-To: <20110920113556.GA2865@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Daniel Vetter , intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Tue, 20 Sep 2011 13:35:56 +0200, Daniel Vetter wrote: > On Sat, Sep 17, 2011 at 09:57:05PM +0100, Chris Wilson wrote: > > And whilst you are here, can you incorporate this patch? > > else if (obj->gtt_space && > > + obj->map_and_fenceable && > > obj->base.write_domain != I915_GEM_DOMAIN_CPU) { > > ret = i915_gem_object_pin(obj, 0, true); > > Not sure this is good. On !llc machines, gtt_pwrite is much faster, so we > want to move the objects into the mappable part of the gtt to benefit from > that. Without this, they'll just stay wherever they are. This turns out to be a big win for machines where it avoids the pipeline stall due to the eviction of an active page and allowing us to utilize the full GTT for vertex data. 10% on pnv, 60% on snb for x11perf -aa10text. (Though on SNB this is eclipsed by using LLC and a test for obj->cache_level). And it is likely to be an improvement with geometry bound game benchmarks like openarena. -Chris -- Chris Wilson, Intel Open Source Technology Centre