From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DE62C433DF for ; Mon, 19 Oct 2020 10:51:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCAB32225A for ; Mon, 19 Oct 2020 10:51:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCAB32225A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0448E6E910; Mon, 19 Oct 2020 10:51:28 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id ED69C6E910 for ; Mon, 19 Oct 2020 10:51:26 +0000 (UTC) IronPort-SDR: YAoUF8a0iGwwepM9ud3KaEOBHYOpv4kbABtv0u5QV0gzvr6EmZGL9mbhJNzm9+i3V5udDXzV9Y k3mcTlTPFHYA== X-IronPort-AV: E=McAfee;i="6000,8403,9778"; a="146300410" X-IronPort-AV: E=Sophos;i="5.77,394,1596524400"; d="scan'208";a="146300410" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2020 03:51:26 -0700 IronPort-SDR: qfFsVKnugRwMJPnqkibzqd/uTbLM0ImkAM//crNi4LLp7tgwIb3HwudcPbfPOlMxG2hQPwucXa y754n/IAx1WA== X-IronPort-AV: E=Sophos;i="5.77,394,1596524400"; d="scan'208";a="465482012" Received: from maciejho-mobl.ger.corp.intel.com (HELO [10.252.17.157]) ([10.252.17.157]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2020 03:51:24 -0700 To: Chris Wilson , intel-gfx@lists.freedesktop.org References: <20201019083444.1286-1-chris@chris-wilson.co.uk> From: Matthew Auld Message-ID: Date: Mon, 19 Oct 2020 11:51:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201019083444.1286-1-chris@chris-wilson.co.uk> Content-Language: en-GB Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Onion unwind for scratch page allocation failure X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 19/10/2020 09:34, Chris Wilson wrote: > In switching to using objects for our ppGTT scratch pages, care was not > taken to avoid trying to unref NULL objects on failure. And for gen6 > ppGTT, it appears we forgot entirely to unwind after a partial allocation > failure. > > Fixes: 89351925a477 ("drm/i915/gt: Switch to object allocations for page directories") > Signed-off-by: Chris Wilson > Cc: Matthew Auld > Cc: Joonas Lahtinen Reviewed-by: Matthew Auld _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx