Re: [PATCH v10 02/10] drm/i915/psr: Add intel_psr_use_trans_push to query if TRANS_PUSH is used

Nautiyal, Ankit K
2026-01-27T05:20:24Z

On 1/26/2026 1:29 PM, Jouni Högander wrote:
> This is a preparation to start using trans push as a PSR "Frame Change"
> event. It adds intel_psr_use_trans_push placeholder which return false for
> now until we have everything in place.
>
> v2:
> - modify commit message
> - add TODO
>
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 6 ++++++
> drivers/gpu/drm/i915/display/intel_psr.h | 1 +
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index 62208ffc5101..b0d72c04db45 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -4562,3 +4562,9 @@ int intel_psr_min_guardband(struct intel_crtc_state *crtc_state)
>
> return psr_min_guardband;
> }
> +
> +bool intel_psr_use_trans_push(const struct intel_crtc_state *crtc_state)
> +{
> + /* TODO: Enable using trans push when everything is in place */
> + return false;
> +}
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.h b/drivers/gpu/drm/i915/display/intel_psr.h
> index b41dc4d44ff2..394b641840b3 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.h
> +++ b/drivers/gpu/drm/i915/display/intel_psr.h
> @@ -85,5 +85,6 @@ bool intel_psr_needs_alpm_aux_less(struct intel_dp *intel_dp,
> void intel_psr_compute_config_late(struct intel_dp *intel_dp,
> struct intel_crtc_state *crtc_state);
> int intel_psr_min_guardband(struct intel_crtc_state *crtc_state);
> +bool intel_psr_use_trans_push(const struct intel_crtc_state *crtc_state);
>
> #endif /* __INTEL_PSR_H__ */