From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00AC2C54E94 for ; Wed, 25 Jan 2023 11:35:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 23BBF10E78C; Wed, 25 Jan 2023 11:35:44 +0000 (UTC) Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7DB0310E78C; Wed, 25 Jan 2023 11:35:42 +0000 (UTC) Received: by mail-ej1-x634.google.com with SMTP id tz11so46897121ejc.0; Wed, 25 Jan 2023 03:35:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+C2JTrysbC6rWyL/QiL86fQj0GUC2xR+2yDFBTKfq0w=; b=U33uZw8fVYjdLEsD/7ALPHD5aaXY2b8QnYRdMKBfqmRb1a6HXnClLC19yi5tl0EWI7 1l3ND+BUR7LffymXbCDIPvkmQ4aLTqugNXb8QvxXwgxqUmPEZo8crmpbNQVp4SkZK7KS /+jnwnyIcW/661BGSLOgJ+WFd7ECwtaX/yJqK9YtnznqBgxgiKeI5pdM1TbSaNDQnqJd ZB1miJDiQ3pcM0sVAujpaWBA75ryn59WjMIQUIrD2VOl/30AWVXiMdC5QS483vsDg2fI 33crF9Q45rvS2X2aCqeJbf/2m8ti1/5HHbGqrxIPBmJ7sbiOC8YVZTvbd32+F7ptHqyf fM8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+C2JTrysbC6rWyL/QiL86fQj0GUC2xR+2yDFBTKfq0w=; b=nGkoWeQttHueq1I0S5aiNd0/yvQ4TPPOrNrQXPxMYe4L1DHDn5c79VNeD7irDbZkGf e9F1dK5C0JnpcVpnT2qVhWP0cCtBNtyX1gQ0yUPgtJKB6hTfOH+XiJ8MJNypvbG6G7q/ GfkiwDLRYRR4+JTGbMokfEaHKT3H+vvzUwP10lZ9zRMiS88WH26davseLcrI+7JYXeeV 4n8ZPi58gBu9QtWdxZYQdNMqvSz1L36No2O2BOUHm0G+GEeWYUSd7nC5HoO3PHTZk9YT UmXrxmtI/cWrRh2QQ0nBopq2pJNYhJo74lYtojZs4RsUQ5yckov2vDW46Pu9+l2/6Zep Mu7Q== X-Gm-Message-State: AFqh2koU3wjg9niWmyeBlUJEQv5M6ylHRrEYXR+f4t/AEIdmeKdn8yxE QxAFuFQpyBm51bVU9+pRNWc= X-Google-Smtp-Source: AMrXdXuoxdxMSdb/cb6wVWENpIo5NF81qOd8xsJaFf1ttq9YGnLK14Ff0ypwNzAw+VsZ+s2NORreMA== X-Received: by 2002:a17:906:1316:b0:862:1709:a06a with SMTP id w22-20020a170906131600b008621709a06amr34205747ejb.72.1674646540836; Wed, 25 Jan 2023 03:35:40 -0800 (PST) Received: from ?IPV6:2a02:908:1256:79a0:180c:8737:8e57:6be7? ([2a02:908:1256:79a0:180c:8737:8e57:6be7]) by smtp.gmail.com with ESMTPSA id h11-20020a1709062dcb00b007c14ae38a80sm2198322eji.122.2023.01.25.03.35.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 03:35:40 -0800 (PST) Message-ID: Date: Wed, 25 Jan 2023 12:35:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US To: Matthew Auld References: <20230124125726.13323-1-christian.koenig@amd.com> <418a6bca-7a61-86d8-7f6a-229d1e12c0fd@gmail.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH 1/5] drm/i915: audit bo->resource usage v3 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Am 25.01.23 um 11:21 schrieb Matthew Auld: > On Wed, 25 Jan 2023 at 10:07, Christian König > wrote: >> Am 25.01.23 um 10:56 schrieb Matthew Auld: >>> On Tue, 24 Jan 2023 at 17:15, Matthew Auld >>> wrote: >>>> On Tue, 24 Jan 2023 at 13:48, Matthew Auld >>>> wrote: >>>>> On Tue, 24 Jan 2023 at 12:57, Christian König >>>>> wrote: >>>>>> From: Christian König >>>>>> >>>>>> Make sure we can at least move and alloc TT objects without backing store. >>>>>> >>>>>> v2: clear the tt object even when no resource is allocated. >>>>>> v3: add Matthews changes for i915 as well. >>>>>> >>>>>> Signed-off-by: Christian König >>>>> Reviewed-by: Matthew Auld >>>> Ofc that assumes intel-gfx CI is now happy with the series. >>> There are still some nasty failures it seems (in the extended test >>> list). But it looks like the series is already merged. Can we quickly >>> revert and try again? >> Ah, crap. I thought everything would be fine after the CI gave it's go. >> >> Which patch is causing the fallout? > I'm not sure. I think all of the patches kind of interact with each > other, but for sure there is an issue with the first patch. There is > one splat like: Well I would rather like to revert as less as possible. Are you sure that this isn't only on some i915 specific branch with not yet upstream changes? I can't even find the i915_gem_obj_copy_ttm function in drm-misc-next nor drm-next. Regards, Christian. > > <1>[ 109.735148] BUG: kernel NULL pointer dereference, address: > 0000000000000010 > <1>[ 109.735151] #PF: supervisor read access in kernel mode > <1>[ 109.735152] #PF: error_code(0x0000) - not-present page > <6>[ 109.735153] PGD 0 P4D 0 > <4>[ 109.735155] Oops: 0000 [#1] PREEMPT SMP NOPTI > <4>[ 109.735157] CPU: 1 PID: 92 Comm: kworker/u12:6 Not tainted > 6.2.0-rc5-Patchwork_113269v1-gc4d436608c4e+ #1 > <4>[ 109.735159] Hardware name: Gigabyte Technology Co., Ltd. GB-Z390 > Garuda/GB-Z390 Garuda-CF, BIOS IG1c 11/19/2019 > <4>[ 109.735160] Workqueue: events_unbound async_run_entry_fn > <4>[ 109.735163] RIP: 0010:i915_ttm_resource_mappable+0x4/0x30 [i915] > <4>[ 109.735286] Code: b8 f9 ff ff ff eb c2 e8 aa 5e 52 e1 e9 4f 0f > 18 00 0f 1f 44 00 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 > 66 0f 1f 00 <8b> 57 10 b8 01 00 00 00 85 d2 74 15 48 8b 47 08 48 05 ff > 0f 00 00 > <4>[ 109.735288] RSP: 0018:ffffc90000f339a8 EFLAGS: 00010246 > <4>[ 109.735289] RAX: 0000000000000000 RBX: 0000000000000000 RCX: > ffff88810cea3a00 > <4>[ 109.735290] RDX: 0000000000000000 RSI: ffffc90000f33af0 RDI: > 0000000000000000 > <4>[ 109.735292] RBP: ffff88811645d7c0 R08: 0000000000000000 R09: > ffff888123afa940 > <4>[ 109.735292] R10: 0000000000000001 R11: ffff888104b70040 R12: > 0000000000000000 > <4>[ 109.735293] R13: 0000000000000000 R14: ffffc90000f33b08 R15: > ffffc90000f33af0 > <4>[ 109.735294] FS: 0000000000000000(0000) > GS:ffff8884ad680000(0000) knlGS:0000000000000000 > <4>[ 109.735295] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > <4>[ 109.735296] CR2: 0000000000000010 CR3: 000000011f9c6003 CR4: > 00000000003706e0 > <4>[ 109.735297] DR0: 0000000000000000 DR1: 0000000000000000 DR2: > 0000000000000000 > <4>[ 109.735298] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: > 0000000000000400 > <4>[ 109.735299] Call Trace: > <4>[ 109.735300] > <4>[ 109.735301] __i915_ttm_move+0x128/0x940 [i915] > <4>[ 109.735408] ? dma_resv_iter_next+0x91/0xb0 > <4>[ 109.735412] ? dma_resv_iter_first+0x42/0xb0 > <4>[ 109.735414] ? i915_deps_add_resv+0x4c/0xc0 [i915] > <4>[ 109.735520] i915_gem_obj_copy_ttm+0x12f/0x250 [i915] > <4>[ 109.735625] i915_ttm_restore+0x167/0x250 [i915] > <4>[ 109.735759] i915_gem_process_region+0x27a/0x3b0 [i915] > <4>[ 109.735881] i915_ttm_restore_region+0x4b/0x70 [i915] > <4>[ 109.735999] lmem_restore+0x3a/0x60 [i915] > <4>[ 109.736101] i915_gem_resume+0x4c/0x100 [i915] > <4>[ 109.736202] i915_drm_resume+0xc2/0x170 [i915] > > Plus some other less obvious issue(s) with some tests failing. > >> Christian.