From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD3AEC52D7D for ; Sat, 17 Aug 2024 10:38:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8B7ED10E07D; Sat, 17 Aug 2024 10:38:13 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="B9IQyqmh"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 13F6510E783; Fri, 16 Aug 2024 13:59:14 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2D3AF62122; Fri, 16 Aug 2024 13:59:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E838C32782; Fri, 16 Aug 2024 13:59:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723816752; bh=AYjyt3Zr4yYkK8EpDLsOl7+GIl2rfY/yAMJVs4wWqzE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=B9IQyqmh350p67tFsMJW4RhPtoUf9FqudC5otI9WnV1xa59NqqV1PpqbArYqhOgoj EeBRL4DgY8iAU/sPILsxMfXIHc69OZS+vB7CQuFwufeD/Nr/Ux0keuJJsTQ9XCHarv arUrZfML86yC/GNemrzAFY549WogD5FQU23OjeQGTIBEax6Cjh0gbPS4dIwEek08QI boVM6BlIgQqrHFqLO1oqCXOxxMNRRNk/EzzS23eHD0J2tAJR6HdQxhS9jrAg5uHg24 1ULRAyqkNB4IwvVzBev2Vyh96FicfZIUXAeZs6DXysH5/GPG3jvuYUYgVknbuJqFLa yx5tetp8tG83A== Message-ID: Date: Fri, 16 Aug 2024 15:59:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 69/86] drm/nouveau: Run DRM default client setup To: Thomas Zimmermann Cc: daniel@ffwll.ch, airlied@gmail.com, jfalempe@redhat.com, javierm@redhat.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org, Karol Herbst , Lyude Paul References: <20240816125408.310253-1-tzimmermann@suse.de> <20240816125408.310253-70-tzimmermann@suse.de> From: Danilo Krummrich Content-Language: en-US In-Reply-To: <20240816125408.310253-70-tzimmermann@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Sat, 17 Aug 2024 10:38:10 +0000 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 8/16/24 2:23 PM, Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The nouveau driver specifies a preferred color mode depending on > the available video memory, with a default of 32. Adapt this for > the new client interface. > > Signed-off-by: Thomas Zimmermann Acked-by: Danilo Krummrich > Cc: Karol Herbst > Cc: Lyude Paul > Cc: Danilo Krummrich > --- > drivers/gpu/drm/nouveau/nouveau_drm.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c > index 4a9a9b9c3935..445ebedf70d6 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_drm.c > +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c > @@ -31,6 +31,7 @@ > #include > > #include > +#include > #include > #include > #include > @@ -873,9 +874,9 @@ static int nouveau_drm_probe(struct pci_dev *pdev, > goto fail_pci; > > if (drm->client.device.info.ram_size <= 32 * 1024 * 1024) > - drm_fbdev_ttm_setup(drm->dev, 8); > + drm_client_setup(drm->dev, drm_format_info(DRM_FORMAT_C8)); > else > - drm_fbdev_ttm_setup(drm->dev, 32); > + drm_client_setup(drm->dev, NULL); > > quirk_broken_nv_runpm(pdev); > return 0; > @@ -1317,6 +1318,8 @@ driver_stub = { > .dumb_create = nouveau_display_dumb_create, > .dumb_map_offset = drm_gem_ttm_dumb_map_offset, > > + DRM_FBDEV_TTM_DRIVER_OPS, > + > .name = DRIVER_NAME, > .desc = DRIVER_DESC, > #ifdef GIT_REVISION