From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Souza, Jose" <jose.souza@intel.com>
Subject: Re: [PATCH v2 12/23] drm/i915: Sanitize the TypeC
 connect/detect sequences
Date: Wed, 26 Jun 2019 23:55:21 +0000
Message-ID: <d3163b2e4ffb41c9c9d59f6d196fee75bacdee81.camel@intel.com>
References: <20190620140600.11357-1-imre.deak@intel.com>
 <20190620140600.11357-13-imre.deak@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 80DC46E55A
 for <intel-gfx@lists.freedesktop.org>; Wed, 26 Jun 2019 23:55:23 +0000 (UTC)
In-Reply-To: <20190620140600.11357-13-imre.deak@intel.com>
Content-Language: en-US
Content-ID: <45B770D7F602904AAE5892BF6EB1B525@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>, "Deak, Imre" <imre.deak@intel.com>
Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCAyMDE5LTA2LTIwIGF0IDE3OjA1ICswMzAwLCBJbXJlIERlYWsgd3JvdGU6DQo+IE1h
a2UgdGhlIG9yZGVyIGR1cmluZyBkZXRlY3Rpb24gbW9yZSBjb25zaXN0ZW50OiBmaXJzdCByZXNl
dCB0aGUNCj4gVHlwZUMNCj4gcG9ydCBtb2RlIGlmIG5lZWRlZCAoYWRkaW5nIG5ldyBoZWxwZXJz
IGZvciB0aGlzKSwgdGhlbiBkZXRlY3QgYW55DQo+IGNvbm5lY3RlZCBzaW5rLg0KPiANCj4gVG8g
Y2hlY2sgaWYgYSBwb3J0IG1vZGUgcmVzZXQgaXMgbmVlZGVkIGRldGVybWluZSBmaXJzdCB0aGUg
dGFyZ2V0DQo+IHBvcnQNCj4gbW9kZSBiYXNlZCBvbiB0aGUgbGl2ZSBzdGF0dXMgaWYgYSBzaW5r
IGlzIGFscmVhZHkgY29ubmVjdGVkIG9yIHRoZQ0KPiBQSFkgc3RhdHVzIGNvbXBsZXRlIGZsYWcg
b3RoZXJ3aXNlLg0KPiANCj4gQWRkIGEgV0FSTiBpbiBsZWdhY3kgbW9kZSBpZiB1bmV4cGVjdGVk
bHkgd2UgY2FuJ3Qgc2V0IHRoZSB1bnNhZmUNCj4gbW9kZQ0KPiBvciBpZiB0aGUgRklBIGRvZXNu
J3QgcHJvdmlkZSB0aGUgNCBsYW5lcyByZXF1aXJlZC4NCj4gDQo+IENjOiBKb3PDqSBSb2JlcnRv
IGRlIFNvdXphIDxqb3NlLnNvdXphQGludGVsLmNvbT4NCj4gQ2M6IFJvZHJpZ28gVml2aSA8cm9k
cmlnby52aXZpQGludGVsLmNvbT4NCj4gQ2M6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56YW5vbmlA
aW50ZWwuY29tPg0KPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4Lmlu
dGVsLmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29t
Pg0KPiAtLS0NCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfdGMuYyB8IDk2
ICsrKysrKysrKysrKy0tLS0tLS0tLS0tDQo+IC0tDQo+ICAxIGZpbGUgY2hhbmdlZCwgNDcgaW5z
ZXJ0aW9ucygrKSwgNDkgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n
cHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF90Yy5jDQo+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv
ZGlzcGxheS9pbnRlbF90Yy5jDQo+IGluZGV4IGZmZmU0YzRhNjYwMi4uZWQyMjUzYjIxYjA5IDEw
MDY0NA0KPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX3RjLmMNCj4g
KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF90Yy5jDQo+IEBAIC0xNzIs
NDEgKzE3Miw0MyBAQCBzdGF0aWMgYm9vbCBpY2xfdGNfcGh5X3NldF9zYWZlX21vZGUoc3RydWN0
DQo+IGludGVsX2RpZ2l0YWxfcG9ydCAqZGlnX3BvcnQsDQo+ICAgKiB3aWxsIHJlcXVpcmUgYSBs
b3Qgb2YgY29vcmRpbmF0aW9uIHdpdGggdXNlciBzcGFjZSBhbmQgdGhvcm91Z2gNCj4gdGVzdGlu
ZyBmb3INCj4gICAqIHRoZSBleHRyYSBwb3NzaWJsZSBjYXNlcy4NCj4gICAqLw0KPiAtc3RhdGlj
IGJvb2wgaWNsX3RjX3BoeV9jb25uZWN0KHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19w
b3J0KQ0KPiArc3RhdGljIHZvaWQgaWNsX3RjX3BoeV9jb25uZWN0KHN0cnVjdCBpbnRlbF9kaWdp
dGFsX3BvcnQgKmRpZ19wb3J0KQ0KPiAgew0KPiAtCXUzMiBsaXZlX3N0YXR1c19tYXNrOw0KPiAt
DQo+IC0JaWYgKGRpZ19wb3J0LT50Y19tb2RlICE9IFRDX1BPUlRfTEVHQUNZICYmDQo+IC0JICAg
IGRpZ19wb3J0LT50Y19tb2RlICE9IFRDX1BPUlRfRFBfQUxUKQ0KPiAtCQlyZXR1cm4gdHJ1ZTsN
Cj4gLQ0KPiAgCWlmICghaWNsX3RjX3BoeV9zdGF0dXNfY29tcGxldGUoZGlnX3BvcnQpKSB7DQo+
ICAJCURSTV9ERUJVR19LTVMoIlBvcnQgJXM6IFBIWSBub3QgcmVhZHlcbiIsDQo+ICAJCQkgICAg
ICBkaWdfcG9ydC0+dGNfcG9ydF9uYW1lKTsNCj4gLQkJV0FSTl9PTihkaWdfcG9ydC0+dGNfbGVn
YWN5X3BvcnQpOw0KPiAtCQlyZXR1cm4gZmFsc2U7DQo+ICsJCWdvdG8gb3V0X3NldF90YnRfYWx0
X21vZGU7DQo+ICAJfQ0KPiAgDQo+IC0JaWYgKCFpY2xfdGNfcGh5X3NldF9zYWZlX21vZGUoZGln
X3BvcnQsIGZhbHNlKSkNCj4gLQkJcmV0dXJuIGZhbHNlOw0KPiArCWlmICghaWNsX3RjX3BoeV9z
ZXRfc2FmZV9tb2RlKGRpZ19wb3J0LCBmYWxzZSkgJiYNCj4gKwkgICAgIVdBUk5fT04oZGlnX3Bv
cnQtPnRjX2xlZ2FjeV9wb3J0KSkNCj4gKwkJZ290byBvdXRfc2V0X3RidF9hbHRfbW9kZTsNCg0K
TWFya2luZyBhcyBub3Qgc2FmZSBldmVuIGZvciBUQlQ/DQoNCj4gIA0KPiAtCWlmIChkaWdfcG9y
dC0+dGNfbW9kZSA9PSBUQ19QT1JUX0xFR0FDWSkNCj4gLQkJcmV0dXJuIHRydWU7DQo+ICsJaWYg
KGRpZ19wb3J0LT50Y19sZWdhY3lfcG9ydCkgew0KPiArCQlXQVJOX09OKGludGVsX3RjX3BvcnRf
ZmlhX21heF9sYW5lX2NvdW50KGRpZ19wb3J0KSAhPQ0KPiA0KTsNCj4gKwkJZGlnX3BvcnQtPnRj
X21vZGUgPSBUQ19QT1JUX0xFR0FDWTsNCj4gIA0KPiAtCWxpdmVfc3RhdHVzX21hc2sgPSB0Y19w
b3J0X2xpdmVfc3RhdHVzX21hc2soZGlnX3BvcnQpOw0KPiArCQlyZXR1cm47DQo+ICsJfQ0KPiAg
DQo+ICAJLyoNCj4gIAkgKiBOb3cgd2UgaGF2ZSB0byByZS1jaGVjayB0aGUgbGl2ZSBzdGF0ZSwg
aW4gY2FzZSB0aGUgcG9ydA0KPiByZWNlbnRseQ0KPiAgCSAqIGJlY2FtZSBkaXNjb25uZWN0ZWQu
IE5vdCBuZWNlc3NhcnkgZm9yIGxlZ2FjeSBtb2RlLg0KPiAgCSAqLw0KPiAtCWlmICghKGxpdmVf
c3RhdHVzX21hc2sgJiBCSVQoVENfUE9SVF9EUF9BTFQpKSkgew0KPiArCWlmICghKHRjX3BvcnRf
bGl2ZV9zdGF0dXNfbWFzayhkaWdfcG9ydCkgJg0KPiBCSVQoVENfUE9SVF9EUF9BTFQpKSkgew0K
PiAgCQlEUk1fREVCVUdfS01TKCJQb3J0ICVzOiBQSFkgc3VkZGVuIGRpc2Nvbm5lY3RcbiIsDQo+
ICAJCQkgICAgICBkaWdfcG9ydC0+dGNfcG9ydF9uYW1lKTsNCj4gLQkJaWNsX3RjX3BoeV9kaXNj
b25uZWN0KGRpZ19wb3J0KTsNCj4gLQkJcmV0dXJuIGZhbHNlOw0KPiArCQlnb3RvIG91dF9zZXRf
c2FmZV9tb2RlOw0KPiAgCX0NCj4gIA0KPiAtCXJldHVybiB0cnVlOw0KPiArCWRpZ19wb3J0LT50
Y19tb2RlID0gVENfUE9SVF9EUF9BTFQ7DQo+ICsNCj4gKwlyZXR1cm47DQo+ICsNCj4gK291dF9z
ZXRfc2FmZV9tb2RlOg0KPiArCWljbF90Y19waHlfc2V0X3NhZmVfbW9kZShkaWdfcG9ydCwgdHJ1
ZSk7DQo+ICtvdXRfc2V0X3RidF9hbHRfbW9kZToNCj4gKwlkaWdfcG9ydC0+dGNfbW9kZSA9IFRD
X1BPUlRfVEJUX0FMVDsNCj4gIH0NCj4gIA0KPiAgLyoNCj4gQEAgLTIyNywyNyArMjI5LDM3IEBA
IHZvaWQgaWNsX3RjX3BoeV9kaXNjb25uZWN0KHN0cnVjdA0KPiBpbnRlbF9kaWdpdGFsX3BvcnQg
KmRpZ19wb3J0KQ0KPiAgCWRlZmF1bHQ6DQo+ICAJCU1JU1NJTkdfQ0FTRShkaWdfcG9ydC0+dGNf
bW9kZSk7DQo+ICAJfQ0KPiArfQ0KPiAgDQo+IC0JRFJNX0RFQlVHX0tNUygiUG9ydCAlczogbW9k
ZSAlcyBkaXNjb25uZWN0ZWRcbiIsDQo+IC0JCSAgICAgIGRpZ19wb3J0LT50Y19wb3J0X25hbWUs
DQo+IC0JCSAgICAgIHRjX3BvcnRfbW9kZV9uYW1lKGRpZ19wb3J0LT50Y19tb2RlKSk7DQo+ICtz
dGF0aWMgZW51bSB0Y19wb3J0X21vZGUNCj4gK2ludGVsX3RjX3BvcnRfZ2V0X3RhcmdldF9tb2Rl
KHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0KQ0KPiArew0KPiArCXUzMiBsaXZl
X3N0YXR1c19tYXNrID0gdGNfcG9ydF9saXZlX3N0YXR1c19tYXNrKGRpZ19wb3J0KTsNCj4gKw0K
PiArCWlmIChsaXZlX3N0YXR1c19tYXNrKQ0KPiArCQlyZXR1cm4gZmxzKGxpdmVfc3RhdHVzX21h
c2spIC0gMTsNCj4gKw0KPiArCXJldHVybiBpY2xfdGNfcGh5X3N0YXR1c19jb21wbGV0ZShkaWdf
cG9ydCkgJiYNCj4gKwkgICAgICAgZGlnX3BvcnQtPnRjX2xlZ2FjeV9wb3J0ID8gVENfUE9SVF9M
RUdBQ1kgOg0KPiArCQkJCQkgIFRDX1BPUlRfVEJUX0FMVDsNCg0KWW91IGFyZSByaWdodCBhYm91
dCB0aGUgb3JkZXIgdGhhdCBDIHdpbGwgZXhlY3V0ZSB0aGlzIGJ1dCBjb3VsZCB5b3UNCmFkZCBh
IHBhaXIgb2YgcGFyZW50aGVzaXMgYXJvdW5kIGljbF90Y19waHlfc3RhdHVzX2NvbXBsZXRlKGRp
Z19wb3J0KQ0KJiYgZGlnX3BvcnQtPnRjX2xlZ2FjeV9wb3J0IHRvIG1ha2UgZWFzaWVyIHRvIHJl
YWQ/DQoNCj4gIH0NCj4gIA0KPiAtc3RhdGljIHZvaWQgaWNsX3VwZGF0ZV90Y19wb3J0X3R5cGUo
c3RydWN0IGRybV9pOTE1X3ByaXZhdGUNCj4gKmRldl9wcml2LA0KPiAtCQkJCSAgICBzdHJ1Y3Qg
aW50ZWxfZGlnaXRhbF9wb3J0DQo+ICppbnRlbF9kaWdfcG9ydCwNCj4gLQkJCQkgICAgdTMyIGxp
dmVfc3RhdHVzX21hc2spDQo+ICtzdGF0aWMgdm9pZCBpbnRlbF90Y19wb3J0X3Jlc2V0X21vZGUo
c3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydA0KPiAqZGlnX3BvcnQpDQo+ICB7DQo+IC0JZW51bSB0
Y19wb3J0X21vZGUgb2xkX21vZGUgPSBpbnRlbF9kaWdfcG9ydC0+dGNfbW9kZTsNCj4gKwllbnVt
IHRjX3BvcnRfbW9kZSBvbGRfdGNfbW9kZSA9IGRpZ19wb3J0LT50Y19tb2RlOw0KPiAgDQo+IC0J
aWYgKCFsaXZlX3N0YXR1c19tYXNrKQ0KPiAtCQlyZXR1cm47DQo+ICsJaWNsX3RjX3BoeV9kaXNj
b25uZWN0KGRpZ19wb3J0KTsNCj4gKwlpY2xfdGNfcGh5X2Nvbm5lY3QoZGlnX3BvcnQpOw0KPiAg
DQo+IC0JaW50ZWxfZGlnX3BvcnQtPnRjX21vZGUgPSBmbHMobGl2ZV9zdGF0dXNfbWFzaykgLSAx
Ow0KPiArCURSTV9ERUJVR19LTVMoIlBvcnQgJXM6IFRDIHBvcnQgbW9kZSByZXNldCAoJXMgLT4g
JXMpXG4iLA0KPiArCQkgICAgICBkaWdfcG9ydC0+dGNfcG9ydF9uYW1lLA0KPiArCQkgICAgICB0
Y19wb3J0X21vZGVfbmFtZShvbGRfdGNfbW9kZSksDQo+ICsJCSAgICAgIHRjX3BvcnRfbW9kZV9u
YW1lKGRpZ19wb3J0LT50Y19tb2RlKSk7DQo+ICt9DQo+ICANCj4gLQlpZiAob2xkX21vZGUgIT0g
aW50ZWxfZGlnX3BvcnQtPnRjX21vZGUpDQo+IC0JCURSTV9ERUJVR19LTVMoIlBvcnQgJXM6IHBv
cnQgaGFzIG1vZGUgJXNcbiIsDQo+IC0JCQkgICAgICBpbnRlbF9kaWdfcG9ydC0+dGNfcG9ydF9u
YW1lLA0KPiAtCQkJICAgICAgdGNfcG9ydF9tb2RlX25hbWUoaW50ZWxfZGlnX3BvcnQtDQo+ID50
Y19tb2RlKSk7DQo+ICtzdGF0aWMgYm9vbCBpbnRlbF90Y19wb3J0X25lZWRzX3Jlc2V0KHN0cnVj
dCBpbnRlbF9kaWdpdGFsX3BvcnQNCj4gKmRpZ19wb3J0KQ0KPiArew0KPiArCXJldHVybiBpbnRl
bF90Y19wb3J0X2dldF90YXJnZXRfbW9kZShkaWdfcG9ydCkgIT0gZGlnX3BvcnQtDQo+ID50Y19t
b2RlOw0KPiAgfQ0KPiAgDQo+ICAvKg0KPiBAQCAtMjYyLDI0ICsyNzQsMTAgQEAgc3RhdGljIHZv
aWQgaWNsX3VwZGF0ZV90Y19wb3J0X3R5cGUoc3RydWN0DQo+IGRybV9pOTE1X3ByaXZhdGUgKmRl
dl9wcml2LA0KPiAgICovDQo+ICBib29sIGludGVsX3RjX3BvcnRfY29ubmVjdGVkKHN0cnVjdCBp
bnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0KQ0KPiAgew0KPiAtCXN0cnVjdCBkcm1faTkxNV9w
cml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGlnX3BvcnQtDQo+ID5iYXNlLmJhc2UuZGV2KTsN
Cj4gLQl1MzIgbGl2ZV9zdGF0dXNfbWFzayA9IHRjX3BvcnRfbGl2ZV9zdGF0dXNfbWFzayhkaWdf
cG9ydCk7DQo+IC0NCj4gLQkvKg0KPiAtCSAqIFRoZSBzcGVjIHNheXMgd2Ugc2hvdWxkbid0IGJl
IHVzaW5nIHRoZSBJU1IgYml0cyBmb3INCj4gZGV0ZWN0aW5nDQo+IC0JICogYmV0d2VlbiBUQyBh
bmQgVEJULiBXZSBzaG91bGQgdXNlIERGTEVYRFBTUC4NCj4gLQkgKi8NCj4gLQlpZiAoIWxpdmVf
c3RhdHVzX21hc2sgJiYgIWRpZ19wb3J0LT50Y19sZWdhY3lfcG9ydCkgew0KPiAtCQlpY2xfdGNf
cGh5X2Rpc2Nvbm5lY3QoZGlnX3BvcnQpOw0KPiAtDQo+IC0JCXJldHVybiBmYWxzZTsNCj4gLQl9
DQo+IC0NCj4gLQlpY2xfdXBkYXRlX3RjX3BvcnRfdHlwZShkZXZfcHJpdiwgZGlnX3BvcnQsIGxp
dmVfc3RhdHVzX21hc2spOw0KPiAtCWlmICghaWNsX3RjX3BoeV9jb25uZWN0KGRpZ19wb3J0KSkN
Cj4gLQkJcmV0dXJuIGZhbHNlOw0KPiArCWlmIChpbnRlbF90Y19wb3J0X25lZWRzX3Jlc2V0KGRp
Z19wb3J0KSkNCj4gKwkJaW50ZWxfdGNfcG9ydF9yZXNldF9tb2RlKGRpZ19wb3J0KTsNCj4gIA0K
PiAtCXJldHVybiB0cnVlOw0KPiArCXJldHVybiB0Y19wb3J0X2xpdmVfc3RhdHVzX21hc2soZGln
X3BvcnQpICYgQklUKGRpZ19wb3J0LQ0KPiA+dGNfbW9kZSk7DQo+ICB9DQo+ICANCj4gIHZvaWQg
aW50ZWxfdGNfcG9ydF9pbml0KHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0LCBi
b29sDQo+IGlzX2xlZ2FjeSkNCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr
dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu
dGVsLWdmeA==