From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Subject: Re: [PATCH 2/5] drm/i915/wopcm: Check WOPCM layout
 separately from calculations
Date: Thu, 15 Aug 2019 17:10:26 -0700
Message-ID: <d3f8973f-8aa7-e7e3-6d44-30e42e6537d5@intel.com>
References: <20190815171228.31920-3-michal.wajdeczko@intel.com>
 <20190815214841.17856-1-michal.wajdeczko@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 0ECF16E162
 for <intel-gfx@lists.freedesktop.org>; Fri, 16 Aug 2019 00:10:27 +0000 (UTC)
In-Reply-To: <20190815214841.17856-1-michal.wajdeczko@intel.com>
Content-Language: en-US
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

CgpPbiA4LzE1LzE5IDI6NDggUE0sIE1pY2hhbCBXYWpkZWN6a28gd3JvdGU6Cj4gV2UgY2FuIGRv
IFdPUENNIHBhcnRpdGlvbmluZyB1c2luZyByb3VnaCBlc3RpbWF0ZXMgYW5kIGxpbWl0cwo+IGFu
ZCBwZXJmb3JtIGRldGFpbGVkIGNoZWNrIGFzIHNlcGFyYXRlIHN0ZXAuCj4gCj4gdjI6IG9vcHMh
IHMvbWF4L21pbgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1pY2hhbCBXYWpkZWN6a28gPG1pY2hhbC53
YWpkZWN6a29AaW50ZWwuY29tPgo+IENjOiBEYW5pZWxlIENlcmFvbG8gU3B1cmlvIDxkYW5pZWxl
LmNlcmFvbG9zcHVyaW9AaW50ZWwuY29tPgo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlz
LXdpbHNvbi5jby51az4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3dvcGNt
LmMgfCAxMDUgKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2Vk
LCA3NCBpbnNlcnRpb25zKCspLCAzMSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfd29wY20uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu
dGVsX3dvcGNtLmMKPiBpbmRleCAyOTc1ZTAwZjU3ZjUuLjM5ZjI3NjRjYTNhOCAxMDA2NDQKPiAt
LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF93b3BjbS5jCj4gKysrIGIvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfd29wY20uYwo+IEBAIC04Nyw3ICs4Nyw4IEBAIHZvaWQgaW50ZWxf
d29wY21faW5pdF9lYXJseShzdHJ1Y3QgaW50ZWxfd29wY20gKndvcGNtKQo+ICAgCWVsc2UKPiAg
IAkJd29wY20tPnNpemUgPSBHRU45X1dPUENNX1NJWkU7Cj4gICAKPiAtCURSTV9ERUJVR19EUklW
RVIoIldPUENNIHNpemU6ICV1S2lCXG4iLCB3b3BjbS0+c2l6ZSAvIDEwMjQpOwo+ICsJRFJNX0RF
Vl9ERUJVR19EUklWRVIoaTkxNS0+ZHJtLmRldiwgIldPUENNOiBzaXplICV1S2lCXG4iLAo+ICsJ
CQkgICAgIHdvcGNtLT5zaXplIC8gU1pfMUspOwo+ICAgfQo+ICAgCj4gICBzdGF0aWMgaW5saW5l
IHUzMiBjb250ZXh0X3Jlc2VydmVkX3NpemUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUp
Cj4gQEAgLTEzOCw5ICsxMzksOSBAQCBzdGF0aWMgaW5saW5lIGludCBnZW45X2NoZWNrX2h1Y19m
d19maXRzKHUzMiBndWNfd29wY21fc2l6ZSwgdTMyIGh1Y19md19zaXplKQo+ICAgCXJldHVybiAw
Owo+ICAgfQo+ICAgCj4gLXN0YXRpYyBpbmxpbmUgaW50IGNoZWNrX2h3X3Jlc3RyaWN0aW9uKHN0
cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+IC0JCQkJICAgICAgIHUzMiBndWNfd29wY21f
YmFzZSwgdTMyIGd1Y193b3BjbV9zaXplLAo+IC0JCQkJICAgICAgIHUzMiBodWNfZndfc2l6ZSkK
PiArc3RhdGljIGlubGluZSBib29sIGNoZWNrX2h3X3Jlc3RyaWN0aW9ucyhzdHJ1Y3QgZHJtX2k5
MTVfcHJpdmF0ZSAqaTkxNSwKPiArCQkJCQkgdTMyIGd1Y193b3BjbV9iYXNlLCB1MzIgZ3VjX3dv
cGNtX3NpemUsCj4gKwkJCQkJIHUzMiBodWNfZndfc2l6ZSkKPiAgIHsKPiAgIAlpbnQgZXJyID0g
MDsKPiAgIAo+IEBAIC0xNTEsNyArMTUyLDY0IEBAIHN0YXRpYyBpbmxpbmUgaW50IGNoZWNrX2h3
X3Jlc3RyaWN0aW9uKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+ICAgCSAgICAoSVNf
R0VOKGk5MTUsIDkpIHx8IElTX0NOTF9SRVZJRChpOTE1LCBDTkxfUkVWSURfQTAsIENOTF9SRVZJ
RF9BMCkpKQo+ICAgCQllcnIgPSBnZW45X2NoZWNrX2h1Y19md19maXRzKGd1Y193b3BjbV9zaXpl
LCBodWNfZndfc2l6ZSk7Cj4gICAKPiAtCXJldHVybiBlcnI7Cj4gKwlyZXR1cm4gIWVycjsKPiAr
fQo+ICsKPiArc3RhdGljIGlubGluZSBib29sIF9fY2hlY2tfbGF5b3V0KHN0cnVjdCBkcm1faTkx
NV9wcml2YXRlICppOTE1LCB1MzIgd29wY21fc2l6ZSwKPiArCQkJCSAgdTMyIGd1Y193b3BjbV9i
YXNlLCB1MzIgZ3VjX3dvcGNtX3NpemUsCj4gKwkJCQkgIHUzMiBndWNfZndfc2l6ZSwgdTMyIGh1
Y19md19zaXplKQo+ICt7Cj4gKwljb25zdCB1MzIgY3R4X3JzdmQgPSBjb250ZXh0X3Jlc2VydmVk
X3NpemUoaTkxNSk7Cj4gKwl1MzIgc2l6ZTsKPiArCj4gKwlpZiAodW5saWtlbHkoZ3VjX3dvcGNt
X2Jhc2UgPiB3b3BjbV9zaXplKSkgewo+ICsJCWRldl9lcnIoaTkxNS0+ZHJtLmRldiwKPiArCQkJ
IldPUENNOiBpbnZhbGlkIEd1QyByZWdpb24gYmFzZTogJXVLID4gJXVLXG4iLAo+ICsJCQlndWNf
d29wY21fYmFzZSAvIFNaXzFLLCB3b3BjbV9zaXplIC8gU1pfMUspOwo+ICsJCXJldHVybiBmYWxz
ZTsKPiArCX0KPiArCj4gKwlzaXplID0gd29wY21fc2l6ZSAtIGN0eF9yc3ZkOwo+ICsJaWYgKHVu
bGlrZWx5KGd1Y193b3BjbV9iYXNlID4gc2l6ZSkpIHsKPiArCQlkZXZfZXJyKGk5MTUtPmRybS5k
ZXYsCj4gKwkJCSJXT1BDTTogaW52YWxpZCBHdUMgcmVnaW9uIGJhc2U6ICV1SyA+ICV1S1xuIiwK
PiArCQkJZ3VjX3dvcGNtX2Jhc2UgLyBTWl8xSywgc2l6ZSAvIFNaXzFLKTsKPiArCQlyZXR1cm4g
ZmFsc2U7Cj4gKwl9Cj4gKwo+ICsJaWYgKHVubGlrZWx5KGd1Y193b3BjbV9zaXplID4gd29wY21f
c2l6ZSkpIHsKPiArCQlkZXZfZXJyKGk5MTUtPmRybS5kZXYsCj4gKwkJCSJXT1BDTTogaW52YWxp
ZCBHdUMgcmVnaW9uIHNpemU6ICV1SyA+ICV1S1xuIiwKPiArCQkJZ3VjX3dvcGNtX3NpemUgLyBT
Wl8xSywgd29wY21fc2l6ZSAvIFNaXzFLKTsKPiArCQlyZXR1cm4gZmFsc2U7Cj4gKwl9Cj4gKwo+
ICsJc2l6ZSA9IHdvcGNtX3NpemUgLSBndWNfd29wY21fYmFzZSAtIGN0eF9yc3ZkOwo+ICsJaWYg
KHVubGlrZWx5KGd1Y193b3BjbV9zaXplID4gc2l6ZSkpIHsKPiArCQlkZXZfZXJyKGk5MTUtPmRy
bS5kZXYsCj4gKwkJCSJXT1BDTTogaW52YWxpZCBHdUMgcmVnaW9uIHNpemU6ICV1SyA+ICV1S1xu
IiwKPiArCQkJZ3VjX3dvcGNtX3NpemUgLyBTWl8xSywgc2l6ZSAvIFNaXzFLKTsKPiArCQlyZXR1
cm4gZmFsc2U7Cj4gKwl9CgoKSSB0aGluayB3ZSBjYW4gY29uc29saWRhdGUgYWxsIHRoZSBjaGVj
a3MgYWJvdmUgaW4ganVzdDoKCndvcGNtX2d1Y19tYXggPSB3b3BjbV9zaXplIC0gY3R4X3JzdmQ7
CmlmIChyYW5nZV9vdmVyZmxvd3MoZ3VjX3dvcGNtX2Jhc2UsIGd1Y193b3BjbV9zaXplLCB3b3Bj
bV9ndWNfbWF4KQoJCXJldHVybiBmYWxzZTsKCgo+ICsKPiArCXNpemUgPSBndWNfZndfc2l6ZSAr
IEdVQ19XT1BDTV9SRVNFUlZFRCArIEdVQ19XT1BDTV9TVEFDS19SRVNFUlZFRDsKPiArCWlmICh1
bmxpa2VseShndWNfd29wY21fc2l6ZSA8IHNpemUpKSB7Cj4gKwkJZGV2X2VycihpOTE1LT5kcm0u
ZGV2LCAiV09QQ006IG5vIHNwYWNlIGZvciAlczogJXVLIDwgJXVLXG4iLAo+ICsJCQlpbnRlbF91
Y19md190eXBlX3JlcHIoSU5URUxfVUNfRldfVFlQRV9HVUMpLAo+ICsJCQlndWNfd29wY21fc2l6
ZSAvIFNaXzFLLCBzaXplIC8gU1pfMUspOwo+ICsJCXJldHVybiBmYWxzZTsKPiArCX0KPiArCj4g
KwlzaXplID0gaHVjX2Z3X3NpemUgKyBXT1BDTV9SRVNFUlZFRF9TSVpFOwo+ICsJaWYgKHVubGlr
ZWx5KGd1Y193b3BjbV9iYXNlIDwgc2l6ZSkpIHsKPiArCQlkZXZfZXJyKGk5MTUtPmRybS5kZXYs
ICJXT1BDTTogbm8gc3BhY2UgZm9yICVzOiAldUsgPCAldUtcbiIsCj4gKwkJCWludGVsX3VjX2Z3
X3R5cGVfcmVwcihJTlRFTF9VQ19GV19UWVBFX0hVQyksCj4gKwkJCWd1Y193b3BjbV9iYXNlIC8g
U1pfMUssIHNpemUgLyBTWl8xSyk7Cj4gKwkJcmV0dXJuIGZhbHNlOwo+ICsJfQo+ICsKPiArCXJl
dHVybiBjaGVja19od19yZXN0cmljdGlvbnMoaTkxNSwgZ3VjX3dvcGNtX2Jhc2UsIGd1Y193b3Bj
bV9zaXplLAo+ICsJCQkJICAgICBodWNfZndfc2l6ZSk7Cj4gICB9Cj4gICAKPiAgIC8qKgo+IEBA
IC0xNzIsOCArMjMwLDYgQEAgdm9pZCBpbnRlbF93b3BjbV9pbml0KHN0cnVjdCBpbnRlbF93b3Bj
bSAqd29wY20pCj4gICAJdTMyIGN0eF9yc3ZkID0gY29udGV4dF9yZXNlcnZlZF9zaXplKGk5MTUp
Owo+ICAgCXUzMiBndWNfd29wY21fYmFzZTsKPiAgIAl1MzIgZ3VjX3dvcGNtX3NpemU7Cj4gLQl1
MzIgZ3VjX3dvcGNtX3JzdmQ7Cj4gLQlpbnQgZXJyOwo+ICAgCj4gICAJaWYgKCFndWNfZndfc2l6
ZSkKPiAgIAkJcmV0dXJuOwo+IEBAIC0xODMsMzkgKzIzOSwyNiBAQCB2b2lkIGludGVsX3dvcGNt
X2luaXQoc3RydWN0IGludGVsX3dvcGNtICp3b3BjbSkKPiAgIAlHRU1fQlVHX09OKHdvcGNtLT5n
dWMuc2l6ZSk7Cj4gICAJR0VNX0JVR19PTihndWNfZndfc2l6ZSA+PSB3b3BjbS0+c2l6ZSk7Cj4g
ICAJR0VNX0JVR19PTihodWNfZndfc2l6ZSA+PSB3b3BjbS0+c2l6ZSk7Cj4gKwlHRU1fQlVHX09O
KGN0eF9yc3ZkICsgV09QQ01fUkVTRVJWRURfU0laRSA+PSB3b3BjbS0+c2l6ZSk7Cj4gICAKPiAg
IAlpZiAoaTkxNV9pbmplY3RfcHJvYmVfZmFpbHVyZShpOTE1KSkKPiAgIAkJcmV0dXJuOwo+ICAg
Cj4gICAJZ3VjX3dvcGNtX2Jhc2UgPSBBTElHTihodWNfZndfc2l6ZSArIFdPUENNX1JFU0VSVkVE
X1NJWkUsCj4gICAJCQkgICAgICAgR1VDX1dPUENNX09GRlNFVF9BTElHTk1FTlQpOwo+IC0JaWYg
KChndWNfd29wY21fYmFzZSArIGN0eF9yc3ZkKSA+PSB3b3BjbS0+c2l6ZSkgewo+IC0JCURSTV9F
UlJPUigiR3VDIFdPUENNIGJhc2UgKCV1S2lCKSBpcyB0b28gYmlnLlxuIiwKPiAtCQkJICBndWNf
d29wY21fYmFzZSAvIDEwMjQpOwo+IC0JCXJldHVybjsKPiAtCX0KPiAtCj4gKwlndWNfd29wY21f
YmFzZSA9IG1pbih3b3BjbS0+c2l6ZSAtIGN0eF9yc3ZkLCBndWNfd29wY21fYmFzZSk7CgpUaGlz
IGxpbmUgY29uZnVzZWQgbWUgcXVpdGUgYSBiaXQgdW50aWwgd2UgY2hhdHRlZCBvbiBJTSBhYm91
dCBpdC4gbWF5YmUgCmFkZCBhIGNvbW1lbnQsIGUuZy46CgovKgogICogd2Ugd2FudCB0byBrZWVw
IGFsbCB0aGUgY2hlY2tzIGluIHRoZSBzYW1lIHBsYWNlIHRvIGJlIGFibGUgdG8gcmUtdXNlCiAg
KiB0aGVtIHdoZW4gd2UgZmluZCBsb2NrZWQgdmFsdWVzIGluIFdPUENNIHNvIHdlIGRvbid0IHZh
bGlkYXRlCiAgKiBndWNfd29wY21fYmFzZSBoZXJlLCBidXQgd2Ugc3RpbGwgbmVlZCB0byBjbGFt
cCBpdCB0byBtYWtlIHN1cmUgdGhlCiAgKiBmb2xsb3dpbmcgbWF0aCBpcyBzYW5lLgogICovCgpB
bHNvLCB3aXRoIG15IHN1Z2dlc3Rpb24gZm9yIGNvbnNvbGlkYXRpb24gYWJvdmUsIGZvciB0aGUg
Y2hlY2tzIHdlIAphbHdheXMgY2FyZSBhYm91dCB3b3BjbS0+c2l6ZSAtIGN0eF9yc3ZkLCBzbyBt
YXliZSBzdG9yZSB0aGF0IGluIGEgbG9jYWwgCnZhciB0byB1c2UgaXQgaGVyZSBhbmQgYmVsb3cg
YW5kIHBhc3MgdGhhdCBpbnRvIF9fY2hlY2tfbGF5b3V0KCkuCgpEYW5pZWxlCgo+ICAgCWd1Y193
b3BjbV9zaXplID0gd29wY20tPnNpemUgLSBndWNfd29wY21fYmFzZSAtIGN0eF9yc3ZkOwo+ICAg
CWd1Y193b3BjbV9zaXplICY9IEdVQ19XT1BDTV9TSVpFX01BU0s7Cj4gICAKPiAtCURSTV9ERUJV
R19EUklWRVIoIkNhbGN1bGF0ZWQgR3VDIFdPUENNIFJlZ2lvbjogWyV1S2lCLCAldUtpQilcbiIs
Cj4gLQkJCSBndWNfd29wY21fYmFzZSAvIDEwMjQsIGd1Y193b3BjbV9zaXplIC8gMTAyNCk7Cj4g
KwlEUk1fREVWX0RFQlVHX0RSSVZFUihpOTE1LT5kcm0uZGV2LAo+ICsJCQkgICAgICJDYWxjdWxh
dGVkIEd1QyBXT1BDTSBSZWdpb246IFsldUtpQiwgJXVLaUIpXG4iLAo+ICsJCQkgICAgIGd1Y193
b3BjbV9iYXNlIC8gU1pfMUssIGd1Y193b3BjbV9zaXplIC8gU1pfMUspOwo+ICAgCj4gLQlndWNf
d29wY21fcnN2ZCA9IEdVQ19XT1BDTV9SRVNFUlZFRCArIEdVQ19XT1BDTV9TVEFDS19SRVNFUlZF
RDsKPiAtCWlmICgoZ3VjX2Z3X3NpemUgKyBndWNfd29wY21fcnN2ZCkgPiBndWNfd29wY21fc2l6
ZSkgewo+IC0JCURSTV9FUlJPUigiTmVlZCAldUtpQiBXT1BDTSBmb3IgR3VDLCAldUtpQiBhdmFp
bGFibGUuXG4iLAo+IC0JCQkgIChndWNfZndfc2l6ZSArIGd1Y193b3BjbV9yc3ZkKSAvIDEwMjQs
Cj4gLQkJCSAgZ3VjX3dvcGNtX3NpemUgLyAxMDI0KTsKPiAtCQlyZXR1cm47Cj4gKwlpZiAoX19j
aGVja19sYXlvdXQoaTkxNSwgd29wY20tPnNpemUsIGd1Y193b3BjbV9iYXNlLCBndWNfd29wY21f
c2l6ZSwKPiArCQkJICAgZ3VjX2Z3X3NpemUsIGh1Y19md19zaXplKSkgewo+ICsJCXdvcGNtLT5n
dWMuYmFzZSA9IGd1Y193b3BjbV9iYXNlOwo+ICsJCXdvcGNtLT5ndWMuc2l6ZSA9IGd1Y193b3Bj
bV9zaXplOwo+ICsJCUdFTV9CVUdfT04oIXdvcGNtLT5ndWMuYmFzZSk7Cj4gKwkJR0VNX0JVR19P
Tighd29wY20tPmd1Yy5zaXplKTsKPiAgIAl9Cj4gLQo+IC0JZXJyID0gY2hlY2tfaHdfcmVzdHJp
Y3Rpb24oaTkxNSwgZ3VjX3dvcGNtX2Jhc2UsIGd1Y193b3BjbV9zaXplLAo+IC0JCQkJICAgaHVj
X2Z3X3NpemUpOwo+IC0JaWYgKGVycikKPiAtCQlyZXR1cm47Cj4gLQo+IC0Jd29wY20tPmd1Yy5i
YXNlID0gZ3VjX3dvcGNtX2Jhc2U7Cj4gLQl3b3BjbS0+Z3VjLnNpemUgPSBndWNfd29wY21fc2l6
ZTsKPiAtCUdFTV9CVUdfT04oIXdvcGNtLT5ndWMuYmFzZSk7Cj4gLQlHRU1fQlVHX09OKCF3b3Bj
bS0+Z3VjLnNpemUpOwo+ICAgfQo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl
ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m
by9pbnRlbC1nZng=