From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B3EEEB64D9 for ; Mon, 10 Jul 2023 09:25:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ABA1F10E10D; Mon, 10 Jul 2023 09:25:27 +0000 (UTC) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id D018410E10D; Mon, 10 Jul 2023 09:25:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688981125; x=1720517125; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=PGOTy3epTYPFyVb1CAx49FFIjQC9zgRGP5LLSUNF85Q=; b=A/X4qNLW4aAG5F0SqdukgE5t1SFLpJDCc+XybkhY4x4BYNOMSHeM82Ax GWfQpWaX5E83Nm6+00xJqQGOeWQzIA1OguPC1yRC+6fTmVNi+/Gh3z2yf UNzrpI4JI1Ri+pM9IGWy2iXQWreoayImUoDqnPh568MFYjpchL/Ct8Vos P4mY+WMuaLF+g4wkinURpGwY/F5vtHAbjD/20MM0pNpzFiFL2Ug5TTaRC vqB1hleM3AyWPnXFjrtuulnjmWsJK2wiWUEBJ5DI1M46SHIRpxEO7GVl6 na5dZvfcF19b3+Fz0h/+2XezTQRXUzswkpMTLe+pSFQzRYhPT27cxCJP5 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="427989963" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="427989963" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2023 02:25:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="786085438" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="786085438" Received: from ccgoode-mobl.ger.corp.intel.com (HELO [10.213.236.139]) ([10.213.236.139]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2023 02:25:21 -0700 Message-ID: Date: Mon, 10 Jul 2023 10:25:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Rodrigo Vivi References: <20230707124644.3965281-1-tvrtko.ursulin@linux.intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH] drm/i915: Remove dead code from gen8_pte_encode X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel-gfx@lists.freedesktop.org, Matt Roper , dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 07/07/2023 15:17, Rodrigo Vivi wrote: > On Fri, Jul 07, 2023 at 01:46:44PM +0100, Tvrtko Ursulin wrote: >> From: Tvrtko Ursulin >> >> Commit 9275277d5324 ("drm/i915: use pat_index instead of cache_level") >> added a dedicated gen12_pte_encode but forgot to remove the Gen12 specific >> bit from gen8_pte_encode. >> >> Signed-off-by: Tvrtko Ursulin >> Fixes: 9275277d5324 ("drm/i915: use pat_index instead of cache_level") >> Cc: Fei Yang >> Cc: Andi Shyti >> Cc: Matt Roper > > Reviewed-by: Rodrigo Vivi Pushed, thanks for the reviews! Regards, Tvrtko > >> --- >> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c >> index f948d33e5ec5..c8568e5d1147 100644 >> --- a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c >> +++ b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c >> @@ -37,9 +37,6 @@ static u64 gen8_pte_encode(dma_addr_t addr, >> if (unlikely(flags & PTE_READ_ONLY)) >> pte &= ~GEN8_PAGE_RW; >> >> - if (flags & PTE_LM) >> - pte |= GEN12_PPGTT_PTE_LM; >> - >> /* >> * For pre-gen12 platforms pat_index is the same as enum >> * i915_cache_level, so the switch-case here is still valid. >> -- >> 2.39.2 >>