From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAFD7CD3445 for ; Fri, 8 May 2026 15:19:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 846AF10E289; Fri, 8 May 2026 15:19:58 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Kynp5Dvh"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id D619010E289; Fri, 8 May 2026 15:19:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778253597; x=1809789597; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=vTxrgSpju3iOhSdTw2826ToT/f1xH3q/gg0kBpsSTcY=; b=Kynp5Dvhc8lpiYWgRmg71tAFkfKg5Nkoy8pd1UtR+Po6YpEMTy0PBlx9 UAf+NKubQqUo3xpgOmHLoJmUZK1HCrU57JcFVaJEXqSMRBhAAGke6MHiT lbyitkLGWN5OykwXQCDpsh8acC3NEJpF91dPoZ6x3i+v36ckskDHmQl30 xnKXLn9VxpqBaKfCGeSYdbMyJOFis5eQu6hNqZTLcMD9juVxzd/Xmj01U lz5+meZ7nskif8IpBHuUkaZsjOvcKpt+VmmNAOfgBM0KfYRAt+SkeEid5 t55MUI9WkCGyvJWZUfUq32JPV8HEPBmRo3GeOLr7IuXjkXLdzy9mE8fZ+ Q==; X-CSE-ConnectionGUID: +WHfd3HmQf69/J2HEe433w== X-CSE-MsgGUID: aWaiapquSRehV8nsqfPd7Q== X-IronPort-AV: E=McAfee;i="6800,10657,11780"; a="83094456" X-IronPort-AV: E=Sophos;i="6.23,223,1770624000"; d="scan'208";a="83094456" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2026 08:19:56 -0700 X-CSE-ConnectionGUID: ccr4xiwFTkCjNkPotxacBQ== X-CSE-MsgGUID: /GFyJKf/SsKWbfROvohNVA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,223,1770624000"; d="scan'208";a="241753487" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.244.40]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2026 08:19:54 -0700 From: Jani Nikula To: imre.deak@intel.com Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH 009/108] drm/i915/dp_link_training: Use link_training as base pointer in debugfs In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260428125233.1664668-1-imre.deak@intel.com> <20260428125233.1664668-10-imre.deak@intel.com> <5585535a68e00ea1639ae4ec386929a0836fef35@intel.com> Date: Fri, 08 May 2026 18:19:51 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 08 May 2026, Imre Deak wrote: > On Fri, May 08, 2026 at 05:13:54PM +0300, Jani Nikula wrote: >> On Tue, 28 Apr 2026, Imre Deak wrote: >> > Retrieve the link_training pointer from the connector and derive the DP >> > pointer from it in debugfs entries. >> > >> > This prepares for a follow-up change where values exposed via debugfs >> > entries will be retrieved from the link training state. >> > >> > Signed-off-by: Imre Deak >> > --- >> > .../drm/i915/display/intel_dp_link_training.c | 25 +++++++++++++++---- >> > 1 file changed, 20 insertions(+), 5 deletions(-) >> > >> > diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c >> > index c2f9af251b6a9..1762e507dd1ec 100644 >> > --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c >> > +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c >> > @@ -67,6 +67,11 @@ struct intel_dp_link_training { >> > struct intel_dp *dp; >> > }; >> > >> > +static struct intel_dp_link_training *connector_to_link_training(struct intel_connector *connector) >> > +{ >> > + return intel_attached_dp(connector)->link.training; >> > +} >> > + >> > static void intel_dp_reset_lttpr_common_caps(struct intel_dp *intel_dp) >> > { >> > memset(intel_dp->lttpr_common_caps, 0, sizeof(intel_dp->lttpr_common_caps)); >> > @@ -2307,7 +2312,9 @@ static int i915_dp_force_link_training_failure_show(void *data, u64 *val) >> > { >> > struct intel_connector *connector = to_intel_connector(data); >> > struct intel_display *display = to_intel_display(connector); >> > - struct intel_dp *intel_dp = intel_attached_dp(connector); >> > + struct intel_dp_link_training *link_training = >> > + connector_to_link_training(connector); >> >> Nitpick, this fits on one line. The newline is a worse distraction than >> going over 80 chars. Ditto below. > > There's also a guideline to keep the length of declarations decreasing, > which imo does make the declaration block more readable. This is ofc a > subjective thing, could be argued in both ways. We don't have the reverse christmas tree thing going on (though I do prefer struct pointers before integral types). But even if we did, it would be silly to achieve that using newlines. BR, Jani. > >> >> > + struct intel_dp *intel_dp = link_training->dp; >> > int err; >> > >> > err = drm_modeset_lock_single_interruptible(&display->drm->mode_config.connection_mutex); >> > @@ -2327,7 +2334,9 @@ static int i915_dp_force_link_training_failure_write(void *data, u64 val) >> > { >> > struct intel_connector *connector = to_intel_connector(data); >> > struct intel_display *display = to_intel_display(connector); >> > - struct intel_dp *intel_dp = intel_attached_dp(connector); >> > + struct intel_dp_link_training *link_training = >> > + connector_to_link_training(connector); >> > + struct intel_dp *intel_dp = link_training->dp; >> > int err; >> > >> > if (val > 2) >> > @@ -2353,7 +2362,9 @@ static int i915_dp_force_link_retrain_show(void *data, u64 *val) >> > { >> > struct intel_connector *connector = to_intel_connector(data); >> > struct intel_display *display = to_intel_display(connector); >> > - struct intel_dp *intel_dp = intel_attached_dp(connector); >> > + struct intel_dp_link_training *link_training = >> > + connector_to_link_training(connector); >> > + struct intel_dp *intel_dp = link_training->dp; >> > int err; >> > >> > err = drm_modeset_lock_single_interruptible(&display->drm->mode_config.connection_mutex); >> > @@ -2373,7 +2384,9 @@ static int i915_dp_force_link_retrain_write(void *data, u64 val) >> > { >> > struct intel_connector *connector = to_intel_connector(data); >> > struct intel_display *display = to_intel_display(connector); >> > - struct intel_dp *intel_dp = intel_attached_dp(connector); >> > + struct intel_dp_link_training *link_training = >> > + connector_to_link_training(connector); >> > + struct intel_dp *intel_dp = link_training->dp; >> > int err; >> > >> > err = drm_modeset_lock_single_interruptible(&display->drm->mode_config.connection_mutex); >> > @@ -2398,7 +2411,9 @@ static int i915_dp_link_retrain_disabled_show(struct seq_file *m, void *data) >> > { >> > struct intel_connector *connector = to_intel_connector(m->private); >> > struct intel_display *display = to_intel_display(connector); >> > - struct intel_dp *intel_dp = intel_attached_dp(connector); >> > + struct intel_dp_link_training *link_training = >> > + connector_to_link_training(connector); >> > + struct intel_dp *intel_dp = link_training->dp; >> > int err; >> > >> > err = drm_modeset_lock_single_interruptible(&display->drm->mode_config.connection_mutex); >> >> -- >> Jani Nikula, Intel -- Jani Nikula, Intel