From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Souza, Jose" Subject: Re: [PATCH 1/2] drm/i915: Sort ICL PCI IDs Date: Fri, 8 Mar 2019 21:41:29 +0000 Message-ID: References: <20190307205656.12104-1-jose.souza@intel.com> <20190308211751.GG22115@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1200982911==" Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 914656E3F7 for ; Fri, 8 Mar 2019 21:41:31 +0000 (UTC) In-Reply-To: <20190308211751.GG22115@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Vivi, Rodrigo" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org --===============1200982911== Content-Language: en-US Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-UBDT/uRxFTkcGUjYUpe0" --=-UBDT/uRxFTkcGUjYUpe0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2019-03-08 at 13:17 -0800, Rodrigo Vivi wrote: > On Thu, Mar 07, 2019 at 12:56:55PM -0800, Jos=C3=A9 Roberto de Souza > wrote: > > Lets keep it sorted to make easy to spot missing PCI IDs. >=20 > Hmm... In my opinion leaving it as the identical order > of the spec is the way to make it easier to spot if we missed > something... >=20 > Otherwise when reviewing I have to stop and sort one or another. Oh it is following the order of the second table, okay makes sense keep this way. >=20 > > Cc: Rodrigo Vivi > > Signed-off-by: Jos=C3=A9 Roberto de Souza > > --- > > include/drm/i915_pciids.h | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > >=20 > > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h > > index d2fad7b0fcf6..be735811591d 100644 > > --- a/include/drm/i915_pciids.h > > +++ b/include/drm/i915_pciids.h > > @@ -459,16 +459,16 @@ > > #define INTEL_ICL_11_IDS(info) \ > > INTEL_VGA_DEVICE(0x8A50, info), \ > > INTEL_VGA_DEVICE(0x8A51, info), \ > > - INTEL_VGA_DEVICE(0x8A5C, info), \ > > - INTEL_VGA_DEVICE(0x8A5D, info), \ > > - INTEL_VGA_DEVICE(0x8A59, info), \ > > - INTEL_VGA_DEVICE(0x8A58, info), \ > > INTEL_VGA_DEVICE(0x8A52, info), \ > > + INTEL_VGA_DEVICE(0x8A56, info), \ > > + INTEL_VGA_DEVICE(0x8A57, info), \ > > + INTEL_VGA_DEVICE(0x8A58, info), \ > > + INTEL_VGA_DEVICE(0x8A59, info), \ > > INTEL_VGA_DEVICE(0x8A5A, info), \ > > INTEL_VGA_DEVICE(0x8A5B, info), \ > > - INTEL_VGA_DEVICE(0x8A57, info), \ > > - INTEL_VGA_DEVICE(0x8A56, info), \ > > - INTEL_VGA_DEVICE(0x8A71, info), \ > > - INTEL_VGA_DEVICE(0x8A70, info) > > + INTEL_VGA_DEVICE(0x8A5C, info), \ > > + INTEL_VGA_DEVICE(0x8A5D, info), \ > > + INTEL_VGA_DEVICE(0x8A70, info), \ > > + INTEL_VGA_DEVICE(0x8A71, info) > > =20 > > #endif /* _I915_PCIIDS_H */ > > --=20 > > 2.21.0 > >=20 --=-UBDT/uRxFTkcGUjYUpe0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEVNG051EijGa0MiaQVenbO/mOWkkFAlyC4YcACgkQVenbO/mO Wkli+wf9GCNPGjFEvTeqOmh4hO5I6/q6u0AgTB3Oibjvn12znuJhfLuopArx/3QX /HQr5P5WKtoCXnxmsksz4UjjBa67vP5AMwFpLoQpIvmDQkRzOq6k8KNyOxxLV2mq 4227sBaereQFt/bMYtJYSfXyTztX4KaQed65fyDD1kOC5zA4UaqC5s/S+xwh4OdD lxMocuU2qjhC1KeenlvtRX4gRVuAoOeZl+gXoiqB2CA0y3H+mgABB4+DcIYhyV4C 0HBWhaYHXEzbg6TD9b6nLEZai9+lWnmzZ54EwYdhw6UfQpuN3TBi1LXY5K2mRsLj lWtsA/Xdo61w6EQ7MOzb+BCxO4BVBQ== =3Oof -----END PGP SIGNATURE----- --=-UBDT/uRxFTkcGUjYUpe0-- --===============1200982911== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 --===============1200982911==--