From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v3 1/2] drm/i915: Move engine->submit_request selection to a vfunc Date: Tue, 14 Mar 2017 16:31:58 +0000 Message-ID: References: <20170314093441.7397-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0A7DB6E790 for ; Tue, 14 Mar 2017 16:32:36 +0000 (UTC) In-Reply-To: <20170314093441.7397-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Mika Kuoppala List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE0LzAzLzIwMTcgMDk6MzQsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJdCB0dXJucyBvdXQg dGhhdCB3ZSBtYXkgd2FudCB0byByZXN0b3JlIHRoZSBvcmlnaW5hbAo+IGVuZ2luZS0+c3VibWl0 X3JlcXVlc3QgKGFuZCBlbmdpbmUtPnNjaGVkdWxlKSBjYWxsYmFja3MgZnJvbSBtb3JlIHRoYW4K PiBqdXN0IHRoZSBndWMgPC0+IGV4ZWNsaXN0cyB0cmFuc2l0aW9uLiBNb3ZlIHRoaXMgdG8gYSB2 ZnVuYyBzbyB3ZSBjYW4KPiBoYXZlIGEgY29tbW9uIGludGVyZmFjZS4KPgo+IFNpZ25lZC1vZmYt Ynk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBUdnJ0a28g VXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IENjOiBNaWthIEt1b3BwYWxhIDxt aWthLmt1b3BwYWxhQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9ndWNfc3VibWlzc2lvbi5jIHwgIDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZW5naW5lX2NzLmMgICAgIHwgMTAgKysrKysrKysrKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9scmMuYyAgICAgICAgICAgfCAxNSArKysrKy0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfbHJjLmggICAgICAgICAgIHwgIDEgLQo+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMgICAgfCAxNSArKysrKysrKysrKysrLS0KPiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oICAgIHwgIDQgKysrKwo+ICA2IGZpbGVz IGNoYW5nZWQsIDMzIGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+IGluZGV4IGI0ZDI0Y2Q3NjM5YS4u MTE5YjVjMDczODMzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3Vj X3N1Ym1pc3Npb24uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1p c3Npb24uYwo+IEBAIC0xMDUxLDcgKzEwNTEsNyBAQCB2b2lkIGk5MTVfZ3VjX3N1Ym1pc3Npb25f ZGlzYWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAkJcmV0dXJuOwo+ Cj4gIAkvKiBSZXZlcnQgYmFjayB0byBtYW51YWwgRUxTUCBzdWJtaXNzaW9uICovCj4gLQlpbnRl bF9leGVjbGlzdHNfZW5hYmxlX3N1Ym1pc3Npb24oZGV2X3ByaXYpOwo+ICsJaW50ZWxfZW5naW5l c19lbmFibGVfc3VibWlzc2lvbihkZXZfcHJpdik7CgppbnRlbF9lbmdpbmVzX2RlZmF1bHRfc3Vi bWlzc2lvbiBjYW1lIHRvIG15IG1pbmQgYnV0IHRoYXQgd2lsbCBhbHNvIGJlIAptaXNsZWFkaW5n IG9uY2UgdGhlIGd1YyBzd2l0Y2ggaXMgdG9nZ2xlZC4gQnV0IEkgdGhpbmsgbGVzcyBtaXNsZWFk aW5nIAp0aGFuIGVuYWJsZV9zdWJtaXNzaW9uLiBBbmQgdmZ1bmMgbmFtZSBtYXliZSBhcyBhc3Np Z25fZGVmYXVsdF9zdWJtaXNzaW9uPwoKPiAgfQo+Cj4gIHZvaWQgaTkxNV9ndWNfc3VibWlzc2lv bl9maW5pKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9lbmdpbmVfY3MuYwo+IGluZGV4IDczZmU3MTg1MTZhNS4uNTY2M2ViYWI4NTFm IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPiBAQCAtMTkxLDYg KzE5MSw3IEBAIGludCBpbnRlbF9lbmdpbmVzX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2KQo+ICAJCQlnb3RvIGNsZWFudXA7Cj4gIAkJfQo+Cj4gKwkJZW5naW5lLT5lbmFi bGVfc3VibWlzc2lvbihlbmdpbmUpOwoKQ291bGQgYmUgbW92ZWQgdG8gaW50ZWxfZW5naW5lc19z ZXR1cF9jb21tb24gaWYgdGhlIGxvZ2ljYWxfcmluZ19zZXR1cCAKd2FzIHJlLWFycmFuZ2VkIGEg Yml0IHNvIHRoYXQgdGhlIGRlZmF1bHRfdmZ1bmNzIGFyZSBhc3NpZ25lZCBiZWZvcmUgaXQuIApM ZWdhY3kgbG9va3MgbGlrZSBpdCB3b3VsZCBiZSBhbHJpZ2h0IHdpdGggdGhhdCBhcHByb2FjaCBh bHJlYWR5LgoKTXkgdGhpbmtpbmcgaGVyZSBpcyBub3QgdG8gZXhwb3NlIHRoaXMgdmZ1bmMgc28g cHJvbWluZW50bHkgaW4gdGhlIGNvZGUgCnNpbmNlIGl0IGlzIGEgYml0IG9mIGEgbG93IGxldmVs IGludGVybmFsIGltcGxlbWVudGF0aW9uIHRoaW5nLgoKVGhvdWdodHM/CgpSZWdhcmRzLAoKVHZy dGtvCgoKPiAgCQltYXNrIHw9IEVOR0lORV9NQVNLKGlkKTsKPiAgCX0KPgo+IEBAIC0xMTE1LDYg KzExMTYsMTUgQEAgYm9vbCBpbnRlbF9lbmdpbmVzX2FyZV9pZGxlKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdikKPiAgCXJldHVybiB0cnVlOwo+ICB9Cj4KPiArdm9pZCBpbnRlbF9l bmdpbmVzX2VuYWJsZV9zdWJtaXNzaW9uKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+ ICt7Cj4gKwlzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmU7Cj4gKwllbnVtIGludGVsX2Vu Z2luZV9pZCBpZDsKPiArCj4gKwlmb3JfZWFjaF9lbmdpbmUoZW5naW5lLCBpOTE1LCBpZCkKPiAr CQllbmdpbmUtPmVuYWJsZV9zdWJtaXNzaW9uKGVuZ2luZSk7Cj4gK30KPiArCj4gICNpZiBJU19F TkFCTEVEKENPTkZJR19EUk1fSTkxNV9TRUxGVEVTVCkKPiAgI2luY2x1ZGUgInNlbGZ0ZXN0cy9t b2NrX2VuZ2luZS5jIgo+ICAjZW5kaWYKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IGluZGV4 IDg5ZjM4ZTdkZWY5Zi4uZjc5ZGY3YTUxZTYwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2xyYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJj LmMKPiBAQCAtMTU2MCwxNSArMTU2MCwxMCBAQCB2b2lkIGludGVsX2xvZ2ljYWxfcmluZ19jbGVh bnVwKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgCWtmcmVlKGVuZ2luZSk7Cj4g IH0KPgo+IC12b2lkIGludGVsX2V4ZWNsaXN0c19lbmFibGVfc3VibWlzc2lvbihzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gK3N0YXRpYyB2b2lkIGxvZ2ljYWxfcmluZ19lbmFi bGVfc3VibWlzc2lvbihzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gIHsKPiAtCXN0 cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZTsKPiAtCWVudW0gaW50ZWxfZW5naW5lX2lkIGlk Owo+IC0KPiAtCWZvcl9lYWNoX2VuZ2luZShlbmdpbmUsIGRldl9wcml2LCBpZCkgewo+IC0JCWVu Z2luZS0+c3VibWl0X3JlcXVlc3QgPSBleGVjbGlzdHNfc3VibWl0X3JlcXVlc3Q7Cj4gLQkJZW5n aW5lLT5zY2hlZHVsZSA9IGV4ZWNsaXN0c19zY2hlZHVsZTsKPiAtCX0KPiArCWVuZ2luZS0+c3Vi bWl0X3JlcXVlc3QgPSBleGVjbGlzdHNfc3VibWl0X3JlcXVlc3Q7Cj4gKwllbmdpbmUtPnNjaGVk dWxlID0gZXhlY2xpc3RzX3NjaGVkdWxlOwo+ICB9Cj4KPiAgc3RhdGljIHZvaWQKPiBAQCAtMTU4 Niw4ICsxNTgxLDggQEAgbG9naWNhbF9yaW5nX2RlZmF1bHRfdmZ1bmNzKHN0cnVjdCBpbnRlbF9l bmdpbmVfY3MgKmVuZ2luZSkKPiAgCWVuZ2luZS0+ZW1pdF9mbHVzaCA9IGdlbjhfZW1pdF9mbHVz aDsKPiAgCWVuZ2luZS0+ZW1pdF9icmVhZGNydW1iID0gZ2VuOF9lbWl0X2JyZWFkY3J1bWI7Cj4g IAllbmdpbmUtPmVtaXRfYnJlYWRjcnVtYl9zeiA9IGdlbjhfZW1pdF9icmVhZGNydW1iX3N6Owo+ IC0JZW5naW5lLT5zdWJtaXRfcmVxdWVzdCA9IGV4ZWNsaXN0c19zdWJtaXRfcmVxdWVzdDsKPiAt CWVuZ2luZS0+c2NoZWR1bGUgPSBleGVjbGlzdHNfc2NoZWR1bGU7Cj4gKwo+ICsJZW5naW5lLT5l bmFibGVfc3VibWlzc2lvbiA9IGxvZ2ljYWxfcmluZ19lbmFibGVfc3VibWlzc2lvbjsKPgo+ICAJ ZW5naW5lLT5pcnFfZW5hYmxlID0gZ2VuOF9sb2dpY2FsX3JpbmdfZW5hYmxlX2lycTsKPiAgCWVu Z2luZS0+aXJxX2Rpc2FibGUgPSBnZW44X2xvZ2ljYWxfcmluZ19kaXNhYmxlX2lycTsKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmggYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9scmMuaAo+IGluZGV4IDVmYzA3NzYxY2FmZi4uZTgwMTVlN2JmNGU5IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5oCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmgKPiBAQCAtODcsNiArODcsNSBAQCB1aW50NjRf dCBpbnRlbF9scl9jb250ZXh0X2Rlc2NyaXB0b3Ioc3RydWN0IGk5MTVfZ2VtX2NvbnRleHQgKmN0 eCwKPiAgLyogRXhlY2xpc3RzICovCj4gIGludCBpbnRlbF9zYW5pdGl6ZV9lbmFibGVfZXhlY2xp c3RzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkJCSAgICBpbnQgZW5h YmxlX2V4ZWNsaXN0cyk7Cj4gLXZvaWQgaW50ZWxfZXhlY2xpc3RzX2VuYWJsZV9zdWJtaXNzaW9u KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7Cj4KPiAgI2VuZGlmIC8qIF9JTlRF TF9MUkNfSF8gKi8KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmlu Z2J1ZmZlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4gaW5k ZXggNGE4NjRmOGM5Mzg3Li41YjE0MWY2NjM5YjYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfcmluZ2J1ZmZlci5jCj4gQEAgLTIwNTAsNiArMjA1MCwxNiBAQCBzdGF0aWMgdm9pZCBp bnRlbF9yaW5nX2luaXRfaXJxKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAg CX0KPiAgfQo+Cj4gK3N0YXRpYyB2b2lkIGk5eHhfZW5hYmxlX3N1Ym1pc3Npb24oc3RydWN0IGlu dGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICt7Cj4gKwllbmdpbmUtPnN1Ym1pdF9yZXF1ZXN0ID0g aTl4eF9zdWJtaXRfcmVxdWVzdDsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgZ2VuNl9ic2RfZW5h YmxlX3N1Ym1pc3Npb24oc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICt7Cj4gKwll bmdpbmUtPnN1Ym1pdF9yZXF1ZXN0ID0gZ2VuNl9ic2Rfc3VibWl0X3JlcXVlc3Q7Cj4gK30KPiAr Cj4gIHN0YXRpYyB2b2lkIGludGVsX3JpbmdfZGVmYXVsdF92ZnVuY3Moc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJCQkJICAgICAgc3RydWN0IGludGVsX2VuZ2luZV9jcyAq ZW5naW5lKQo+ICB7Cj4gQEAgLTIwODAsNyArMjA5MCw4IEBAIHN0YXRpYyB2b2lkIGludGVsX3Jp bmdfZGVmYXVsdF92ZnVuY3Moc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJ CQkJZW5naW5lLT5lbWl0X2JyZWFkY3J1bWJfc3orKzsKPiAgCQl9Cj4gIAl9Cj4gLQllbmdpbmUt PnN1Ym1pdF9yZXF1ZXN0ID0gaTl4eF9zdWJtaXRfcmVxdWVzdDsKPiArCj4gKwllbmdpbmUtPmVu YWJsZV9zdWJtaXNzaW9uID0gaTl4eF9lbmFibGVfc3VibWlzc2lvbjsKPgo+ICAJaWYgKElOVEVM X0dFTihkZXZfcHJpdikgPj0gOCkKPiAgCQllbmdpbmUtPmVtaXRfYmJfc3RhcnQgPSBnZW44X2Vt aXRfYmJfc3RhcnQ7Cj4gQEAgLTIxNjUsNyArMjE3Niw3IEBAIGludCBpbnRlbF9pbml0X2JzZF9y aW5nX2J1ZmZlcihzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gIAlpZiAoSU5URUxf R0VOKGRldl9wcml2KSA+PSA2KSB7Cj4gIAkJLyogZ2VuNiBic2QgbmVlZHMgYSBzcGVjaWFsIHdh IGZvciB0YWlsIHVwZGF0ZXMgKi8KPiAgCQlpZiAoSVNfR0VONihkZXZfcHJpdikpCj4gLQkJCWVu Z2luZS0+c3VibWl0X3JlcXVlc3QgPSBnZW42X2JzZF9zdWJtaXRfcmVxdWVzdDsKPiArCQkJZW5n aW5lLT5lbmFibGVfc3VibWlzc2lvbiA9IGdlbjZfYnNkX2VuYWJsZV9zdWJtaXNzaW9uOwo+ICAJ CWVuZ2luZS0+ZW1pdF9mbHVzaCA9IGdlbjZfYnNkX3JpbmdfZmx1c2g7Cj4gIAkJaWYgKElOVEVM X0dFTihkZXZfcHJpdikgPCA4KQo+ICAJCQllbmdpbmUtPmlycV9lbmFibGVfbWFzayA9IEdUX0JT RF9VU0VSX0lOVEVSUlVQVDsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfcmluZ2J1ZmZlci5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5o Cj4gaW5kZXggMGVmNDkxZGY1YjRlLi4zMGQ5ODIwZDk3OGMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gQEAgLTI3Myw2ICsyNzMsOCBAQCBzdHJ1Y3QgaW50 ZWxfZW5naW5lX2NzIHsKPiAgCXZvaWQJCSgqcmVzZXRfaHcpKHN0cnVjdCBpbnRlbF9lbmdpbmVf Y3MgKmVuZ2luZSwKPiAgCQkJCSAgICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSk7 Cj4KPiArCXZvaWQJCSgqZW5hYmxlX3N1Ym1pc3Npb24pKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3Mg KmVuZ2luZSk7Cj4gKwo+ICAJaW50CQkoKmNvbnRleHRfcGluKShzdHJ1Y3QgaW50ZWxfZW5naW5l X2NzICplbmdpbmUsCj4gIAkJCQkgICAgICAgc3RydWN0IGk5MTVfZ2VtX2NvbnRleHQgKmN0eCk7 Cj4gIAl2b2lkCQkoKmNvbnRleHRfdW5waW4pKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2lu ZSwKPiBAQCAtNjY5LDQgKzY3MSw2IEBAIHN0YXRpYyBpbmxpbmUgdTMyICpnZW44X2VtaXRfcGlw ZV9jb250cm9sKHUzMiAqYmF0Y2gsIHUzMiBmbGFncywgdTMyIG9mZnNldCkKPiAgYm9vbCBpbnRl bF9lbmdpbmVfaXNfaWRsZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpOwo+ICBib29s IGludGVsX2VuZ2luZXNfYXJlX2lkbGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 KTsKPgo+ICt2b2lkIGludGVsX2VuZ2luZXNfZW5hYmxlX3N1Ym1pc3Npb24oc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmk5MTUpOwo+ICsKPiAgI2VuZGlmIC8qIF9JTlRFTF9SSU5HQlVGRkVSX0hf ICovCj4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==