Re: [PATCH v2 5/6] drm/i915/guc: Move Guc early init into own function

[Sagar Arun Kamble <sagar.a.kamble@intel.com>]

On 10/2/2017 7:31 PM, Michal Wajdeczko wrote:
> We don't want to make aggregate uc functions to be too detailed.
> This will also make future patch easier.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com>
Reviewed-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
> ---
>   drivers/gpu/drm/i915/intel_uc.c | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
> index d921509..616e0f1 100644
> --- a/drivers/gpu/drm/i915/intel_uc.c
> +++ b/drivers/gpu/drm/i915/intel_uc.c
> @@ -88,10 +88,8 @@ static void gen8_guc_raise_irq(struct intel_guc *guc)
>   	I915_WRITE(GUC_SEND_INTERRUPT, GUC_SEND_TRIGGER);
>   }
>   
> -void intel_uc_init_early(struct drm_i915_private *dev_priv)
> +static void guc_init_early(struct intel_guc *guc)
>   {
> -	struct intel_guc *guc = &dev_priv->guc;
> -
>   	intel_guc_ct_init_early(&guc->ct);
>   
>   	mutex_init(&guc->send_mutex);
> @@ -99,6 +97,11 @@ void intel_uc_init_early(struct drm_i915_private *dev_priv)
>   	guc->notify = gen8_guc_raise_irq;
>   }
>   
> +void intel_uc_init_early(struct drm_i915_private *dev_priv)
> +{
> +	guc_init_early(&dev_priv->guc);
> +}
> +
>   void intel_uc_init_fw(struct drm_i915_private *dev_priv)
>   {
>   	i915_fetch_uc_fw(dev_priv, &dev_priv->huc.fw);

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx