From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: Manasi Navare <manasi.d.navare@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/display/dp: Compute the correct slice count for VDSC on DP
Date: Mon, 7 Dec 2020 14:31:57 +0530 [thread overview]
Message-ID: <d6bc504f-d23c-143f-6d5e-e8117d56d2e6@intel.com> (raw)
In-Reply-To: <20201204205804.25225-1-manasi.d.navare@intel.com>
On 12/5/2020 2:28 AM, Manasi Navare wrote:
> This patch fixes the slice count computation algorithm
> for calculating the slice count based on Peak pixel rate
> and the max slice width allowed on the DSC engines.
> We need to ensure slice count > min slice count req
> as per DP spec based on peak pixel rate and that it is
> greater than min slice count based on the max slice width
> advertised by DPCD. So use max of these two.
> In the prev patch we were using min of these 2 causing it
> to violate the max slice width limitation causing a blank
> screen on 8K@60.
>
> Fixes: d9218c8f6cf4 ("drm/i915/dp: Add helpers for Compressed BPP and Slice Count for DSC")
> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 2d4d5e95af84..cb5e42c3ecd5 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -615,7 +615,7 @@ static u8 intel_dp_dsc_get_slice_count(struct intel_dp *intel_dp,
> return 0;
> }
> /* Also take into account max slice width */
> - min_slice_count = min_t(u8, min_slice_count,
> + min_slice_count = max_t(u8, min_slice_count,
> DIV_ROUND_UP(mode_hdisplay,
> max_slice_width));
Change looks good to me.
'min_slice_count' is essentially the least no. of slices that would be
sufficient. So max of the two values would be correct.
Also tested with this change on an 8k panel, we are able get 8 DSC
slices with this change, which is correct for 8k@60 resolution.
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2020-12-07 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 20:58 [Intel-gfx] [PATCH] drm/i915/display/dp: Compute the correct slice count for VDSC on DP Manasi Navare
2020-12-04 22:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-12-05 0:22 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-12-07 9:01 ` Nautiyal, Ankit K [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6bc504f-d23c-143f-6d5e-e8117d56d2e6@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=manasi.d.navare@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).