From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD339C98306 for ; Tue, 22 Sep 2026 12:25:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 20EF610EC9B; Tue, 22 Sep 2026 12:25:09 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=suse.com header.i=@suse.com header.b="g1EMx2NH"; dkim-atps=neutral Received: from mail-wm2-f12.google.com (mail-wm2-f12.google.com [74.125.225.140]) by gabe.freedesktop.org (Postfix) with ESMTPS id 97BDF10E1BE for ; Tue, 22 Sep 2026 12:25:07 +0000 (UTC) Received: by mail-wm2-f12.google.com with SMTP id 5b1f17b1804b1-49b912e4b11so22502555e9.3 for ; Tue, 22 Sep 2026 05:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1790079906; x=1790684706; darn=lists.freedesktop.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Z0UH5f4Xwx0eHqEEdAgzMEXfye5CzpFBUkt22qJELao=; b=g1EMx2NHfVWs8pDd4hQYQo3szxAMrQbN1rEc7DKVei04dq9WOPnxdjerKAJGOucTS0 EY/yxaA5qX6eqfEs0AA3lMxK6Er8l8uZg/tCG4tsUDjwiUjHlLUF2dZ/Pq8Au3MTOuDZ 1iKOGviAJfw5cKWurnk6YWQbtjT7KUYkrmftRqudgGAcpXOq2L2+Z8f/rJh+UZgdz/LX SWCmv5krwSo6ZLteVSscBULRHV1Zj0SJit2Z+lHgxcgELVaArhCm0i+pLdvRiA3ei9hX RICn8oPekC+or/cLa9ZyjCrh5bG6nFMspfkVil2B4JgujqXF7+EaxRsJDDV5pWH7yjBq SQJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790079906; x=1790684706; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Z0UH5f4Xwx0eHqEEdAgzMEXfye5CzpFBUkt22qJELao=; b=ZPxaKO1l1KryVDq9yCYOQ1brbFUTj1m5tFM2hBwlN8cpS4fiqe4UdDPzNy9EO5sYLp WErHsCX8FAIReUxUSfEyAS3ztUDNWALy66ZAActGlvfBejjRftn+ZlAPKbvbTtGjR0ge QZPZWEEaMi2rAKyymumIcvfSpijnSRTbMBc7PE7M1tW3YNHgJKCaNp4DiMuTGDUS6Put rz5vw7ULOZYhXgeJmQC1ENyxg3CSewVAsJEsFLU5Zki4izvNxr6+0t+MJnLxl8hvlYtv LFBPotsLhpy8NsxQ6L4yPX4rSqZ6/AQfiTFEbR7rVenxqvlubuD2ILHxNP8RpMXAMeT4 BPKg== X-Forwarded-Encrypted: i=1; AKwUvByXbGC9Kz37H1HcdqGK28dIQINBfH1FlQF1qBq4OmRVS87SRutzdy9AIeTtwTYIrg/9tCnAoWvh13U=@lists.freedesktop.org X-Gm-Message-State: AFuF++lmxbhcHAmGevTtfQy8GPDZXNy4fZ2XOzxmRKY6041j26daT7OP olbQ+f12tKyD2q9zX34llToeF4NcyDEP30BMzQz2wHfibSq3QaNMn96QkSQrMfYEcHU= X-Gm-Gg: AYBFou17tee+OqPLBhUrEIcoyNF/pR/gMOk+IEcPZGCl9nAUP3Ig0kJJU3ogebg+m5G qKEf0a9cQKdPGO94C5gv+iN3bCYfd0HrAuN5UQxCuXqoVKQHFo2aIXaE2QzLLWU5jjR/Qk1JPm4 xPXlLVfNYK4NZYKzQ3vPagp27gYKPkSNDXhwB5A1D8fyZ+tRjtcMLRsfRGKMjeC6+dBCWbFRiRf wo5l8U2z4bFRFKjbr/UPrHWFq8f2VvzcenBD1vA6EXGrE5WlLImImVAgWeDMAkeLCDU1zdzzMFJ EHMGqLQ4dWj5jAkB/YAYi1O2b/U41HqmC364fWm2glJR3iHr/9WzOy74jME8/zZvL2cVAZBUON9 28vzLkGui/Sqjvnr3ik1+LNB4TXJx+3vOx3cAW3ppKyS11+7efupAYHXvJg9yK0Tw2vUSY+Yq5U 2louBOud5/JXmReVExf3YVSkKpSb4OdjJ+JPnGPev0GYu+K0mIuRR7bab441gFRJfzV4ysnh+S+ 2M2z6pjzgL3j2QW+31ZiLInnuJpkXzmqtvX6DrnnpQoQPUiOwi7b1vbBfQJcrs7KVQBdruxubEa 4adKuD2GOJ/rONmFi8ukNJ9EplyG/q3i+yxeqxK8 X-Received: by 2002:a05:600c:1f95:b0:49e:7862:c09e with SMTP id 5b1f17b1804b1-49fc57238b8mr181860835e9.14.1790079905892; Tue, 22 Sep 2026 05:25:05 -0700 (PDT) Received: from ?IPV6:2a00:1028:838d:271e:8e3b:4aff:fe4c:a100? (dynamic-2a00-1028-838d-271e-8e3b-4aff-fe4c-a100.ipv6.o2.cz. [2a00:1028:838d:271e:8e3b:4aff:fe4c:a100]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fdad40b4dsm48644925e9.10.2026.09.22.05.25.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Sep 2026 05:25:05 -0700 (PDT) Message-ID: Date: Tue, 22 Sep 2026 14:25:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/6] Remove the error-injection.h include from linux/module.h To: Jens Axboe , Jakub Kicinski , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Matthew Brost , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= Cc: Simon Horman , David Airlie , Simona Vetter , Francois Dugast , Luis Chamberlain , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , linux-block@vger.kernel.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260911-module-include-error_injection-v1-0-5da895d8c84d@suse.com> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20260911-module-include-error_injection-v1-0-5da895d8c84d@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 9/11/26 5:04 PM, Petr Pavlu wrote: > linux/module.h appears in roughly 15k #include directives across the > kernel. This makes it a "hot" header, so it should avoid pulling in > unnecessary definitions. > > The header currently includes linux/error-injection.h to obtain the > definition of `struct error_injection_entry`. However, this is unnecessary > because the type is only referenced in the file as a pointer, for which an > incomplete type is sufficient. > > Add explicit includes of linux/error-injection.h to files that use the > ALLOW_ERROR_INJECTION() macro and currently rely on it being provided > indirectly via linux/module.h. Then remove the linux/error-injection.h > include from linux/module.h. > > The first five patches can go through their respective trees if preferred. > The final patch depends on the preceding cleanups. Thanks for the Reviewed-by and Acked-by tags so far. They cover the majority of the changes, so I plan to pick up this series on modules-next at the end of the week. Acked-by tags from the relevant maintainers on the remaining patches are still appreciated. -- Thanks, Petr