From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46357EB64D9 for ; Mon, 19 Jun 2023 14:08:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C37DC10E207; Mon, 19 Jun 2023 14:08:03 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5252D10E207 for ; Mon, 19 Jun 2023 14:08:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687183682; x=1718719682; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Z7JmNa7DLBrcbACOjFLzyo65LFtQS2huhGOQYnvrURI=; b=JMvqhb2CkbgZIiwn7H/kwgeKKCdQWrFJvweK1HVUYSWqYVUqbLo5gSEp PfE1lgXwcLd9RORwvynaxBl76oXMUizQF7Fdyax0VHuBwrelwCGhOus40 rNAW/EZAYamIHMaEaOzQWdEeGmA6s4gsq4WDHLBUET/wU7w7nezJga3b4 hOvC3Xa7lOnBKVX9izV2B4nkrbsyVPN0NLb8R9lszQNAI7IW3b3u/gwFE EI/1++p25QApYn64QjXNhJnmHOjiGNePZCCik631IW7ePKnqZ65aRwhhy 6Sw5/RZ+ezGJ31FNjB845HFnt0VpUfiddwlM7NItLv72kYBzgdeoeq2hF Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="339979213" X-IronPort-AV: E=Sophos;i="6.00,254,1681196400"; d="scan'208";a="339979213" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2023 07:06:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="826590563" X-IronPort-AV: E=Sophos;i="6.00,254,1681196400"; d="scan'208";a="826590563" Received: from nirmoyda-mobl.ger.corp.intel.com (HELO [10.249.45.73]) ([10.249.45.73]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2023 07:06:24 -0700 Message-ID: Date: Mon, 19 Jun 2023 16:06:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 To: Andi Shyti , Dan Carpenter References: Content-Language: en-US From: Nirmoy Das In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix a NULL vs IS_ERR() bug X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, Matthew Auld , Daniel Vetter , Rodrigo Vivi , Suren Baghdasaryan , Nirmoy Das Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Pushed to gt-next. Thanks, Nirmoy On 6/6/2023 11:22 AM, Andi Shyti wrote: > Hi Dan, > > On Tue, Jun 06, 2023 at 11:23:56AM +0300, Dan Carpenter wrote: >> The mmap_offset_attach() function returns error pointers, it doesn't >> return NULL. >> >> Fixes: eaee1c085863 ("drm/i915: Add a function to mmap framebuffer obj") >> Signed-off-by: Dan Carpenter > Thanks for this series of fixes! > > Reviewed-by: Andi Shyti > > Andi