From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 3/3] drm/i915: Move find_active_request() to the engine Date: Tue, 5 Mar 2019 18:13:34 +0000 Message-ID: References: <20190305180332.30900-1-chris@chris-wilson.co.uk> <20190305180332.30900-3-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 64A4389C61 for ; Tue, 5 Mar 2019 18:13:36 +0000 (UTC) In-Reply-To: <20190305180332.30900-3-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA1LzAzLzIwMTkgMTg6MDMsIENocmlzIFdpbHNvbiB3cm90ZToKPiBUbyBmaW5kIHRoZSBh Y3RpdmUgcmVxdWVzdCwgd2UgbmVlZCBvbmx5IHNlYXJjaCBhbG9uZyB0aGUgaW5kaXZpZHVhbAo+ IGVuZ2luZSBmb3IgdGhlIHJpZ2h0IHJlcXVlc3QuIFRoaXMgZG9lcyBub3QgcmVxdWlyZSB0b3Vj aGluZyBhbnkgZ2xvYmFsCj4gR0VNIHN0YXRlLCBzbyBtb3ZlIGl0IGludG8gdGhlIGVuZ2luZSBj b21wYXJ0bWVudC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlz LXdpbHNvbi5jby51az4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2Lmgg ICAgICAgICB8ICAzIC0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jICAgICAg ICAgfCA0NSAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9ncHVfZXJyb3IuYyAgIHwgIDIgKy0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2VuZ2luZV9jcy5jICB8IDQ3ICsrKysrKysrKysrKysrKysrKysrKysrKy0KPiAgIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaCB8ICAzICsrCj4gICA1IGZpbGVzIGNoYW5n ZWQsIDUwIGluc2VydGlvbnMoKyksIDUwIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kcnYuaAo+IGluZGV4IDA4ZWFkODU0YWMyZC4uZmYwMzk3NTAwNjlkIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2Rydi5oCj4gQEAgLTI5OTYsOSArMjk5Niw2IEBAIHZvaWQgaTkxNV9nZW1fdHJh Y2tfZmIoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9sZCwKPiAgIAo+ICAgaW50IF9fbXVz dF9jaGVjayBpOTE1X2dlbV9zZXRfZ2xvYmFsX3NlcW5vKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs IHUzMiBzZXFubyk7Cj4gICAKPiAtc3RydWN0IGk5MTVfcmVxdWVzdCAqCj4gLWk5MTVfZ2VtX2Zp bmRfYWN0aXZlX3JlcXVlc3Qoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKTsKPiAtCj4g ICBzdGF0aWMgaW5saW5lIGJvb2wgX19pOTE1X3dlZGdlZChzdHJ1Y3QgaTkxNV9ncHVfZXJyb3Ig KmVycm9yKQo+ICAgewo+ICAgCXJldHVybiB1bmxpa2VseSh0ZXN0X2JpdChJOTE1X1dFREdFRCwg JmVycm9yLT5mbGFncykpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IGluZGV4IDY5NDEzZjk5 ZWQwNC4uYzY3MzY5YmQxNDViIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gQEAgLTI4 MDMsNTEgKzI4MDMsNiBAQCBpOTE1X2dlbV9vYmplY3RfcHdyaXRlX2d0dChzdHJ1Y3QgZHJtX2k5 MTVfZ2VtX29iamVjdCAqb2JqLAo+ICAgCXJldHVybiAwOwo+ICAgfQo+ICAgCj4gLXN0YXRpYyBi b29sIG1hdGNoX3Jpbmcoc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEpCj4gLXsKPiAtCXN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHJxLT5pOTE1Owo+IC0JdTMyIHJpbmcgPSBJOTE1 X1JFQUQoUklOR19TVEFSVChycS0+ZW5naW5lLT5tbWlvX2Jhc2UpKTsKPiAtCj4gLQlyZXR1cm4g cmluZyA9PSBpOTE1X2dndHRfb2Zmc2V0KHJxLT5yaW5nLT52bWEpOwo+IC19Cj4gLQo+IC1zdHJ1 Y3QgaTkxNV9yZXF1ZXN0ICoKPiAtaTkxNV9nZW1fZmluZF9hY3RpdmVfcmVxdWVzdChzdHJ1Y3Qg aW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gLXsKPiAtCXN0cnVjdCBpOTE1X3JlcXVlc3QgKnJl cXVlc3QsICphY3RpdmUgPSBOVUxMOwo+IC0JdW5zaWduZWQgbG9uZyBmbGFnczsKPiAtCj4gLQkv Kgo+IC0JICogV2UgYXJlIGNhbGxlZCBieSB0aGUgZXJyb3IgY2FwdHVyZSwgcmVzZXQgYW5kIHRv IGR1bXAgZW5naW5lCj4gLQkgKiBzdGF0ZSBhdCByYW5kb20gcG9pbnRzIGluIHRpbWUuIEluIHBh cnRpY3VsYXIsIG5vdGUgdGhhdCBuZWl0aGVyIGlzCj4gLQkgKiBjcnVjaWFsbHkgb3JkZXJlZCB3 aXRoIGFuIGludGVycnVwdC4gQWZ0ZXIgYSBoYW5nLCB0aGUgR1BVIGlzIGRlYWQKPiAtCSAqIGFu ZCB3ZSBhc3N1bWUgdGhhdCBubyBtb3JlIHdyaXRlcyBjYW4gaGFwcGVuICh3ZSB3YWl0ZWQgbG9u ZyBlbm91Z2gKPiAtCSAqIGZvciBhbGwgd3JpdGVzIHRoYXQgd2VyZSBpbiB0cmFuc2FjdGlvbiB0 byBiZSBmbHVzaGVkKSAtIGFkZGluZyBhbgo+IC0JICogZXh0cmEgZGVsYXkgZm9yIGEgcmVjZW50 IGludGVycnVwdCBpcyBwb2ludGxlc3MuIEhlbmNlLCB3ZSBkbwo+IC0JICogbm90IG5lZWQgYW4g ZW5naW5lLT5pcnFfc2Vxbm9fYmFycmllcigpIGJlZm9yZSB0aGUgc2Vxbm8gcmVhZHMuCj4gLQkg KiBBdCBhbGwgb3RoZXIgdGltZXMsIHdlIG11c3QgYXNzdW1lIHRoZSBHUFUgaXMgc3RpbGwgcnVu bmluZywgYnV0Cj4gLQkgKiB3ZSBvbmx5IGNhcmUgYWJvdXQgdGhlIHNuYXBzaG90IG9mIHRoaXMg bW9tZW50Lgo+IC0JICovCj4gLQlzcGluX2xvY2tfaXJxc2F2ZSgmZW5naW5lLT50aW1lbGluZS5s b2NrLCBmbGFncyk7Cj4gLQlsaXN0X2Zvcl9lYWNoX2VudHJ5KHJlcXVlc3QsICZlbmdpbmUtPnRp bWVsaW5lLnJlcXVlc3RzLCBsaW5rKSB7Cj4gLQkJaWYgKGk5MTVfcmVxdWVzdF9jb21wbGV0ZWQo cmVxdWVzdCkpCj4gLQkJCWNvbnRpbnVlOwo+IC0KPiAtCQlpZiAoIWk5MTVfcmVxdWVzdF9zdGFy dGVkKHJlcXVlc3QpKQo+IC0JCQlicmVhazsKPiAtCj4gLQkJLyogTW9yZSB0aGFuIG9uZSBwcmVl bXB0aWJsZSByZXF1ZXN0IG1heSBtYXRjaCEgKi8KPiAtCQlpZiAoIW1hdGNoX3JpbmcocmVxdWVz dCkpCj4gLQkJCWJyZWFrOwo+IC0KPiAtCQlhY3RpdmUgPSByZXF1ZXN0Owo+IC0JCWJyZWFrOwo+ IC0JfQo+IC0Jc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmZW5naW5lLT50aW1lbGluZS5sb2NrLCBm bGFncyk7Cj4gLQo+IC0JcmV0dXJuIGFjdGl2ZTsKPiAtfQo+IC0KPiAgIHN0YXRpYyB2b2lkCj4g ICBpOTE1X2dlbV9yZXRpcmVfd29ya19oYW5kbGVyKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykK PiAgIHsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVfZXJyb3Iu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3B1X2Vycm9yLmMKPiBpbmRleCA1ZjFjZGJj OWViNWQuLjNkODAyMDg4ODYwNCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dwdV9lcnJvci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVfZXJy b3IuYwo+IEBAIC0xNDExLDcgKzE0MTEsNyBAQCBzdGF0aWMgdm9pZCBnZW1fcmVjb3JkX3Jpbmdz KHN0cnVjdCBpOTE1X2dwdV9zdGF0ZSAqZXJyb3IpCj4gICAJCWVycm9yX3JlY29yZF9lbmdpbmVf cmVnaXN0ZXJzKGVycm9yLCBlbmdpbmUsIGVlKTsKPiAgIAkJZXJyb3JfcmVjb3JkX2VuZ2luZV9l eGVjbGlzdHMoZW5naW5lLCBlZSk7Cj4gICAKPiAtCQlyZXF1ZXN0ID0gaTkxNV9nZW1fZmluZF9h Y3RpdmVfcmVxdWVzdChlbmdpbmUpOwo+ICsJCXJlcXVlc3QgPSBpbnRlbF9lbmdpbmVfZmluZF9h Y3RpdmVfcmVxdWVzdChlbmdpbmUpOwo+ICAgCQlpZiAocmVxdWVzdCkgewo+ICAgCQkJc3RydWN0 IGk5MTVfZ2VtX2NvbnRleHQgKmN0eCA9IHJlcXVlc3QtPmdlbV9jb250ZXh0Owo+ICAgCQkJc3Ry dWN0IGludGVsX3JpbmcgKnJpbmc7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2VuZ2luZV9jcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2Nz LmMKPiBpbmRleCA2MmEyYmJiYmNjNjQuLjU1NWE0NTkwZmEyMyAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jCj4gQEAgLTE1NDUsNyArMTU0NSw3IEBAIHZvaWQgaW50 ZWxfZW5naW5lX2R1bXAoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLAo+ICAgCWlmICgm cnEtPmxpbmsgIT0gJmVuZ2luZS0+dGltZWxpbmUucmVxdWVzdHMpCj4gICAJCXByaW50X3JlcXVl c3QobSwgcnEsICJcdFx0bGFzdCAgICIpOwo+ICAgCj4gLQlycSA9IGk5MTVfZ2VtX2ZpbmRfYWN0 aXZlX3JlcXVlc3QoZW5naW5lKTsKPiArCXJxID0gaW50ZWxfZW5naW5lX2ZpbmRfYWN0aXZlX3Jl cXVlc3QoZW5naW5lKTsKPiAgIAlpZiAocnEpIHsKPiAgIAkJcHJpbnRfcmVxdWVzdChtLCBycSwg Ilx0XHRhY3RpdmUgIik7Cj4gICAKPiBAQCAtMTcxMiw2ICsxNzEyLDUxIEBAIHZvaWQgaW50ZWxf ZGlzYWJsZV9lbmdpbmVfc3RhdHMoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAg CXdyaXRlX3NlcXVubG9ja19pcnFyZXN0b3JlKCZlbmdpbmUtPnN0YXRzLmxvY2ssIGZsYWdzKTsK PiAgIH0KPiAgIAo+ICtzdGF0aWMgYm9vbCBtYXRjaF9yaW5nKHN0cnVjdCBpOTE1X3JlcXVlc3Qg KnJxKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBycS0+aTkx NTsKPiArCXUzMiByaW5nID0gSTkxNV9SRUFEKFJJTkdfU1RBUlQocnEtPmVuZ2luZS0+bW1pb19i YXNlKSk7Cj4gKwo+ICsJcmV0dXJuIHJpbmcgPT0gaTkxNV9nZ3R0X29mZnNldChycS0+cmluZy0+ dm1hKTsKPiArfQo+ICsKPiArc3RydWN0IGk5MTVfcmVxdWVzdCAqCj4gK2ludGVsX2VuZ2luZV9m aW5kX2FjdGl2ZV9yZXF1ZXN0KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiArewo+ ICsJc3RydWN0IGk5MTVfcmVxdWVzdCAqcmVxdWVzdCwgKmFjdGl2ZSA9IE5VTEw7Cj4gKwl1bnNp Z25lZCBsb25nIGZsYWdzOwo+ICsKPiArCS8qCj4gKwkgKiBXZSBhcmUgY2FsbGVkIGJ5IHRoZSBl cnJvciBjYXB0dXJlLCByZXNldCBhbmQgdG8gZHVtcCBlbmdpbmUKPiArCSAqIHN0YXRlIGF0IHJh bmRvbSBwb2ludHMgaW4gdGltZS4gSW4gcGFydGljdWxhciwgbm90ZSB0aGF0IG5laXRoZXIgaXMK PiArCSAqIGNydWNpYWxseSBvcmRlcmVkIHdpdGggYW4gaW50ZXJydXB0LiBBZnRlciBhIGhhbmcs IHRoZSBHUFUgaXMgZGVhZAo+ICsJICogYW5kIHdlIGFzc3VtZSB0aGF0IG5vIG1vcmUgd3JpdGVz IGNhbiBoYXBwZW4gKHdlIHdhaXRlZCBsb25nIGVub3VnaAo+ICsJICogZm9yIGFsbCB3cml0ZXMg dGhhdCB3ZXJlIGluIHRyYW5zYWN0aW9uIHRvIGJlIGZsdXNoZWQpIC0gYWRkaW5nIGFuCj4gKwkg KiBleHRyYSBkZWxheSBmb3IgYSByZWNlbnQgaW50ZXJydXB0IGlzIHBvaW50bGVzcy4gSGVuY2Us IHdlIGRvCj4gKwkgKiBub3QgbmVlZCBhbiBlbmdpbmUtPmlycV9zZXFub19iYXJyaWVyKCkgYmVm b3JlIHRoZSBzZXFubyByZWFkcy4KPiArCSAqIEF0IGFsbCBvdGhlciB0aW1lcywgd2UgbXVzdCBh c3N1bWUgdGhlIEdQVSBpcyBzdGlsbCBydW5uaW5nLCBidXQKPiArCSAqIHdlIG9ubHkgY2FyZSBh Ym91dCB0aGUgc25hcHNob3Qgb2YgdGhpcyBtb21lbnQuCj4gKwkgKi8KPiArCXNwaW5fbG9ja19p cnFzYXZlKCZlbmdpbmUtPnRpbWVsaW5lLmxvY2ssIGZsYWdzKTsKPiArCWxpc3RfZm9yX2VhY2hf ZW50cnkocmVxdWVzdCwgJmVuZ2luZS0+dGltZWxpbmUucmVxdWVzdHMsIGxpbmspIHsKPiArCQlp ZiAoaTkxNV9yZXF1ZXN0X2NvbXBsZXRlZChyZXF1ZXN0KSkKPiArCQkJY29udGludWU7Cj4gKwo+ ICsJCWlmICghaTkxNV9yZXF1ZXN0X3N0YXJ0ZWQocmVxdWVzdCkpCj4gKwkJCWJyZWFrOwo+ICsK PiArCQkvKiBNb3JlIHRoYW4gb25lIHByZWVtcHRpYmxlIHJlcXVlc3QgbWF5IG1hdGNoISAqLwo+ ICsJCWlmICghbWF0Y2hfcmluZyhyZXF1ZXN0KSkKPiArCQkJYnJlYWs7Cj4gKwo+ICsJCWFjdGl2 ZSA9IHJlcXVlc3Q7Cj4gKwkJYnJlYWs7Cj4gKwl9Cj4gKwlzcGluX3VubG9ja19pcnFyZXN0b3Jl KCZlbmdpbmUtPnRpbWVsaW5lLmxvY2ssIGZsYWdzKTsKPiArCj4gKwlyZXR1cm4gYWN0aXZlOwo+ ICt9Cj4gKwo+ICAgI2lmIElTX0VOQUJMRUQoQ09ORklHX0RSTV9JOTE1X1NFTEZURVNUKQo+ICAg I2luY2x1ZGUgInNlbGZ0ZXN0cy9tb2NrX2VuZ2luZS5jIgo+ICAgI2luY2x1ZGUgInNlbGZ0ZXN0 cy9pbnRlbF9lbmdpbmVfY3MuYyIKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfcmluZ2J1ZmZlci5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZl ci5oCj4gaW5kZXggMThlODY1ZmY2NjM3Li44NGI3MDQ3ZTJkZjUgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gQEAgLTEwMTQsNiArMTAxNCw5IEBAIHZvaWQg aW50ZWxfZGlzYWJsZV9lbmdpbmVfc3RhdHMoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5l KTsKPiAgIAo+ICAga3RpbWVfdCBpbnRlbF9lbmdpbmVfZ2V0X2J1c3lfdGltZShzdHJ1Y3QgaW50 ZWxfZW5naW5lX2NzICplbmdpbmUpOwo+ICAgCj4gK3N0cnVjdCBpOTE1X3JlcXVlc3QgKgo+ICtp bnRlbF9lbmdpbmVfZmluZF9hY3RpdmVfcmVxdWVzdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpl bmdpbmUpOwo+ICsKPiAgICNpZiBJU19FTkFCTEVEKENPTkZJR19EUk1fSTkxNV9TRUxGVEVTVCkK PiAgIAo+ICAgc3RhdGljIGlubGluZSBib29sIGluamVjdF9wcmVlbXB0X2hhbmcoc3RydWN0IGlu dGVsX2VuZ2luZV9leGVjbGlzdHMgKmV4ZWNsaXN0cykKPiAKCmludGVsX2VuZ2luZS5oIGluIDMu Li4yLi4uMS4uIDspCgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGlu QGludGVsLmNvbT4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4