From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A899C52D7B for ; Thu, 8 Aug 2024 05:19:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB05C10E638; Thu, 8 Aug 2024 05:19:14 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.b="uejQ3rPe"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="pSwN1YJ4"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="uejQ3rPe"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="pSwN1YJ4"; dkim-atps=neutral Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1EA3010E637; Thu, 8 Aug 2024 05:19:13 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 997FB21B89; Thu, 8 Aug 2024 05:19:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1723094351; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kAjclbPhXyeg2dEOS+Le239UCzeqLOMey1w4D2nPwSA=; b=uejQ3rPeNClYRFuSPlpf5tGZCvO6JcIMgLdC7Ntqtsb+PMeYgIKQW64g+T4CMF9mIeaV4Y HXHGbs8oeR36Jvgku+iW0xNfYzgLKwCgwoQxEPiB9hdrwOb+/VBrZvDf1tRWNGOvbZZ+zG p3/WdxFEsGGaAPfXw5XbC1bR06wfmjg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1723094351; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kAjclbPhXyeg2dEOS+Le239UCzeqLOMey1w4D2nPwSA=; b=pSwN1YJ44KlIOd+hjc57j7CG8g4TxpMN7fzc3vxTDD0ILJ9EbXFEjqY6Adskndlje/56W0 Mmug4rq/cZbSfqAg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1723094351; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kAjclbPhXyeg2dEOS+Le239UCzeqLOMey1w4D2nPwSA=; b=uejQ3rPeNClYRFuSPlpf5tGZCvO6JcIMgLdC7Ntqtsb+PMeYgIKQW64g+T4CMF9mIeaV4Y HXHGbs8oeR36Jvgku+iW0xNfYzgLKwCgwoQxEPiB9hdrwOb+/VBrZvDf1tRWNGOvbZZ+zG p3/WdxFEsGGaAPfXw5XbC1bR06wfmjg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1723094351; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kAjclbPhXyeg2dEOS+Le239UCzeqLOMey1w4D2nPwSA=; b=pSwN1YJ44KlIOd+hjc57j7CG8g4TxpMN7fzc3vxTDD0ILJ9EbXFEjqY6Adskndlje/56W0 Mmug4rq/cZbSfqAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 48BF213770; Thu, 8 Aug 2024 05:19:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id H9d9EE9VtGYMWgAAD6G6ig (envelope-from ); Thu, 08 Aug 2024 05:19:11 +0000 Message-ID: Date: Thu, 8 Aug 2024 07:19:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/9] drm/amdgpu: Use backlight power constants To: Alex Deucher Cc: "Deucher, Alexander" , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "airlied@gmail.com" , "daniel@ffwll.ch" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "intel-xe@lists.freedesktop.org" , "Koenig, Christian" , "Pan, Xinhui" References: <20240731122311.1143153-1-tzimmermann@suse.de> <20240731122311.1143153-2-tzimmermann@suse.de> <6156f386-9316-4777-8cdb-f46ca3a9c183@suse.de> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-1.29 / 50.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_DN_EQ_ADDR_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWELVE(0.00)[12]; FREEMAIL_TO(0.00)[gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[amd.com,linux.intel.com,kernel.org,gmail.com,ffwll.ch,lists.freedesktop.org]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FUZZY_BLOCKED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email] X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Am 07.08.24 um 21:47 schrieb Alex Deucher: > On Tue, Aug 6, 2024 at 3:06 AM Thomas Zimmermann wrote: >> Hi >> >> Am 05.08.24 um 21:00 schrieb Deucher, Alexander: >>> [Public] >>> >>>> -----Original Message----- >>>> From: Thomas Zimmermann >>>> Sent: Wednesday, July 31, 2024 8:17 AM >>>> To: maarten.lankhorst@linux.intel.com; mripard@kernel.org; >>>> airlied@gmail.com; daniel@ffwll.ch >>>> Cc: amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; intel- >>>> gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org; Thomas >>>> Zimmermann ; Deucher, Alexander >>>> ; Koenig, Christian >>>> ; Pan, Xinhui >>>> Subject: [PATCH 1/9] drm/amdgpu: Use backlight power constants >>>> >>>> Replace FB_BLANK_ constants with their counterparts from the backlight >>>> subsystem. The values are identical, so there's no change in functionality or >>>> semantics. >>>> >>>> Signed-off-by: Thomas Zimmermann >>>> Cc: Alex Deucher >>>> Cc: "Christian König" >>>> Cc: Xinhui Pan >>> This patch and the radeon patch are: >>> Acked-by: Alex Deucher >>> >>> Feel free to take them via whatever tree makes sense if you are trying to keep the patches together, or let me know if you want me to pick them up. >> Thank you for the reviews. Please pick up both patches into the rsp AMD >> trees. The i915 patch already went into Intel trees and the rest of the >> series will go into drm-misc. > What changes do these depend on? BACKLIGHT_POWER_ON isn't declared in > my -next tree yet. Might be easier to just run them through drm-misc > if that's where the change is. The constants are in commit a1cacb8a8e70 ("backlight: Add BACKLIGHT_POWER_ constants for power states"), available in v6.11-rc1 and later. Please let me know if I should take the AMD patches into drm-misc-next. Best regards Thomas > > Alex > >> Best regards >> Thomas >> >>> Thanks, >>> >>> Alex >>> >>>> --- >>>> drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c >>>> b/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c >>>> index 25feab188dfe..650ec95bb40a 100644 >>>> --- a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c >>>> +++ b/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c >>>> @@ -215,7 +215,7 @@ void >>>> amdgpu_atombios_encoder_init_backlight(struct amdgpu_encoder >>>> *amdgpu_encode >>>> dig->bl_dev = bd; >>>> >>>> bd->props.brightness = >>>> amdgpu_atombios_encoder_get_backlight_brightness(bd); >>>> - bd->props.power = FB_BLANK_UNBLANK; >>>> + bd->props.power = BACKLIGHT_POWER_ON; >>>> backlight_update_status(bd); >>>> >>>> DRM_INFO("amdgpu atom DIG backlight initialized\n"); >>>> -- >>>> 2.45.2 >> -- >> -- >> Thomas Zimmermann >> Graphics Driver Developer >> SUSE Software Solutions Germany GmbH >> Frankenstrasse 146, 90461 Nuernberg, Germany >> GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman >> HRB 36809 (AG Nuernberg) >> -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)