From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagar Arun Kamble Subject: Re: [PATCH 03/15] drm/i915/guc: Move GuC notification handling to separate function Date: Mon, 5 Mar 2018 13:10:19 +0530 Message-ID: References: <20180227125230.13000-1-michal.winiarski@intel.com> <20180227125230.13000-3-michal.winiarski@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3A40B6E3A5 for ; Mon, 5 Mar 2018 07:40:22 +0000 (UTC) In-Reply-To: <20180227125230.13000-3-michal.winiarski@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?Q?Micha=c5=82_Winiarski?= , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAyLzI3LzIwMTggNjoyMiBQTSwgTWljaGHFgiBXaW5pYXJza2kgd3JvdGU6Cj4gRnJvbTog TWljaGFsIFdhamRlY3prbyA8bWljaGFsLndhamRlY3prb0BpbnRlbC5jb20+Cj4KPiBUbyBhbGxv dyBmdXR1cmUgY29kZSByZXVzZS4gV2hpbGUgaGVyZSwgZml4IGNvbW1lbnQgc3R5bGUuCj4KPiBT dWdnZXN0ZWQtYnk6IE9zY2FyIE1hdGVvIDxvc2Nhci5tYXRlb0BpbnRlbC5jb20+Cj4gU2lnbmVk LW9mZi1ieTogTWljaGFsIFdhamRlY3prbyA8bWljaGFsLndhamRlY3prb0BpbnRlbC5jb20+Cj4g U2lnbmVkLW9mZi1ieTogTWljaGHFgiBXaW5pYXJza2kgPG1pY2hhbC53aW5pYXJza2lAaW50ZWwu Y29tPgo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzog RGFuaWVsZSBDZXJhb2xvIFNwdXJpbyA8ZGFuaWVsZS5jZXJhb2xvc3B1cmlvQGludGVsLmNvbT4K PiBDYzogT3NjYXIgTWF0ZW8gPG9zY2FyLm1hdGVvQGludGVsLmNvbT4KPiBDYzogU2FnYXIgQXJ1 biBLYW1ibGUgPHNhZ2FyLmEua2FtYmxlQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfaXJxLmMgIHwgMzMgKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuYyB8IDM3ICsrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2d1Yy5oIHwgIDEgKwo+ICAgMyBmaWxlcyBjaGFuZ2VkLCA0MCBpbnNlcnRpb25zKCspLCAzMSBk ZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2ly cS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+IGluZGV4IDBhN2VkOTkwYThk MS4uMDIzYmE4OTdlOTkxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf aXJxLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gQEAgLTE3NTks MzcgKzE3NTksOCBAQCBzdGF0aWMgdm9pZCBnZW42X3Jwc19pcnFfaGFuZGxlcihzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHUzMiBwbV9paXIpCj4gICAKPiAgIHN0YXRpYyB2b2lk IGdlbjlfZ3VjX2lycV9oYW5kbGVyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwg dTMyIGd0X2lpcikKPiAgIHsKPiAtCWlmIChndF9paXIgJiBHRU45X0dVQ19UT19IT1NUX0lOVF9F VkVOVCkgewo+IC0JCS8qIFNhbXBsZSB0aGUgbG9nIGJ1ZmZlciBmbHVzaCByZWxhdGVkIGJpdHMg JiBjbGVhciB0aGVtIG91dCBub3cKPiAtCQkgKiBpdHNlbGYgZnJvbSB0aGUgbWVzc2FnZSBpZGVu dGl0eSByZWdpc3RlciB0byBtaW5pbWl6ZSB0aGUKPiAtCQkgKiBwcm9iYWJpbGl0eSBvZiBsb3Np bmcgYSBmbHVzaCBpbnRlcnJ1cHQsIHdoZW4gdGhlcmUgYXJlIGJhY2sKPiAtCQkgKiB0byBiYWNr IGZsdXNoIGludGVycnVwdHMuCj4gLQkJICogVGhlcmUgY2FuIGJlIGEgbmV3IGZsdXNoIGludGVy cnVwdCwgZm9yIGRpZmZlcmVudCBsb2cgYnVmZmVyCj4gLQkJICogdHlwZSAobGlrZSBmb3IgSVNS KSwgd2hpbHN0IEhvc3QgaXMgaGFuZGxpbmcgb25lIChmb3IgRFBDKS4KPiAtCQkgKiBTaW5jZSBz YW1lIGJpdCBpcyB1c2VkIGluIG1lc3NhZ2UgcmVnaXN0ZXIgZm9yIElTUiAmIERQQywgaXQKPiAt CQkgKiBjb3VsZCBoYXBwZW4gdGhhdCBHdUMgc2V0cyB0aGUgYml0IGZvciAybmQgaW50ZXJydXB0 IGJ1dCBIb3N0Cj4gLQkJICogY2xlYXJzIG91dCB0aGUgYml0IG9uIGhhbmRsaW5nIHRoZSAxc3Qg aW50ZXJydXB0Lgo+IC0JCSAqLwo+IC0JCXUzMiBtc2csIGZsdXNoOwo+IC0KPiAtCQltc2cgPSBJ OTE1X1JFQUQoU09GVF9TQ1JBVENIKDE1KSk7Cj4gLQkJZmx1c2ggPSBtc2cgJiAoSU5URUxfR1VD X1JFQ1ZfTVNHX0NSQVNIX0RVTVBfUE9TVEVEIHwKPiAtCQkJICAgICAgIElOVEVMX0dVQ19SRUNW X01TR19GTFVTSF9MT0dfQlVGRkVSKTsKPiAtCQlpZiAoZmx1c2gpIHsKPiAtCQkJLyogQ2xlYXIg dGhlIG1lc3NhZ2UgYml0cyB0aGF0IGFyZSBoYW5kbGVkICovCj4gLQkJCUk5MTVfV1JJVEUoU09G VF9TQ1JBVENIKDE1KSwgbXNnICYgfmZsdXNoKTsKPiAtCj4gLQkJCS8qIEhhbmRsZSBmbHVzaCBp bnRlcnJ1cHQgaW4gYm90dG9tIGhhbGYgKi8KPiAtCQkJcXVldWVfd29yayhkZXZfcHJpdi0+Z3Vj LmxvZy5ydW50aW1lLmZsdXNoX3dxLAo+IC0JCQkJICAgJmRldl9wcml2LT5ndWMubG9nLnJ1bnRp bWUuZmx1c2hfd29yayk7Cj4gLQo+IC0JCQlkZXZfcHJpdi0+Z3VjLmxvZy5mbHVzaF9pbnRlcnJ1 cHRfY291bnQrKzsKPiAtCQl9IGVsc2Ugewo+IC0JCQkvKiBOb3QgY2xlYXJpbmcgb2YgdW5oYW5k bGVkIGV2ZW50IGJpdHMgd29uJ3QgcmVzdWx0IGluCj4gLQkJCSAqIHJlLXRyaWdnZXJpbmcgb2Yg dGhlIGludGVycnVwdC4KPiAtCQkJICovCj4gLQkJfQo+IC0JfQo+ICsJaWYgKGd0X2lpciAmIEdF TjlfR1VDX1RPX0hPU1RfSU5UX0VWRU5UKQo+ICsJCWludGVsX2d1Y19ub3RpZmljYXRpb25faGFu ZGxlcigmZGV2X3ByaXYtPmd1Yyk7ClRoZXJlIGlzIEdVQ19OT1RJRklDQVRJT05fRVZFTlQgKHdo aWNoIHNlZW1zIHRvIGJlIHVudXNlZCB0aG91Z2gpIGV2ZW50IAp3aG9zZSBuYW1lIG1hdGNoZXMg d2l0aCBwcm9wb3NlZCBmdW5jdGlvbiBuYW1lIHRvIHNvbWUgZXh0ZW50LgpJIHRoaW5rwqAgd2Ug c2hvdWxkIGNoYW5nZSB0aGUgbmFtZSB0byAiaW50ZWxfZ3VjX2cyaF9pbnRfaGFuZGxlciIgb3Ig CnNvbWUgb3RoZXIuIE90aGVyIGV2ZW50cyB0b28gYXJlIGtpbmQgb2Ygbm90aWZpY2F0aW9uIHRv IGhvc3QuCk90aGVyd2lzZSBjaGFuZ2UgbG9va3MgZ29vZC4KPiAgIH0KPiAgIAo+ICAgc3RhdGlj IHZvaWQgaTl4eF9waXBlc3RhdF9pcnFfcmVzZXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2KQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5jCj4gaW5kZXggMjExNDBjY2Q3YTk3Li5m NjIyZGQ2MDA5YjYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3Vj LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuYwo+IEBAIC0zNjQsNiAr MzY0LDQzIEBAIGludCBpbnRlbF9ndWNfc2VuZF9tbWlvKHN0cnVjdCBpbnRlbF9ndWMgKmd1Yywg Y29uc3QgdTMyICphY3Rpb24sIHUzMiBsZW4pCj4gICAJcmV0dXJuIHJldDsKPiAgIH0KPiAgIAo+ ICt2b2lkIGludGVsX2d1Y19ub3RpZmljYXRpb25faGFuZGxlcihzdHJ1Y3QgaW50ZWxfZ3VjICpn dWMpCj4gK3sKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGd1Y190b19p OTE1KGd1Yyk7Cj4gKwl1MzIgbXNnLCBmbHVzaDsKPiArCj4gKwkvKgo+ICsJICogU2FtcGxlIHRo ZSBsb2cgYnVmZmVyIGZsdXNoIHJlbGF0ZWQgYml0cyAmIGNsZWFyIHRoZW0gb3V0IG5vdwo+ICsJ ICogaXRzZWxmIGZyb20gdGhlIG1lc3NhZ2UgaWRlbnRpdHkgcmVnaXN0ZXIgdG8gbWluaW1pemUg dGhlCj4gKwkgKiBwcm9iYWJpbGl0eSBvZiBsb3NpbmcgYSBmbHVzaCBpbnRlcnJ1cHQsIHdoZW4g dGhlcmUgYXJlIGJhY2sKPiArCSAqIHRvIGJhY2sgZmx1c2ggaW50ZXJydXB0cy4KPiArCSAqIFRo ZXJlIGNhbiBiZSBhIG5ldyBmbHVzaCBpbnRlcnJ1cHQsIGZvciBkaWZmZXJlbnQgbG9nIGJ1ZmZl cgo+ICsJICogdHlwZSAobGlrZSBmb3IgSVNSKSwgd2hpbHN0IEhvc3QgaXMgaGFuZGxpbmcgb25l IChmb3IgRFBDKS4KPiArCSAqIFNpbmNlIHNhbWUgYml0IGlzIHVzZWQgaW4gbWVzc2FnZSByZWdp c3RlciBmb3IgSVNSICYgRFBDLCBpdAo+ICsJICogY291bGQgaGFwcGVuIHRoYXQgR3VDIHNldHMg dGhlIGJpdCBmb3IgMm5kIGludGVycnVwdCBidXQgSG9zdAo+ICsJICogY2xlYXJzIG91dCB0aGUg Yml0IG9uIGhhbmRsaW5nIHRoZSAxc3QgaW50ZXJydXB0Lgo+ICsJICovCj4gKwo+ICsJbXNnID0g STkxNV9SRUFEKFNPRlRfU0NSQVRDSCgxNSkpOwo+ICsJZmx1c2ggPSBtc2cgJiAoSU5URUxfR1VD X1JFQ1ZfTVNHX0NSQVNIX0RVTVBfUE9TVEVEIHwKPiArCQkgICAgICAgSU5URUxfR1VDX1JFQ1Zf TVNHX0ZMVVNIX0xPR19CVUZGRVIpOwo+ICsJaWYgKGZsdXNoKSB7Cj4gKwkJLyogQ2xlYXIgdGhl IG1lc3NhZ2UgYml0cyB0aGF0IGFyZSBoYW5kbGVkICovCj4gKwkJSTkxNV9XUklURShTT0ZUX1ND UkFUQ0goMTUpLCBtc2cgJiB+Zmx1c2gpOwo+ICsKPiArCQkvKiBIYW5kbGUgZmx1c2ggaW50ZXJy dXB0IGluIGJvdHRvbSBoYWxmICovCj4gKwkJcXVldWVfd29yayhndWMtPmxvZy5ydW50aW1lLmZs dXNoX3dxLAo+ICsJCQkgICAmZ3VjLT5sb2cucnVudGltZS5mbHVzaF93b3JrKTsKPiArCj4gKwkJ Z3VjLT5sb2cuZmx1c2hfaW50ZXJydXB0X2NvdW50Kys7Cj4gKwl9IGVsc2Ugewo+ICsJCS8qCj4g KwkJICogTm90IGNsZWFyaW5nIG9mIHVuaGFuZGxlZCBldmVudCBiaXRzIHdvbid0IHJlc3VsdCBp bgo+ICsJCSAqIHJlLXRyaWdnZXJpbmcgb2YgdGhlIGludGVycnVwdC4KPiArCQkgKi8KPiArCX0K PiArfQo+ICsKPiAgIGludCBpbnRlbF9ndWNfc2FtcGxlX2ZvcmNld2FrZShzdHJ1Y3QgaW50ZWxf Z3VjICpndWMpCj4gICB7Cj4gICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0g Z3VjX3RvX2k5MTUoZ3VjKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZ3VjLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaAo+IGluZGV4IDUyODU2 YTk3NDc3ZC4uNWI5MDViYWUxODFkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2d1Yy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgKPiBA QCAtMTI1LDYgKzEyNSw3IEBAIGludCBpbnRlbF9ndWNfaW5pdChzdHJ1Y3QgaW50ZWxfZ3VjICpn dWMpOwo+ICAgdm9pZCBpbnRlbF9ndWNfZmluaShzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpOwo+ICAg aW50IGludGVsX2d1Y19zZW5kX25vcChzdHJ1Y3QgaW50ZWxfZ3VjICpndWMsIGNvbnN0IHUzMiAq YWN0aW9uLCB1MzIgbGVuKTsKPiAgIGludCBpbnRlbF9ndWNfc2VuZF9tbWlvKHN0cnVjdCBpbnRl bF9ndWMgKmd1YywgY29uc3QgdTMyICphY3Rpb24sIHUzMiBsZW4pOwo+ICt2b2lkIGludGVsX2d1 Y19ub3RpZmljYXRpb25faGFuZGxlcihzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpOwo+ICAgaW50IGlu dGVsX2d1Y19zYW1wbGVfZm9yY2V3YWtlKHN0cnVjdCBpbnRlbF9ndWMgKmd1Yyk7Cj4gICBpbnQg aW50ZWxfZ3VjX2F1dGhfaHVjKHN0cnVjdCBpbnRlbF9ndWMgKmd1YywgdTMyIHJzYV9vZmZzZXQp Owo+ICAgaW50IGludGVsX2d1Y19zdXNwZW5kKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdik7CgotLSAKVGhhbmtzLApTYWdhcgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==