Re: [PATCH 03/15] drm/i915/guc: Add send_and_receive() helper function

[Michel Thierry <michel.thierry@intel.com>]

On 8/4/2017 9:27 AM, Michal Wajdeczko wrote:
> In the previous patch we have changed signature of the send function
> pointer but we didn't modify signature of the corresponding helper
> function to minimize number of required changes. Let's add separate
> helper to expose new functionality but still hide underlying details.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Oscar Mateo <oscar.mateo@intel.com>
> Cc: Michel Thierry <michel.thierry@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> ---
>   drivers/gpu/drm/i915/intel_uc.h | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_uc.h b/drivers/gpu/drm/i915/intel_uc.h
> index 53ea5f1..9353ac3 100644
> --- a/drivers/gpu/drm/i915/intel_uc.h
> +++ b/drivers/gpu/drm/i915/intel_uc.h
> @@ -235,6 +235,13 @@ static inline int intel_guc_send(struct intel_guc *guc, const u32 *action, u32 l
>   	return guc->send(guc, action, len, NULL);
>   }
>   
> +static inline int intel_guc_send_and_receive(struct intel_guc *guc,
> +					     const u32 *action, u32 len,
> +					     u32 *response)
> +{
> +	return guc->send(guc, action, len, response);
> +}
> +
>   static inline void intel_guc_notify(struct intel_guc *guc)
>   {
>   	guc->notify(guc);
> 

No users for now, anyway

Reviewed-by: Michel Thierry <michel.thierry@intel.com>

I just think this patch should come after #4 ("drm/i915/guc: Implement 
response handling in send_mmio()").
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx