Re: [PATCH v3 2/2] drm/i915/guc : Decouple logs from submission

Sujaritha
2017-09-19T17:22:17Z

Sure, I will rename the commit message. Thanks.

On 09/19/2017 10:11 AM, Daniele Ceraolo Spurio wrote:
> Since we're not decoupling just logs, maybe the commit could be
> renamed to "Decouple ADS and logs from submission"
>
> On 19/09/17 09:15, Sujaritha Sundaresan wrote:
>> The Additional Data Struct (ADS) contains objects that are required by
>> guc post FW load and are not necessarily submission-only (although
>> that's
>> our current only use-case). If in the future we load GuC with submission
>> disabled to use some other GuC feature we might still end up requiring
>> something inside the ADS, so it makes more sense for them to be always
>> created if GuC is loaded.
>
> To make a concrete example, the pages used by GuC to save state during
> suspend are allocated as part of the ADS.
>
>> Similarly, we still want to access GuC logs even if GuC submission is
>> disable to debug issues with GuC loading or with wathever we're using
>> GuC for.
>>
>> v2: Decoupling ads together with logs
>> v3: Group initialization of GuC objects
>>
>> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Cc: Oscar Mateo <oscar.mateo@intel.com>
>> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>> Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
>
> Acked-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>