From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Subject: Re: [PATCH v2 2/7] drm/atomic: Clean up
	drm_atomic_helper_async_check
Date: Tue, 25 Jul 2017 11:11:33 +0200
Message-ID: <db5b893f-8ed8-6c40-011d-3c82e52cb46f@linux.intel.com>
References: <20170719143920.25685-1-maarten.lankhorst@linux.intel.com>
 <20170719143920.25685-3-maarten.lankhorst@linux.intel.com>
 <20170725082305.lodeuonv37l6kbz2@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
In-Reply-To: <20170725082305.lodeuonv37l6kbz2@phenom.ffwll.local>
Content-Language: en-US
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Gustavo Padovan <gustavo.padovan@collabora.com>, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T3AgMjUtMDctMTcgb20gMTA6MjMgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+IE9uIFdlZCwgSnVs
IDE5LCAyMDE3IGF0IDA0OjM5OjE1UE0gKzAyMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+
PiBJbnN0ZWFkIG9mIGFzc2lnbmluZyBwbGFuZSB0byBfX3BsYW5lLCBpdGVyYXRlIG92ZXIgcGxh
bmUKPj4gd2hpY2ggaXMgdGhlIHNhbWUgdGhpbmcuIFNpbXBsaWZ5IHRoZSBjaGVjayBmb3Igbl9w
bGFuZXMgIT0gMSwKPj4gYXQgdGhhdCBwb2ludCB3ZSBrbm93IHBsYW5lICE9IE5VTEwgYXMgd2Vs
bC4KPj4KPj4gUmVuYW1lIG9ial9zdGF0ZSB0byBuZXdfb2JqX3N0YXRlLCBhbmQgZ2V0IHJpZCBv
ZiB0aGUgYm9ndXMgc3R1ZmYuCj4+IGNydGMtPnN0YXRlLT5zdGF0ZSBpcyBORVZFUiBub24tbnVs
bCwgaWYgaXQgaXMsIHRoZXJlIGlzIGEgYnVnLgo+PiBXZSBzaG91bGQgZGVmaW5pdGVseSB0cnkg
dG8gcHJldmVudCBhc3luYyB1cGRhdGVzIGlmIHRoZXJlIGFyZSBmbGlwcwo+PiBxdWV1ZWQsIGJ1
dCB0aGlzIGNvZGUgd2lsbCBzaW1wbHkgbm90IGJlIGV4ZWN1dGVkIGFuZCBuZWVkcyB0byBiZQo+
PiByZXRob3VnaHQuCj4+Cj4+IEFsc28gcmVtb3ZlIHRoZSBsb29wIHRvbywgYmVjYXVzZSB3ZSdy
ZSB0cnlpbmcgdG8gbG9vcCBvdmVyIHRoZSBjcnRjIHVudGlsCj4+IHdlIGZpbmQgcGxhbmVfc3Rh
dGUtPmNydGMgPT0gY3J0Yywgd2hpY2ggd2UgYWxyZWFkeSBrbm93IGlzIG5vbi16ZXJvLgo+PiBJ
dCdzIGRlYWQgY29kZSBhbnl3YXkuIDopCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFu
a2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4+IENjOiBHdXN0YXZv
IFBhZG92YW4gPGd1c3Rhdm8ucGFkb3ZhbkBjb2xsYWJvcmEuY29tPgo+PiAtLS0KPj4gIGRyaXZl
cnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIHwgNTYgKysrKysrKysrKy0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLQo+PiAgMSBmaWxlIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDQx
IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9t
aWNfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+PiBpbmRl
eCBhNDZiNTEyOTEwMDYuLmM1Mzg1MjhhNzk0YSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUv
ZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9t
aWNfaGVscGVyLmMKPj4gQEAgLTEzNzIsNjggKzEzNzIsNDIgQEAgaW50IGRybV9hdG9taWNfaGVs
cGVyX2FzeW5jX2NoZWNrKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+ICAJCQkJICAgc3RydWN0
IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+PiAgewo+PiAgCXN0cnVjdCBkcm1fY3J0YyAqY3J0
YzsKPj4gLQlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4+IC0Jc3RydWN0IGRy
bV9jcnRjX2NvbW1pdCAqY29tbWl0Owo+PiAtCXN0cnVjdCBkcm1fcGxhbmUgKl9fcGxhbmUsICpw
bGFuZSA9IE5VTEw7Cj4+IC0Jc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqX19wbGFuZV9zdGF0ZSwg
KnBsYW5lX3N0YXRlID0gTlVMTDsKPj4gKwlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKm5ld19jcnRj
X3N0YXRlOwo+PiArCXN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lOwo+PiArCXN0cnVjdCBkcm1fcGxh
bmVfc3RhdGUgKm5ld19wbGFuZV9zdGF0ZTsKPj4gIAljb25zdCBzdHJ1Y3QgZHJtX3BsYW5lX2hl
bHBlcl9mdW5jcyAqZnVuY3M7Cj4+IC0JaW50IGksIGosIG5fcGxhbmVzID0gMDsKPj4gKwlpbnQg
aSwgbl9wbGFuZXMgPSAwOwo+PiAgCj4+IC0JZm9yX2VhY2hfbmV3X2NydGNfaW5fc3RhdGUoc3Rh
dGUsIGNydGMsIGNydGNfc3RhdGUsIGkpIHsKPj4gLQkJaWYgKGRybV9hdG9taWNfY3J0Y19uZWVk
c19tb2Rlc2V0KGNydGNfc3RhdGUpKQo+PiArCWZvcl9lYWNoX25ld19jcnRjX2luX3N0YXRlKHN0
YXRlLCBjcnRjLCBuZXdfY3J0Y19zdGF0ZSwgaSkgewo+PiArCQlpZiAoZHJtX2F0b21pY19jcnRj
X25lZWRzX21vZGVzZXQobmV3X2NydGNfc3RhdGUpKQo+PiAgCQkJcmV0dXJuIC1FSU5WQUw7Cj4+
ICAJfQo+PiAgCj4+IC0JZm9yX2VhY2hfbmV3X3BsYW5lX2luX3N0YXRlKHN0YXRlLCBfX3BsYW5l
LCBfX3BsYW5lX3N0YXRlLCBpKSB7Cj4+ICsJZm9yX2VhY2hfbmV3X3BsYW5lX2luX3N0YXRlKHN0
YXRlLCBwbGFuZSwgbmV3X3BsYW5lX3N0YXRlLCBpKQo+PiAgCQluX3BsYW5lcysrOwo+PiAtCQlw
bGFuZSA9IF9fcGxhbmU7Cj4+IC0JCXBsYW5lX3N0YXRlID0gX19wbGFuZV9zdGF0ZTsKPj4gLQl9
Cj4+ICAKPj4gIAkvKiBGSVhNRTogd2Ugc3VwcG9ydCBvbmx5IHNpbmdsZSBwbGFuZSB1cGRhdGVz
IGZvciBub3cgKi8KPj4gLQlpZiAoIXBsYW5lIHx8IG5fcGxhbmVzICE9IDEpCj4+ICsJaWYgKG5f
cGxhbmVzICE9IDEpCj4+ICAJCXJldHVybiAtRUlOVkFMOwo+PiAgCj4+IC0JaWYgKCFwbGFuZV9z
dGF0ZS0+Y3J0YykKPj4gKwlpZiAoIW5ld19wbGFuZV9zdGF0ZS0+Y3J0YykKPj4gIAkJcmV0dXJu
IC1FSU5WQUw7Cj4+ICAKPj4gIAlmdW5jcyA9IHBsYW5lLT5oZWxwZXJfcHJpdmF0ZTsKPj4gIAlp
ZiAoIWZ1bmNzLT5hdG9taWNfYXN5bmNfdXBkYXRlKQo+PiAgCQlyZXR1cm4gLUVJTlZBTDsKPj4g
IAo+PiAtCWlmIChwbGFuZV9zdGF0ZS0+ZmVuY2UpCj4+ICsJaWYgKG5ld19wbGFuZV9zdGF0ZS0+
ZmVuY2UpCj4+ICAJCXJldHVybiAtRUlOVkFMOwo+PiAgCj4+ICAJLyoKPj4gLQkgKiBEb24ndCBk
byBhbiBhc3luYyB1cGRhdGUgaWYgdGhlcmUgaXMgYW4gb3V0c3RhbmRpbmcgY29tbWl0IG1vZGlm
eWluZwo+PiAtCSAqIHRoZSBwbGFuZS4gIFRoaXMgcHJldmVudHMgb3VyIGFzeW5jIHVwZGF0ZSdz
IGNoYW5nZXMgZnJvbSBnZXR0aW5nCj4+IC0JICogb3ZlcnJpZGRlbiBieSBhIHByZXZpb3VzIHN5
bmNocm9ub3VzIHVwZGF0ZSdzIHN0YXRlLgo+PiArCSAqIEZJWE1FOiBXZSBzaG91bGQgcHJldmVu
dCBhbiBhc3luYyB1cGRhdGUgaWYgdGhlcmUgaXMgYW4gb3V0c3RhbmRpbmcKPj4gKwkgKiBjb21t
aXQgbW9kaWZ5aW5nIHRoZSBwbGFuZS4gIFRoaXMgcHJldmVudHMgb3VyIGFzeW5jIHVwZGF0ZSdz
Cj4+ICsJICogY2hhbmdlcyBmcm9tIGdldHRpbmcgb3ZlcndyaXR0ZW4gYnkgYSBwcmV2aW91cyBz
eW5jaHJvbm91cyB1cGRhdGUncwo+PiArCSAqIHN0YXRlLgo+PiAgCSAqLwo+PiAtCWZvcl9lYWNo
X25ld19jcnRjX2luX3N0YXRlKHN0YXRlLCBjcnRjLCBjcnRjX3N0YXRlLCBpKSB7Cj4+IC0JCWlm
IChwbGFuZS0+Y3J0YyAhPSBjcnRjKQo+PiAtCQkJY29udGludWU7Cj4+IC0KPj4gLQkJc3Bpbl9s
b2NrKCZjcnRjLT5jb21taXRfbG9jayk7Cj4+IC0JCWNvbW1pdCA9IGxpc3RfZmlyc3RfZW50cnlf
b3JfbnVsbCgmY3J0Yy0+Y29tbWl0X2xpc3QsCj4+IC0JCQkJCQkgIHN0cnVjdCBkcm1fY3J0Y19j
b21taXQsCj4+IC0JCQkJCQkgIGNvbW1pdF9lbnRyeSk7Cj4+IC0JCWlmICghY29tbWl0KSB7Cj4+
IC0JCQlzcGluX3VubG9jaygmY3J0Yy0+Y29tbWl0X2xvY2spOwo+PiAtCQkJY29udGludWU7Cj4+
IC0JCX0KPj4gLQkJc3Bpbl91bmxvY2soJmNydGMtPmNvbW1pdF9sb2NrKTsKPj4gLQo+PiAtCQlp
ZiAoIWNydGMtPnN0YXRlLT5zdGF0ZSkKPj4gLQkJCWNvbnRpbnVlOwo+PiAtCj4+IC0JCWZvcl9l
YWNoX3BsYW5lX2luX3N0YXRlKGNydGMtPnN0YXRlLT5zdGF0ZSwgX19wbGFuZSwKPj4gLQkJCQkJ
X19wbGFuZV9zdGF0ZSwgaikgewo+IEknbSBwcmV0dHkgc3VyZSB0aGlzIG9vcHNlcywgYmVjYXVz
ZSBjcnRjLT5zdGF0ZS0+c3RhdGUgaXMgTlVMTCBhZnRlcgo+IGNvbW1pdC4gSSB0aGluayBHdXN0
YXZvIG5lZWRzIHRvIHJldmlldyB0aGlzIGZpcnN0IChhbmQgd3JpdGUgYSBuYXN0eSBpZ3QKPiB0
ZXN0Y2FzZSB0byBjYXRjaCBpdCkgYmVmb3JlIHdlIHJlbW92ZSB0aGlzLiBJIHRoaW5rIHRoZSBj
b3JyZWN0IGNoZWNrIGlzCj4gdG8gc2ltcGx5IGJhaWwgb3V0IGlmIG91ciBjdXJyZW50IGNydGMg
aGFzIGEgcGVuZGluZyBjb21taXQgKGkuZS4KPiAhbGlzdF9lbXB0eSgmY3J0Yy0+Y29tbWl0X2xp
c3QpIHNob3VsZCBiZSBhbGwgd2UgbmVlZCB0byBjaGVjay4KSXQgZGlkbid0IG9vcHMuIFJpZ2h0
IGFib3ZlIGl0IHdhcyBhIG51bGwgY2hlY2suIEl0IHdhcyBuZXZlciBleGVjdXRlZC4gOikKCm9i
ai0+c3RhdGUtPnN0YXRlIGlzIGFsd2F5cyBOVUxMLiBFeGNsdWRpbmcgYSBicmllZiBtb21lbnQg
ZHVyaW5nIHN3YXBfc3RhdGUgd2hlcmUgdGhpcyBtYXkgb29wcywgIHRoaXMgY29kZSB3aWxsbCBu
ZXZlciBkbyBhIHRoaW5nLgo+IEJ1dCBJIHRoaW5rIHdlIG5lZWQgYSB0ZXN0Y2FzZSBmb3IgdGhp
cy4KPgo+IE90aGVyd2lzZSB0aGUgcGF0Y2ggbG9va3Mgb2sgSSB0aGluay4KPiAtRGFuaWVsCj4K
Pgo+PiAtCQkJaWYgKF9fcGxhbmUgPT0gcGxhbmUpCj4+IC0JCQkJcmV0dXJuIC1FSU5WQUw7Cj4+
IC0JCX0KPj4gLQl9Cj4+ICAKPj4gLQlyZXR1cm4gZnVuY3MtPmF0b21pY19hc3luY19jaGVjayhw
bGFuZSwgcGxhbmVfc3RhdGUpOwo+PiArCXJldHVybiBmdW5jcy0+YXRvbWljX2FzeW5jX2NoZWNr
KHBsYW5lLCBuZXdfcGxhbmVfc3RhdGUpOwo+PiAgfQo+PiAgRVhQT1JUX1NZTUJPTChkcm1fYXRv
bWljX2hlbHBlcl9hc3luY19jaGVjayk7Cj4+ICAKPj4gLS0gCj4+IDIuMTEuMAo+Pgo+PiBfX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+PiBkcmktZGV2ZWwg
bWFpbGluZyBsaXN0Cj4+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPj4gaHR0cHM6
Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCgpfX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp
bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m
cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK