From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63B1CCA0FE7 for ; Mon, 25 Aug 2025 16:24:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F3B3510E500; Mon, 25 Aug 2025 16:23:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="dDUmMVA6"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 90C0D10E500 for ; Mon, 25 Aug 2025 16:23:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756139036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZJ9VR6/AHZevQeWHrHcSWQbnm5iFaXQGfgpXOMo3AYo=; b=dDUmMVA6HcRSipyvBDrIOERDyZDqPOw4wX0GvJytbtWhJjlik+zHFQLdvDIz4OivxCzIzm WCK41L9TtFieQFT0A97lyR6ApJjZko+XJhH1qIhwxCVafRyuhTNCp3g/whrPFL8l2ivhaL 8zknhX+4yOtQ4Ce+7C8ie46/5ivCQQI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-8-9u8Sh5m8OjerqiSkqbhviA-1; Mon, 25 Aug 2025 12:23:53 -0400 X-MC-Unique: 9u8Sh5m8OjerqiSkqbhviA-1 X-Mimecast-MFC-AGG-ID: 9u8Sh5m8OjerqiSkqbhviA_1756139032 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-45b612dbc28so7294405e9.0 for ; Mon, 25 Aug 2025 09:23:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756139032; x=1756743832; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZJ9VR6/AHZevQeWHrHcSWQbnm5iFaXQGfgpXOMo3AYo=; b=DN7aJA7Q4v+YamTbdY187y1olUy7RDv2HDhoDd8NRjj5WjMRoMpSXEm71oZ4DOpcVM 8ltuarNjpnY5CYFUVh7jbaTkVC/2CERmAwT88qgbp6eXhKx5h+4yVyOe/ysgh2AOWT9G 3R+0WXX+rFMWXABOS/odWXGCnVn2WHyoVnHfkH8btmCjAE6C2b7a60mk366eOdLMALyi 4FGBhykfMZYdxLc//jYpnaEXVGVJqkKpSqrk7RLyaGALsMd3l5qyZ10NOGjYWhucyY0Y D3YES5c21K3vTWy8Y307w0MAC2dbSKG4/XpmMIsDSpq0yHdnoEL6wR+n3OZsE/M65q/T 8yaw== X-Forwarded-Encrypted: i=1; AJvYcCWQUHhEyzs7hZEOMu3lyT7D5QWqMXKa9vtSXams8qsaKwd0cj3h0wLsV3GqroC3AX4xDXnDSODmpHI=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yy9odLrpehfv1A5uA0F+XeRnBQAVaVEPtss5FNKli3K0TA1bUGL 9cUYI5pjZbnD/LNQIzbiVndX8SlOlmWC0bOn0nss7Vi/txCHV+CmM/jtjWYnOoAiVpn7YvV1HO+ 7HJnm2cL38h+GXYsFjZ8dJrpt1n5cXh3zmFZE8LygGLikkI2YiMv0LDN+FV21x6gVa6MOKA== X-Gm-Gg: ASbGncvOLbivBjf3B8SszGBqcqw5I1H3j91IrPuOJf9ngWTpO8P7zZDOrb4lRlgbT8t 3JJv46izQFsl37091UFZdnXg7kN5ernMe/705SMCg5HR2iEKneMpS6Q9ioL7M4Gued2C5krVWc8 JywdmuyhBNUxORyca7rwJ8QMN+s50RaCxNqCjsB9NWF529uXaqp6zG3l4BbBiY4YHfbTjpn7Dgj zJXFvqSxjiY6OwKVrn+Wbt7m5ijpsd6VWUn6zbxQjFCVIvdZEndYQNuGaj0NldEYyqdO4ngn47S bqsVdPTbbiwKREXkyclcisgmwRwAmD6x7TOfjWErX6bm8ghUrx3UuJohP2dol6yC38ZcRN0NAWG MQfWFijYwatbTSrTyb3XHWf2x0o2rxC50X9J4y63fdpjhfMojVLvoRyY57FhmzH8EfT4= X-Received: by 2002:a05:600c:4685:b0:458:bfe1:4a91 with SMTP id 5b1f17b1804b1-45b517c5551mr109881715e9.20.1756139031890; Mon, 25 Aug 2025 09:23:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFwiDwmGl/nPb74qkNKdwOJy23XqbHKXC5/+W47v3i62q/hY+QH66S6ZkeqOx/rk3ktbwdSNA== X-Received: by 2002:a05:600c:4685:b0:458:bfe1:4a91 with SMTP id 5b1f17b1804b1-45b517c5551mr109881195e9.20.1756139031315; Mon, 25 Aug 2025 09:23:51 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4f:1300:42f1:98e5:ddf8:3a76? (p200300d82f4f130042f198e5ddf83a76.dip0.t-ipconnect.de. [2003:d8:2f4f:1300:42f1:98e5:ddf8:3a76]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b5fec8e80sm29037215e9.0.2025.08.25.09.23.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Aug 2025 09:23:50 -0700 (PDT) Message-ID: Date: Mon, 25 Aug 2025 18:23:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 10/35] mm/hugetlb: cleanup hugetlb_folio_init_tail_vmemmap() To: Mike Rapoport Cc: =?UTF-8?Q?Mika_Penttil=C3=A4?= , linux-kernel@vger.kernel.org, Alexander Potapenko , Andrew Morton , Brendan Jackman , Christoph Lameter , Dennis Zhou , Dmitry Vyukov , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, iommu@lists.linux.dev, io-uring@vger.kernel.org, Jason Gunthorpe , Jens Axboe , Johannes Weiner , John Hubbard , kasan-dev@googlegroups.com, kvm@vger.kernel.org, "Liam R. Howlett" , Linus Torvalds , linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-ide@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Lorenzo Stoakes , Marco Elver , Marek Szyprowski , Michal Hocko , Muchun Song , netdev@vger.kernel.org, Oscar Salvador , Peter Xu , Robin Murphy , Suren Baghdasaryan , Tejun Heo , virtualization@lists.linux.dev, Vlastimil Babka , wireguard@lists.zx2c4.com, x86@kernel.org, Zi Yan References: <20250821200701.1329277-1-david@redhat.com> <20250821200701.1329277-11-david@redhat.com> <9156d191-9ec4-4422-bae9-2e8ce66f9d5e@redhat.com> <7077e09f-6ce9-43ba-8f87-47a290680141@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bK88FX2QbeM4AJQ1MU66-A81BNY4B6ns_ilc6sG19Tk_1756139032 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" > >> We should do something like: >> >> diff --git a/mm/memblock.c b/mm/memblock.c >> index 154f1d73b61f2..ed4c563d72c32 100644 >> --- a/mm/memblock.c >> +++ b/mm/memblock.c >> @@ -1091,13 +1091,16 @@ int __init_memblock memblock_clear_nomap(phys_addr_t base, phys_addr_t size) >> /** >> * memblock_reserved_mark_noinit - Mark a reserved memory region with flag >> - * MEMBLOCK_RSRV_NOINIT which results in the struct pages not being initialized >> - * for this region. >> + * MEMBLOCK_RSRV_NOINIT which allows for the "struct pages" corresponding >> + * to this region not getting initialized, because the caller will take >> + * care of it. >> * @base: the base phys addr of the region >> * @size: the size of the region >> * >> - * struct pages will not be initialized for reserved memory regions marked with >> - * %MEMBLOCK_RSRV_NOINIT. >> + * "struct pages" will not be initialized for reserved memory regions marked >> + * with %MEMBLOCK_RSRV_NOINIT if this function is called before initialization >> + * code runs. Without CONFIG_DEFERRED_STRUCT_PAGE_INIT, it is more likely >> + * that this function is not effective. >> * >> * Return: 0 on success, -errno on failure. >> */ > > I have a different version :) > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index b96746376e17..d20d091c6343 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -40,8 +40,9 @@ extern unsigned long long max_possible_pfn; > * via a driver, and never indicated in the firmware-provided memory map as > * system RAM. This corresponds to IORESOURCE_SYSRAM_DRIVER_MANAGED in the > * kernel resource tree. > - * @MEMBLOCK_RSRV_NOINIT: memory region for which struct pages are > - * not initialized (only for reserved regions). > + * @MEMBLOCK_RSRV_NOINIT: memory region for which struct pages don't have > + * PG_Reserved set and are completely not initialized when > + * %CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled (only for reserved regions). > * @MEMBLOCK_RSRV_KERN: memory region that is reserved for kernel use, > * either explictitly with memblock_reserve_kern() or via memblock > * allocation APIs. All memblock allocations set this flag. > diff --git a/mm/memblock.c b/mm/memblock.c > index 154f1d73b61f..02de5ffb085b 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1091,13 +1091,15 @@ int __init_memblock memblock_clear_nomap(phys_addr_t base, phys_addr_t size) > > /** > * memblock_reserved_mark_noinit - Mark a reserved memory region with flag > - * MEMBLOCK_RSRV_NOINIT which results in the struct pages not being initialized > - * for this region. > + * MEMBLOCK_RSRV_NOINIT > + * > * @base: the base phys addr of the region > * @size: the size of the region > * > - * struct pages will not be initialized for reserved memory regions marked with > - * %MEMBLOCK_RSRV_NOINIT. > + * The struct pages for the reserved regions marked %MEMBLOCK_RSRV_NOINIT will > + * not have %PG_Reserved flag set. > + * When %CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled, setting this flags also > + * completly bypasses the initialization of struct pages for this region. s/completly/completely. I don't quite understand the interaction with PG_Reserved and why anybody using this function should care. So maybe you can rephrase in a way that is easier to digest, and rather focuses on what callers of this function are supposed to do vs. have the liberty of not doing? -- Cheers David / dhildenb