From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre-Louis Bossart Subject: Re: [PATCH 03/11] drm/i915: Stop pretending to mask/unmask LPE audio interrupts Date: Tue, 25 Apr 2017 19:27:32 -0500 Message-ID: References: <20170425202730.1384-1-ville.syrjala@linux.intel.com> <20170425202730.1384-4-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9235A6E351 for ; Wed, 26 Apr 2017 02:00:08 +0000 (UTC) In-Reply-To: <20170425202730.1384-4-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org Cc: Takashi Iwai , alsa-devel@alsa-project.org List-Id: intel-gfx@lists.freedesktop.org T24gNC8yNS8xNyAzOjI3IFBNLCB2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbSB3cm90ZToK PiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ Cj4gdmx2X2Rpc3BsYXlfaXJxX3Bvc3RpbnN0YWxsKCkgZW5hYmxlcyB0aGUgTFBFIGF1ZGlvIGlu dGVycnVwdHMKPiByZWdhcmRsZXNzIG9mIHdoZXRoZXIgdGhlIExQRSBhdWRpbyBpcnEgY2hpcCBo YXMgbWFza2VkL3VubWFza2VkCj4gdGhlbS4gQWxzbyB0aGUgaXJxY2hpcCBtYXNraW5nL3VubWFz a2luZyBkb2Vzbid0IGNvbnNpZGVyIHRoZSBzdGF0ZQo+IG9mIHRoZSBkaXNwbGF5IHBvd2VyIHdl bGwgb3IgdGhlIGRldmljZSwgYW5kIGhlbmNlIGp1c3QgbGVhZHMgdG8KPiBkbWVzZyBzcGV3IHdo ZW4gaXQgdHJpZXMgdG8gYWNjZXNzIHRoZSBoYXJkd2FyZSB3aGlsZSBpdCdzIHBvd2VyZWQKPiBk b3duLgo+Cj4gSWYgdGhlIGN1cnJlbnQgd2F5IHdvcmtzLCB0aGVuIHdlIGRvbid0IG5lZWQgdG8g ZG8gYW55dGhpbmcgaW4gdGhlCj4gbWFzay91bm1hc2sgaG9va3MuIElmIGl0IGRvZXNuJ3Qgd29y aywgd2VsbCwgdGhlbiB3ZSdkIG5lZWQgdG8gcHJvcGVybHkKPiB0cmFjayB3aGV0aGVyIHRoZSBp cnFjaGlwIGhhcyBtYXNrZWQvdW5tYXNrZWQgdGhlIGludGVycnVwdHMgd2hlbgo+IHdlIGVuYWJs ZSBkaXNwbGF5IGludGVycnVwdHMuIEFuZCB0aGUgbWFzay91bm1hc2sgaG9va3Mgd291bGQgbmVl ZAo+IHRvIGNoZWNrIHdoZXRoZXIgZGlzcGxheSBpbnRlcnJ1cHRzIGFyZSBldmVuIGVuYWJsZWQg YmVmb3JlIGZyb2JiaW5nCj4gd2l0aCBoZSByZWdpc3RlcnMuCj4KPiBTbyBsZXQncyBqdXN0IGFz c3VtZSB0aGUgY3VycmVudCB3YXkgd29ya3MgYW5kIG5ldXRlciB0aGUgbWFzay91bm1hc2sKPiBo b29rcy4gQWxzbyBjbGVhbiB1cCB2bHZfZGlzcGxheV9pcnFfcG9zdGluc3RhbGwoKSBhIGJpdCBh bmQgc3RvcAo+IGl0IGZyb20gdHJ5aW5nIHRvIHVubWFzay9lbmFibGUgdGhlIExQRSBDIGludGVy cnVwdCBvbiBWTFYgc2luY2UgaXQKPiBkb2Vzbid0IGV4aXN0LgoKTm8gb2JqZWN0aW9ucywgSSBh c3N1bWVkIHRoYXQgd2UgZGlkIHdhbnQgdG8gdXBkYXRlIFZMVl9JTVIgYW5kIFZMVl9JSVIgCmlu IHRoZSBtYXNrL3VubWFzaywgdGhhdCB3YXMgdGhlIGluaXRpYWwgcmVjb21tZW5kYXRpb24gSUlS QwoKVGhlcmUgd2FzIGFsc28gYSBjb21tZW50IHdoZXJlIHdlIHJlbW92ZWQgYWxsIHRlc3RzIGlu IAp2bHZfZGlzcGxheV9pcnFfcG9zdGluc3RhbGw6CgogPj4gKwkJaWYgKElTX0xQRV9BVURJT19F TkFCTEVEKGRldl9wcml2KSkKID4+ICsJCQlpZiAoSVNfTFBFX0FVRElPX0lSUV9WQUxJRChkZXZf cHJpdikpCiA+CiA+SSB0aGluayBib3RoIG9mIHRoZXNlIGNoZWNrcyBjYW4gYmUgcmVtb3ZlZC4g V2Ugd29uJ3QgdW5tYXNrIHRoZQogPmludGVycnVwdHMgdW5sZXNzIGxwZSBpcyBlbmFibGVkLCBz byB0aGUgSUlSIGJpdHMgd2lsbCBuZXZlciBiZSBzZXQgaW4KID50aGF0IGNhc2UuCgoKCgo+Cj4g Q2M6IFRha2FzaGkgSXdhaSA8dGl3YWlAc3VzZS5kZT4KPiBDYzogUGllcnJlLUxvdWlzIEJvc3Nh cnQgPHBpZXJyZS1sb3Vpcy5ib3NzYXJ0QGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5 OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jICAgICAgICB8IDE1ICsrKysrKy0tLS0t LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xwZV9hdWRpby5jIHwgMzYgLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDYgaW5zZXJ0 aW9ucygrKSwgNDUgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9pcnEuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiBpbmRl eCBmZDk3ZmUwMGNkMGQuLjE5MGY2YWE1ZDE1ZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2lycS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEu Ywo+IEBAIC0yOTUzLDcgKzI5NTMsNiBAQCBzdGF0aWMgdm9pZCB2bHZfZGlzcGxheV9pcnFfcG9z dGluc3RhbGwoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJdTMyIHBpcGVz dGF0X21hc2s7Cj4gIAl1MzIgZW5hYmxlX21hc2s7Cj4gIAllbnVtIHBpcGUgcGlwZTsKPiAtCXUz MiB2YWw7Cj4KPiAgCXBpcGVzdGF0X21hc2sgPSBQTEFORV9GTElQX0RPTkVfSU5UX1NUQVRVU19W TFYgfAo+ICAJCQlQSVBFX0NSQ19ET05FX0lOVEVSUlVQVF9TVEFUVVM7Cj4gQEAgLTI5NjQsMTgg KzI5NjMsMTYgQEAgc3RhdGljIHZvaWQgdmx2X2Rpc3BsYXlfaXJxX3Bvc3RpbnN0YWxsKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPgo+ICAJZW5hYmxlX21hc2sgPSBJOTE1X0RJ U1BMQVlfUE9SVF9JTlRFUlJVUFQgfAo+ICAJCUk5MTVfRElTUExBWV9QSVBFX0FfRVZFTlRfSU5U RVJSVVBUIHwKPiAtCQlJOTE1X0RJU1BMQVlfUElQRV9CX0VWRU5UX0lOVEVSUlVQVDsKPiArCQlJ OTE1X0RJU1BMQVlfUElQRV9CX0VWRU5UX0lOVEVSUlVQVCB8Cj4gKwkJSTkxNV9MUEVfUElQRV9B X0lOVEVSUlVQVCB8Cj4gKwkJSTkxNV9MUEVfUElQRV9CX0lOVEVSUlVQVDsKPiArCj4gIAlpZiAo SVNfQ0hFUlJZVklFVyhkZXZfcHJpdikpCj4gLQkJZW5hYmxlX21hc2sgfD0gSTkxNV9ESVNQTEFZ X1BJUEVfQ19FVkVOVF9JTlRFUlJVUFQ7Cj4gKwkJZW5hYmxlX21hc2sgfD0gSTkxNV9ESVNQTEFZ X1BJUEVfQ19FVkVOVF9JTlRFUlJVUFQgfAo+ICsJCQlJOTE1X0xQRV9QSVBFX0NfSU5URVJSVVBU Owo+Cj4gIAlXQVJOX09OKGRldl9wcml2LT5pcnFfbWFzayAhPSB+MCk7Cj4KPiAtCXZhbCA9IChJ OTE1X0xQRV9QSVBFX0FfSU5URVJSVVBUIHwKPiAtCQlJOTE1X0xQRV9QSVBFX0JfSU5URVJSVVBU IHwKPiAtCQlJOTE1X0xQRV9QSVBFX0NfSU5URVJSVVBUKTsKPiAtCj4gLQllbmFibGVfbWFzayB8 PSB2YWw7Cj4gLQo+ICAJZGV2X3ByaXYtPmlycV9tYXNrID0gfmVuYWJsZV9tYXNrOwo+Cj4gIAlH RU41X0lSUV9JTklUKFZMVl8sIGRldl9wcml2LT5pcnFfbWFzaywgZW5hYmxlX21hc2spOwo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scGVfYXVkaW8uYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2xwZV9hdWRpby5jCj4gaW5kZXggNjY4ZjAwNDgwZDk3Li4y OTJmZWRmMzBiMDAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHBl X2F1ZGlvLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scGVfYXVkaW8uYwo+ IEBAIC0xNDksNDQgKzE0OSwxMCBAQCBzdGF0aWMgdm9pZCBscGVfYXVkaW9fcGxhdGRldl9kZXN0 cm95KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPgo+ICBzdGF0aWMgdm9pZCBs cGVfYXVkaW9faXJxX3VubWFzayhzdHJ1Y3QgaXJxX2RhdGEgKmQpCj4gIHsKPiAtCXN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGQtPmNoaXBfZGF0YTsKPiAtCXVuc2lnbmVkIGxv bmcgaXJxZmxhZ3M7Cj4gLQl1MzIgdmFsID0gKEk5MTVfTFBFX1BJUEVfQV9JTlRFUlJVUFQgfAo+ IC0JCUk5MTVfTFBFX1BJUEVfQl9JTlRFUlJVUFQpOwo+IC0KPiAtCWlmIChJU19DSEVSUllWSUVX KGRldl9wcml2KSkKPiAtCQl2YWwgfD0gSTkxNV9MUEVfUElQRV9DX0lOVEVSUlVQVDsKPiAtCj4g LQlzcGluX2xvY2tfaXJxc2F2ZSgmZGV2X3ByaXYtPmlycV9sb2NrLCBpcnFmbGFncyk7Cj4gLQo+ IC0JZGV2X3ByaXYtPmlycV9tYXNrICY9IH52YWw7Cj4gLQlJOTE1X1dSSVRFKFZMVl9JSVIsIHZh bCk7Cj4gLQlJOTE1X1dSSVRFKFZMVl9JSVIsIHZhbCk7Cj4gLQlJOTE1X1dSSVRFKFZMVl9JTVIs IGRldl9wcml2LT5pcnFfbWFzayk7Cj4gLQlQT1NUSU5HX1JFQUQoVkxWX0lNUik7Cj4gLQo+IC0J c3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmZGV2X3ByaXYtPmlycV9sb2NrLCBpcnFmbGFncyk7Cj4g IH0KPgo+ICBzdGF0aWMgdm9pZCBscGVfYXVkaW9faXJxX21hc2soc3RydWN0IGlycV9kYXRhICpk KQo+ICB7Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkLT5jaGlwX2Rh dGE7Cj4gLQl1bnNpZ25lZCBsb25nIGlycWZsYWdzOwo+IC0JdTMyIHZhbCA9IChJOTE1X0xQRV9Q SVBFX0FfSU5URVJSVVBUIHwKPiAtCQlJOTE1X0xQRV9QSVBFX0JfSU5URVJSVVBUKTsKPiAtCj4g LQlpZiAoSVNfQ0hFUlJZVklFVyhkZXZfcHJpdikpCj4gLQkJdmFsIHw9IEk5MTVfTFBFX1BJUEVf Q19JTlRFUlJVUFQ7Cj4gLQo+IC0Jc3Bpbl9sb2NrX2lycXNhdmUoJmRldl9wcml2LT5pcnFfbG9j aywgaXJxZmxhZ3MpOwo+IC0KPiAtCWRldl9wcml2LT5pcnFfbWFzayB8PSB2YWw7Cj4gLQlJOTE1 X1dSSVRFKFZMVl9JTVIsIGRldl9wcml2LT5pcnFfbWFzayk7Cj4gLQlJOTE1X1dSSVRFKFZMVl9J SVIsIHZhbCk7Cj4gLQlJOTE1X1dSSVRFKFZMVl9JSVIsIHZhbCk7Cj4gLQlQT1NUSU5HX1JFQUQo VkxWX0lJUik7Cj4gLQo+IC0Jc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmZGV2X3ByaXYtPmlycV9s b2NrLCBpcnFmbGFncyk7Cj4gIH0KPgo+ICBzdGF0aWMgc3RydWN0IGlycV9jaGlwIGxwZV9hdWRp b19pcnFjaGlwID0gewo+IEBAIC0zMzAsOCArMjk2LDYgQEAgdm9pZCBpbnRlbF9scGVfYXVkaW9f dGVhcmRvd24oc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+Cj4gIAlkZXNjID0g aXJxX3RvX2Rlc2MoZGV2X3ByaXYtPmxwZV9hdWRpby5pcnEpOwo+Cj4gLQlscGVfYXVkaW9faXJx X21hc2soJmRlc2MtPmlycV9kYXRhKTsKPiAtCj4gIAlscGVfYXVkaW9fcGxhdGRldl9kZXN0cm95 KGRldl9wcml2KTsKPgo+ICAJaXJxX2ZyZWVfZGVzYyhkZXZfcHJpdi0+bHBlX2F1ZGlvLmlycSk7 Cj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=