Re: [Intel-gfx] [PATCH 01/11] drm/i915: Use sizeof(variable) instead sizeof(type)

Nautiyal, Ankit K
2022-11-03T05:30:15Z

Looks good to me.

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

On 10/26/2022 5:08 PM, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Use sizeof(variable) instead of sizeof(type) in the hopes of
> less chance of screwing things up.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_color.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c
> index 4bb113c39f4b..92cc43d5bad6 100644
> --- a/drivers/gpu/drm/i915/display/intel_color.c
> +++ b/drivers/gpu/drm/i915/display/intel_color.c
> @@ -565,7 +565,7 @@ create_linear_lut(struct drm_i915_private *i915, int lut_size)
> int i;
>
> blob = drm_property_create_blob(&i915->drm,
> - sizeof(struct drm_color_lut) * lut_size,
> + sizeof(lut[0]) * lut_size,
> NULL);
> if (IS_ERR(blob))
> return blob;
> @@ -1895,7 +1895,7 @@ static struct drm_property_blob *i9xx_read_lut_8(struct intel_crtc *crtc)
> int i;
>
> blob = drm_property_create_blob(&dev_priv->drm,
> - sizeof(struct drm_color_lut) * LEGACY_LUT_LENGTH,
> + sizeof(lut[0]) * LEGACY_LUT_LENGTH,
> NULL);
> if (IS_ERR(blob))
> return NULL;
> @@ -1930,7 +1930,7 @@ static struct drm_property_blob *i965_read_lut_10p6(struct intel_crtc *crtc)
> struct drm_color_lut *lut;
>
> blob = drm_property_create_blob(&dev_priv->drm,
> - sizeof(struct drm_color_lut) * lut_size,
> + sizeof(lut[0]) * lut_size,
> NULL);
> if (IS_ERR(blob))
> return NULL;
> @@ -1973,7 +1973,7 @@ static struct drm_property_blob *chv_read_cgm_gamma(struct intel_crtc *crtc)
> struct drm_color_lut *lut;
>
> blob = drm_property_create_blob(&dev_priv->drm,
> - sizeof(struct drm_color_lut) * lut_size,
> + sizeof(lut[0]) * lut_size,
> NULL);
> if (IS_ERR(blob))
> return NULL;
> @@ -2009,7 +2009,7 @@ static struct drm_property_blob *ilk_read_lut_8(struct intel_crtc *crtc)
> int i;
>
> blob = drm_property_create_blob(&dev_priv->drm,
> - sizeof(struct drm_color_lut) * LEGACY_LUT_LENGTH,
> + sizeof(lut[0]) * LEGACY_LUT_LENGTH,
> NULL);
> if (IS_ERR(blob))
> return NULL;
> @@ -2034,7 +2034,7 @@ static struct drm_property_blob *ilk_read_lut_10(struct intel_crtc *crtc)
> struct drm_color_lut *lut;
>
> blob = drm_property_create_blob(&dev_priv->drm,
> - sizeof(struct drm_color_lut) * lut_size,
> + sizeof(lut[0]) * lut_size,
> NULL);
> if (IS_ERR(blob))
> return NULL;
> @@ -2087,7 +2087,7 @@ static struct drm_property_blob *bdw_read_lut_10(struct intel_crtc *crtc,
> drm_WARN_ON(&dev_priv->drm, lut_size != hw_lut_size);
>
> blob = drm_property_create_blob(&dev_priv->drm,
> - sizeof(struct drm_color_lut) * lut_size,
> + sizeof(lut[0]) * lut_size,
> NULL);
> if (IS_ERR(blob))
> return NULL;
> @@ -2138,7 +2138,7 @@ icl_read_lut_multi_segment(struct intel_crtc *crtc)
> struct drm_color_lut *lut;
>
> blob = drm_property_create_blob(&dev_priv->drm,
> - sizeof(struct drm_color_lut) * lut_size,
> + sizeof(lut[0]) * lut_size,
> NULL);
> if (IS_ERR(blob))
> return NULL;