From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 04/43] drm/i915: Do a synchronous switch-to-kernel-context on idling Date: Thu, 7 Mar 2019 17:06:58 +0000 Message-ID: References: <20190306142517.22558-1-chris@chris-wilson.co.uk> <20190306142517.22558-5-chris@chris-wilson.co.uk> <155196537784.27405.13370733676669351992@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 219266E312 for ; Thu, 7 Mar 2019 17:07:01 +0000 (UTC) In-Reply-To: <155196537784.27405.13370733676669351992@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: matthew.auld@intel.com List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA3LzAzLzIwMTkgMTM6MjksIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTAzLTA3IDEzOjA3OjE4KQo+Pgo+PiBPbiAwNi8wMy8yMDE5IDE0OjI0 LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiArc3RhdGljIGJvb2wgc3dpdGNoX3RvX2tlcm5lbF9j b250ZXh0X3N5bmMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4+PiArewo+Pj4gKyAg ICAgaWYgKGk5MTVfZ2VtX3N3aXRjaF90b19rZXJuZWxfY29udGV4dChpOTE1KSkKPj4+ICsgICAg ICAgICAgICAgcmV0dXJuIGZhbHNlOwo+Pgo+PiBJcyBpdCB3b3J0aCBzdGlsbCB0cnlpbmcgdG8g aWRsZSBpZiB0aGlzIGZhaWxzPyBTaW5jZSB0aGUgdGltZW91dCBpcwo+PiBzaG9ydCwgbWF5YmUg cmVzZXQgaW4gaWRsZSBzdGF0ZSBicmluZyBsZXNzIGhhdm9jIHRoYW4gbm90LiBJdCBjYW4gb25s eQo+PiBmYWlsIG9uIG1lbW9yeSBhbGxvY2F0aW9ucyBJIHRoaW5rLCBva2F5IGFuZCB0ZXJtaW5h bGx5IHdlZGdlZC4gSW4gd2hpY2gKPj4gY2FzZSBpdCBpcyBzdGlsbCBva2F5Lgo+IAo+IFRlcm1p bmFsbHkgd2VkZ2VkIGlzIGhhcmQgd2lyZWQgdG8gcmV0dXJuIDAgKHRoaXMsIHRoZSBuZXh0IHBh dGNoPykgc28KPiB0aGF0IHdlIGRvbid0IGJhaWwgZHVyaW5nIGk5MTVfZ2VtX3N1c3BlbmQoKSBm b3IgdGhpcyByZWFzb24uCj4gCj4gV2UgZG8gc3RpbGwgaWRsZSBpZiB0aGlzIGZhaWxzLCBhcyB3 ZSBtYXJrIHRoZSBkcml2ZXIvR1BVIGFzIHdlZGdlZC4KPiBQZXJmb3JtIGEgR1BVIHJlc2V0IHNv IHRoYXQgaXQgaG9wZWZ1bGx5IGlzbid0IHNob290aW5nIGtpdHRlbnMgYW55Cj4gbW9yZSwgYW5k IHB1bGwgYSBwaWxsb3cgb3ZlciBvdXIgaGVhZHMuCgpJIGRpZG4ndCBmaW5kIGEgcGF0aCB3aGlj aCBpZGxlcyBiZWZvcmUgd2VkZ2luZyBpZiAKc3dpdGNoX3RvX2tlcm5lbF9jb250ZXh0X3N5bmMg ZmFpbHMgZHVlIGZhaWxpbmcgCmk5MTVfZ2VtX3N3aXRjaF90b19rZXJuZWxfY29udGV4dC4gV2hl cmUgaXMgaXQ/CgpJdCBpcyBhIG1pbm9yIGNvbmNlcm4gZG9uJ3QgZ2V0IG1lIHdyb25nLiBJdCBp cyB1bmxpa2VseSB0byBmYWlsIGxpa2UgCnRoaXMuIEkgd2FzIHNpbXBseSB0aGlua2luZyB3aHkg bm90IHRyeSBhbmQgd2FpdCBmb3IgdGhlIGN1cnJlbnQgd29yayB0byAKZmluaXNoIGJlZm9yZSBz dXNwZW5kaW5nIGluIHRoaXMgY2FzZS4gTWlnaHQgYmUgYSBiZXR0ZXIgZXhwZXJpZW5jZSAKYWZ0 ZXIgcmVzdW1lLgoKPiBUaGF0J3MgcHJldHR5IG11Y2ggb3VyIGFuc3dlciBpbiBldmVyeSBjYXNl LCB3ZWRnZSBhbmQgaG9wZSB0aGUgdXNlcnMgZ28KPiBhd2F5Lgo+IAo+Pj4gKwo+Pj4gKyAgICAg aWYgKGk5MTVfZ2VtX3dhaXRfZm9yX2lkbGUoaTkxNSwKPj4+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIEk5MTVfV0FJVF9MT0NLRUQgfAo+Pj4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgSTkxNV9XQUlUX0ZPUl9JRExFX0JPT1NULAo+Pj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgSFogLyAxMCkpCj4+Cj4+IFlvdSdsbCBwcmVzdW1hYmx5IGNoYW5n ZSBIWiAvIDEwIHRvIHRoYXQgbmV3IG1hY3JvLgo+IAo+IFl1cC4KPiAKPj4+ICAgIHN0YXRpYyB2 b2lkCj4+PiAgICBpOTE1X2dlbV9pZGxlX3dvcmtfaGFuZGxlcihzdHJ1Y3Qgd29ya19zdHJ1Y3Qg KndvcmspCj4+PiAgICB7Cj4+PiAtICAgICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYgPQo+Pj4gLSAgICAgICAgICAgICBjb250YWluZXJfb2Yod29yaywgdHlwZW9mKCpkZXZfcHJp diksIGd0LmlkbGVfd29yay53b3JrKTsKPj4+ICsgICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICppOTE1ID0KPj4+ICsgICAgICAgICAgICAgY29udGFpbmVyX29mKHdvcmssIHR5cGVvZigqaTkx NSksIGd0LmlkbGVfd29yay53b3JrKTsKPj4+ICsgICAgIHR5cGVvZihpOTE1LT5ndCkgKmd0ID0g Jmk5MTUtPmd0Owo+Pgo+PiBJIGFtIHJlYWxseSBub3Qgc3VyZSBhYm91dCB0aGUgdHlwZW9mIGlk aW9tIGluIG5vcm1hbCBDIGNvZGUuIDooIEl0Cj4+IHNhdmVzIGEgbGl0dGxlIGJpdCBvZiB0eXBp bmcsIGFuZCBhIGxpdHRsZSBiaXQgb2YgY2h1cm4gaWYgdHlwZSBuYW1lCj4+IGNoYW5nZXMsIGJ1 dCBqdXN0IGZlZWxzIHdlaXJkIHRvIHVzZSBpdCBzb21ld2hlcmUgYW5kIHNvbWV3aGVyZSBub3Qu Cj4gCj4gQnV0IHRoZW4gd2UgaGF2ZSB0byBuYW1lIHRoaW5nISBXZSdyZSBub3Qgc29sZCBvbiBn dDsgaXQgbWVhbnMgcXVpdGUgYQo+IGZldyBkaWZmZXJlbnQgdGhpbmdzIGFyb3VuZCB0aGUgYnNw ZWMuIFRoaXMgYml0IGlzIGFjdHVhbGx5IHBhcnQgdGhhdAo+IEknbSBlYXJtYXJraW5nIGZvciBp OTE1X2dlbSBpdHNlbGYgKGhpZ2ggbGV2ZWwgaWRsZS9wb3dlci91c2VyIG1hbmFnZW1lbnQpCj4g YW5kIEknbSBjb250ZW1wbGF0aW5nIGk5MTVfZ3B1IGZvciB0aGUgYml0cyB0aGF0IGJlbmVhdGgg dXMgYnV0IHN0aWxsIGEKPiBtYW5hZ2VtZW50IGxheWVyIG92ZXIgaGFyZHdhcmUgKGFuZCBpbnRl bF9mb28gZm9yIHRoZSBiaXRzIHRoYXQgdGFsayB0bwo+IGhhcmR3YXJlLiBNYXliZSB0aGF0IHRv byB3aWxsIGNoYW5nZSBpZiB3ZSBjb21wbGV0ZWx5IHNwbGl0IG91dCBpbnRvCj4gZGlmZmVyZW50 IG1vZHVsZXMuKQoKU28geW91IGNvdWxkIGhhdmUgbGVmdCBpdCBhcyBpcyBmb3Igbm93IGFuZCBo YXZlIGEgc21hbGxlciBkaWZmLiBCdXQgCm9rYXkuLiBoYXZlIGl0IGlmIHlvdSBpbnNpc3QuCgo+ ICAgCj4+PiAgICAgICAgLyoKPj4+IC0gICAgICAqIE5ldyByZXF1ZXN0IHJldGlyZWQgYWZ0ZXIg dGhpcyB3b3JrIGhhbmRsZXIgc3RhcnRlZCwgZXh0ZW5kIGFjdGl2ZQo+Pj4gLSAgICAgICogcGVy aW9kIHVudGlsIG5leHQgaW5zdGFuY2Ugb2YgdGhlIHdvcmsuCj4+PiArICAgICAgKiBGbHVzaCBv dXQgdGhlIGxhc3QgdXNlciBjb250ZXh0LCBsZWF2aW5nIG9ubHkgdGhlIHBpbm5lZAo+Pj4gKyAg ICAgICoga2VybmVsIGNvbnRleHQgcmVzaWRlbnQuIFNob3VsZCBhbnl0aGluZyB1bmZvcnR1bmF0 ZSBoYXBwZW4KPj4+ICsgICAgICAqIHdoaWxlIHdlIGFyZSBpZGxlIChzdWNoIGFzIHRoZSBHUFUg YmVpbmcgcG93ZXIgY3ljbGVkKSwgbm8gdXNlcnMKPj4+ICsgICAgICAqIHdpbGwgYmUgaGFybWVk Lgo+Pj4gICAgICAgICAqLwo+Pj4gLSAgICAgaWYgKG5ld19yZXF1ZXN0c19zaW5jZV9sYXN0X3Jl dGlyZShkZXZfcHJpdikpCj4+PiAtICAgICAgICAgICAgIGdvdG8gb3V0X3VubG9jazsKPj4+IC0K Pj4+IC0gICAgIF9faTkxNV9nZW1fcGFyayhkZXZfcHJpdik7Cj4+PiArICAgICBpZiAoIWd0LT5h Y3RpdmVfcmVxdWVzdHMgJiYgIXdvcmtfcGVuZGluZygmZ3QtPmlkbGVfd29yay53b3JrKSkgewo+ Pgo+PiBDb3VsZCBoYXZlIGxlZnQgdGhlIG5ld19yZXF1ZXN0c19zaW5jZV9sYXN0X3JldGlyZSBm b3IgcmVhZGFiaWxpdHkuCj4gCj4gQXMgYWx3YXlzLCBpdCBjaGFuZ2VkIHNldmVyYWwgdGltZXMu IEkgYWN0dWFsbHkgdGhpbmsgY29uc2lkZXJpbmcgdGhhdAo+IHdlIHBsYXkgZ2FtZXMgd2l0aCBh Y3RpdmVfcmVxdWVzdHMsIGtlZXBpbmcgdGhhdCBpbiB0aGUgb3BlbiBpcwo+IGltcG9ydGFudC4g fm9+CgpPay4KCj4+Cj4+PiArICAgICAgICAgICAgICsrZ3QtPmFjdGl2ZV9yZXF1ZXN0czsgLyog ZG9uJ3QgcmVxdWV1ZSBpZGxlICovCj4+PiArCj4+PiArICAgICAgICAgICAgIGlmICghc3dpdGNo X3RvX2tlcm5lbF9jb250ZXh0X3N5bmMoaTkxNSkpIHsKPj4+ICsgICAgICAgICAgICAgICAgICAg ICBkZXZfZXJyKGk5MTUtPmRybS5kZXYsCj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAiRmFpbGVkIHRvIGlkbGUgZW5naW5lcywgZGVjbGFyaW5nIHdlZGdlZCFcbiIpOwo+Pj4gKyAg ICAgICAgICAgICAgICAgICAgIEdFTV9UUkFDRV9EVU1QKCk7Cj4+PiArICAgICAgICAgICAgICAg ICAgICAgaTkxNV9nZW1fc2V0X3dlZGdlZChpOTE1KTsKPj4+ICsgICAgICAgICAgICAgfQo+Pj4g KyAgICAgICAgICAgICBpOTE1X3JldGlyZV9yZXF1ZXN0cyhpOTE1KTsKPiAKPj4+IEBAIC0zMTI4 LDcgKzMxMjAsNiBAQCBpbnQgaTkxNV9nZW1fd2FpdF9mb3JfaWRsZShzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqaTkxNSwKPj4+ICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGVycjsKPj4+ ICAgIAo+Pj4gICAgICAgICAgICAgICAgaTkxNV9yZXRpcmVfcmVxdWVzdHMoaTkxNSk7Cj4+PiAt ICAgICAgICAgICAgIEdFTV9CVUdfT04oaTkxNS0+Z3QuYWN0aXZlX3JlcXVlc3RzKTsKPj4KPj4g QmVsb25ncyB0byB0aGlzIHBhdGNoPwo+IAo+IFllcy4gU2VlIHRoZSBhYm92ZSBjaHVuay4KClRo ZSBpZGxlIHdvcmsgaGFuZGxlcj8gTW9yZSBoYW5kIGhvbGRpbmcgcmVxdWlyZWQgSSdtIGFmcmFp ZC4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4