From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 29/39] drm/i915: Use b->irq_enable() as predicate for mock engine Date: Wed, 2 Jan 2019 15:21:21 +0000 Message-ID: References: <20190102094139.24014-1-chris@chris-wilson.co.uk> <20190102094139.24014-29-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F3286E009 for ; Wed, 2 Jan 2019 15:21:24 +0000 (UTC) In-Reply-To: <20190102094139.24014-29-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAyLzAxLzIwMTkgMDk6NDEsIENocmlzIFdpbHNvbiB3cm90ZToKClNvbWUgY29tbWl0IHRl eHQgcGxlYXNlLgoKPiBSZWZlcmVuY2VzOiBkNGNjY2ViMDU1OTEgKCJkcm0vaTkxNS9pY2w6IFJp bmdidWZmZXIgaW50ZXJydXB0IGhhbmRsaW5nIikKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxz b24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2JyZWFkY3J1bWJzLmMgICAgIHwgMzkgKysrKysrKystLS0tLS0tLS0tLS0KPiAg IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jICAgICAgIHwgMTEgKystLS0t Cj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmggICAgICB8ICAxIC0K PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9tb2NrX2VuZ2luZS5jIHwgIDEgLQo+ ICAgNCBmaWxlcyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAzMiBkZWxldGlvbnMoLSkKPiAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYnJlYWRjcnVtYnMuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2JyZWFkY3J1bWJzLmMKPiBpbmRleCA0ZWQ3MTA1 ZDdmZjUuLjdiNTE3YmY4MzUwNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9icmVhZGNydW1icy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYnJl YWRjcnVtYnMuYwo+IEBAIC0xNTgsNiArMTU4LDkgQEAgc3RhdGljIHZvaWQgaW50ZWxfYnJlYWRj cnVtYnNfZmFrZV9pcnEoc3RydWN0IHRpbWVyX2xpc3QgKnQpCj4gICAKPiAgIHN0YXRpYyB2b2lk IGlycV9lbmFibGUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgewo+ICsJaWYg KCFlbmdpbmUtPmlycV9lbmFibGUpCj4gKwkJcmV0dXJuOwo+ICsKPiAgIAkvKgo+ICAgCSAqIEZJ WE1FOiBJZGVhbGx5IHdlIHdhbnQgdGhpcyBvbiB0aGUgQVBJIGJvdW5kYXJ5LCBidXQgZm9yIHRo ZQo+ICAgCSAqIHNha2Ugb2YgdGVzdGluZyB3aXRoIG1vY2sgYnJlYWRjcnVtYnMgKG5vIEhXIHNv IHVuYWJsZSB0bwo+IEBAIC0xNjcsMjEgKzE3MCwyMCBAQCBzdGF0aWMgdm9pZCBpcnFfZW5hYmxl KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIAlHRU1fQlVHX09OKCFpbnRlbF9p cnFzX2VuYWJsZWQoZW5naW5lLT5pOTE1KSk7Cj4gICAKPiAgIAkvKiBDYWxsZXIgZGlzYWJsZXMg aW50ZXJydXB0cyAqLwo+IC0JaWYgKGVuZ2luZS0+aXJxX2VuYWJsZSkgewo+IC0JCXNwaW5fbG9j aygmZW5naW5lLT5pOTE1LT5pcnFfbG9jayk7Cj4gLQkJZW5naW5lLT5pcnFfZW5hYmxlKGVuZ2lu ZSk7Cj4gLQkJc3Bpbl91bmxvY2soJmVuZ2luZS0+aTkxNS0+aXJxX2xvY2spOwo+IC0JfQo+ICsJ c3Bpbl9sb2NrKCZlbmdpbmUtPmk5MTUtPmlycV9sb2NrKTsKPiArCWVuZ2luZS0+aXJxX2VuYWJs ZShlbmdpbmUpOwo+ICsJc3Bpbl91bmxvY2soJmVuZ2luZS0+aTkxNS0+aXJxX2xvY2spOwo+ICAg fQo+ICAgCj4gICBzdGF0aWMgdm9pZCBpcnFfZGlzYWJsZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2Nz ICplbmdpbmUpCj4gICB7Cj4gKwlpZiAoIWVuZ2luZS0+aXJxX2Rpc2FibGUpCj4gKwkJcmV0dXJu Owo+ICsKPiAgIAkvKiBDYWxsZXIgZGlzYWJsZXMgaW50ZXJydXB0cyAqLwo+IC0JaWYgKGVuZ2lu ZS0+aXJxX2Rpc2FibGUpIHsKPiAtCQlzcGluX2xvY2soJmVuZ2luZS0+aTkxNS0+aXJxX2xvY2sp Owo+IC0JCWVuZ2luZS0+aXJxX2Rpc2FibGUoZW5naW5lKTsKPiAtCQlzcGluX3VubG9jaygmZW5n aW5lLT5pOTE1LT5pcnFfbG9jayk7Cj4gLQl9Cj4gKwlzcGluX2xvY2soJmVuZ2luZS0+aTkxNS0+ aXJxX2xvY2spOwo+ICsJZW5naW5lLT5pcnFfZGlzYWJsZShlbmdpbmUpOwo+ICsJc3Bpbl91bmxv Y2soJmVuZ2luZS0+aTkxNS0+aXJxX2xvY2spOwo+ICAgfQoKTm9pc2UgaHVua3MuCgo+ICAgCj4g ICB2b2lkIF9faW50ZWxfZW5naW5lX2Rpc2FybV9icmVhZGNydW1icyhzdHJ1Y3QgaW50ZWxfZW5n aW5lX2NzICplbmdpbmUpCj4gQEAgLTI5MywyNSArMjk1LDE2IEBAIHN0YXRpYyBib29sIF9faW50 ZWxfYnJlYWRjcnVtYnNfZW5hYmxlX2lycShzdHJ1Y3QgaW50ZWxfYnJlYWRjcnVtYnMgKmIpCj4g ICAJaWYgKGItPmlycV9hcm1lZCkKPiAgIAkJcmV0dXJuIGZhbHNlOwo+ICAgCj4gLQkvKiBUaGUg YnJlYWRjcnVtYiBpcnEgd2lsbCBiZSBkaXNhcm1lZCBvbiB0aGUgaW50ZXJydXB0IGFmdGVyIHRo ZQo+ICsJLyoKPiArCSAqIFRoZSBicmVhZGNydW1iIGlycSB3aWxsIGJlIGRpc2FybWVkIG9uIHRo ZSBpbnRlcnJ1cHQgYWZ0ZXIgdGhlCj4gICAJICogd2FpdGVycyBhcmUgc2lnbmFsZWQuIFRoaXMg Z2l2ZXMgdXMgYSBzaW5nbGUgaW50ZXJydXB0IHdpbmRvdyBpbgo+ICAgCSAqIHdoaWNoIHdlIGNh biBhZGQgYSBuZXcgd2FpdGVyIGFuZCBhdm9pZCB0aGUgY29zdCBvZiByZS1lbmFibGluZwo+ICAg CSAqIHRoZSBpcnEuCj4gICAJICovCj4gICAJYi0+aXJxX2FybWVkID0gdHJ1ZTsKPiAgIAo+IC0J aWYgKEk5MTVfU0VMRlRFU1RfT05MWShiLT5tb2NrKSkgewo+IC0JCS8qIEZvciBvdXIgbW9jayBv YmplY3RzIHdlIHdhbnQgdG8gYXZvaWQgaW50ZXJhY3Rpb24KPiAtCQkgKiB3aXRoIHRoZSByZWFs IGhhcmR3YXJlICh3aGljaCBpcyBub3Qgc2V0IHVwKS4gU28KPiAtCQkgKiB3ZSBzaW1wbHkgcHJl dGVuZCB3ZSBoYXZlIGVuYWJsZWQgdGhlIHBvd2Vyd2VsbAo+IC0JCSAqIGFuZCB0aGUgaXJxLCBh bmQgbGVhdmUgaXQgdXAgdG8gdGhlIG1vY2sKPiAtCQkgKiBpbXBsZW1lbnRhdGlvbiB0byBjYWxs IGludGVsX2VuZ2luZV93YWtldXAoKQo+IC0JCSAqIGl0c2VsZiB3aGVuIGl0IHdhbnRzIHRvIHNp bXVsYXRlIGEgdXNlciBpbnRlcnJ1cHQsCj4gLQkJICovCj4gLQkJcmV0dXJuIHRydWU7Cj4gLQl9 Cj4gLQo+IC0JLyogU2luY2Ugd2UgYXJlIHdhaXRpbmcgb24gYSByZXF1ZXN0LCB0aGUgR1BVIHNo b3VsZCBiZSBidXN5Cj4gKwkvKgo+ICsJICogU2luY2Ugd2UgYXJlIHdhaXRpbmcgb24gYSByZXF1 ZXN0LCB0aGUgR1BVIHNob3VsZCBiZSBidXN5Cj4gICAJICogYW5kIHNob3VsZCBoYXZlIGl0cyBv d24gcnBtIHJlZmVyZW5jZS4gVGhpcyBpcyB0cmFja2VkCj4gICAJICogYnkgaTkxNS0+Z3QuYXdh a2UsIHdlIGNhbiBmb3JnbyBob2xkaW5nIG91ciBvd24gd2FrcmVmCj4gICAJICogZm9yIHRoZSBp bnRlcnJ1cHQgYXMgYmVmb3JlIGk5MTUtPmd0LmF3YWtlIGlzIHJlbGVhc2VkICh3aGVuCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPiBpbmRleCAzNjE3NzU0NmY2OGIuLjdi ODBhMDg3Y2MzMiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdp bmVfY3MuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jCj4g QEAgLTkxNyw2ICs5MTcsOSBAQCBzdGF0aWMgYm9vbCByaW5nX2lzX2lkbGUoc3RydWN0IGludGVs X2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgCWludGVsX3dha2VyZWZfdCB3YWtlcmVmOwo+ICAgCWJv b2wgaWRsZSA9IHRydWU7Cj4gICAKPiArCWlmIChJOTE1X1NFTEZURVNUX09OTFkoIWVuZ2luZS0+ bW1pb19iYXNlKSkKPiArCQlyZXR1cm4gdHJ1ZTsKClNlZW1zIHRvIG1ha2Ugc2Vuc2UsIGJ1dCBz aG91bGRuJ3QgdGhlIHBhdGNoIHRpdGxlIGJlICJVc2UgCmVuZ2luZS0+bW1pb19iYXNlIGFzIHBy ZWRpY2F0ZSBmb3IgbW9jayBlbmdpbmUgaHcgYWNjZXNzIj8KClJlZ2FyZHMsCgpUdnJ0a28KCj4g Kwo+ICAgCS8qIElmIHRoZSB3aG9sZSBkZXZpY2UgaXMgYXNsZWVwLCB0aGUgZW5naW5lIG11c3Qg YmUgaWRsZSAqLwo+ICAgCXdha2VyZWYgPSBpbnRlbF9ydW50aW1lX3BtX2dldF9pZl9pbl91c2Uo ZGV2X3ByaXYpOwo+ICAgCWlmICghd2FrZXJlZikKPiBAQCAtOTU1LDkgKzk1OCw2IEBAIGJvb2wg aW50ZWxfZW5naW5lX2lzX2lkbGUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAg CWlmICghaW50ZWxfZW5naW5lX3NpZ25hbGVkKGVuZ2luZSwgaW50ZWxfZW5naW5lX2xhc3Rfc3Vi bWl0KGVuZ2luZSkpKQo+ICAgCQlyZXR1cm4gZmFsc2U7Cj4gICAKPiAtCWlmIChJOTE1X1NFTEZU RVNUX09OTFkoZW5naW5lLT5icmVhZGNydW1icy5tb2NrKSkKPiAtCQlyZXR1cm4gdHJ1ZTsKPiAt Cj4gICAJLyogV2FpdGluZyB0byBkcmFpbiBFTFNQPyAqLwo+ICAgCWlmIChSRUFEX09OQ0UoZW5n aW5lLT5leGVjbGlzdHMuYWN0aXZlKSkgewo+ICAgCQlzdHJ1Y3QgdGFza2xldF9zdHJ1Y3QgKnQg PSAmZW5naW5lLT5leGVjbGlzdHMudGFza2xldDsKPiBAQCAtOTgzLDEwICs5ODMsNyBAQCBib29s IGludGVsX2VuZ2luZV9pc19pZGxlKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAg IAkJcmV0dXJuIGZhbHNlOwo+ICAgCj4gICAJLyogUmluZyBzdG9wcGVkPyAqLwo+IC0JaWYgKCFy aW5nX2lzX2lkbGUoZW5naW5lKSkKPiAtCQlyZXR1cm4gZmFsc2U7Cj4gLQo+IC0JcmV0dXJuIHRy dWU7Cj4gKwlyZXR1cm4gcmluZ19pc19pZGxlKGVuZ2luZSk7Cj4gICB9Cj4gICAKPiAgIGJvb2wg aW50ZWxfZW5naW5lc19hcmVfaWRsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaCBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+IGluZGV4IGJlZGIyNWQy NzQ2OS4uNDUyYzEzZjNkZGVkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3JpbmdidWZmZXIuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Jpbmdi dWZmZXIuaAo+IEBAIC0zOTcsNyArMzk3LDYgQEAgc3RydWN0IGludGVsX2VuZ2luZV9jcyB7Cj4g ICAJCXVuc2lnbmVkIGludCBpcnFfY291bnQ7Cj4gICAKPiAgIAkJYm9vbCBpcnFfYXJtZWQgOiAx Owo+IC0JCUk5MTVfU0VMRlRFU1RfREVDTEFSRShib29sIG1vY2sgOiAxKTsKPiAgIAl9IGJyZWFk Y3J1bWJzOwo+ICAgCj4gICAJc3RydWN0IHsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvc2VsZnRlc3RzL21vY2tfZW5naW5lLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxm dGVzdHMvbW9ja19lbmdpbmUuYwo+IGluZGV4IDUwZTFhMGIxYWY3ZS4uOWZlNWIyYzhmOGQ0IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9tb2NrX2VuZ2luZS5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL21vY2tfZW5naW5lLmMKPiBA QCAtMjAxLDcgKzIwMSw2IEBAIHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKm1vY2tfZW5naW5lKHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+ICAgCWk5MTVfdGltZWxpbmVfc2V0X3N1YmNs YXNzKCZlbmdpbmUtPmJhc2UudGltZWxpbmUsIFRJTUVMSU5FX0VOR0lORSk7Cj4gICAKPiAgIAlp bnRlbF9lbmdpbmVfaW5pdF9icmVhZGNydW1icygmZW5naW5lLT5iYXNlKTsKPiAtCWVuZ2luZS0+ YmFzZS5icmVhZGNydW1icy5tb2NrID0gdHJ1ZTsgLyogcHJldmVudCB0b3VjaGluZyBIVyBmb3Ig aXJxcyAqLwo+ICAgCj4gICAJLyogZmFrZSBodyBxdWV1ZSAqLwo+ICAgCXNwaW5fbG9ja19pbml0 KCZlbmdpbmUtPmh3X2xvY2spOwo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK