From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [RESEND PATCH 1/5] drm/i915/backlight: Restore backlight on resume, v2. Date: Wed, 2 Jan 2019 11:14:58 +0100 Message-ID: References: <20181217095024.2340-1-maarten.lankhorst@linux.intel.com> <871s62vu5y.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C9EC6E473 for ; Wed, 2 Jan 2019 10:15:01 +0000 (UTC) In-Reply-To: <871s62vu5y.fsf@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , intel-gfx@lists.freedesktop.org Cc: Hans de Goede , Tolga Cakir , Basil Eric Rabi List-Id: intel-gfx@lists.freedesktop.org T3AgMjgtMTItMjAxOCBvbSAxMToxMCBzY2hyZWVmIEphbmkgTmlrdWxhOgo+IE9uIE1vbiwgMTcg RGVjIDIwMTgsIE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRl bC5jb20+IHdyb3RlOgo+PiBSZXN0b3JlIG91ciBzYXZlZCB2YWx1ZXMgZm9yIGJhY2tsaWdodC4g VGhpcyB3YXkgZXZlbiB3aXRoIGZhc3RzZXQgb24KPj4gUzQgcmVzdW1lIHdlIHdpbGwgY29ycmVj dGx5IHJlc3RvcmUgdGhlIGJhY2tsaWdodCB0byB0aGUgYWN0aXZlIHZhbHVlcy4KPiBJIHRoaW5r IHRoaXMgaXMgYSBub24tdHJpdmlhbCBjb21taXQgdGhhdCByZXF1aXJlcyBtb3JlIGV4cGxhbmF0 aW9uIGluCj4gdGhlIGNvbW1pdCBtZXNzYWdlIGFuZCBjb21tZW50cy4KPgo+IFdoYXQgZG9lcyB0 aGlzIGRvIGZvciBub24tZmFzdHNldCByZXN1bWU/IEl0IHNlZW1zIHRvIG1lIHRoaXMKPiBlbmFi bGVzL2Rpc2FibGVzIGJhY2tsaWdodCB0d2ljZSBpbiB0aGF0IGNhc2UuCj4KPiBUaGlzIGRvZXNu J3QgdGFrZSBwYW5lbCBwb3dlciBzZXF1ZW5jaW5nIGludG8gYWNjb3VudCBhdCBhbGwuIFlvdSBj YW4ndAo+IGp1c3QgZ28gYWhlYWQgYW5kIGVuYWJsZSB0aGUgUFdNIHdpdGggbm8gY29uc2lkZXJh dGlvbiBvZiBob3cgdGhhdCBpcwo+IGZlZCB0byB0aGUgcGFuZWwuIFRoYXQgaW4gdHVybiBpcyBl bmNvZGVyIGNvZGUsIHNvIEknbSBub3Qgc3VyZSBob3cgdGhhdAo+IGNvdWxkIGJlIGJvbHRlZCBv biBoZXJlLgo+Cj4gU28gSSdtIGFmcmFpZCBJJ20gbm90IGNvbnZpbmNlZCB0aGlzIHdpbGwgd29y ay4KCk5laXRoZXIsIEkndmUgc2VlbiBhIHZlcnkgbmljZSBlbmNvZGVyIHVwZGF0ZV9waXBlIGhv b2sgZm9yIGZhc3RzZXQuCgpJIHRoaW5rIHVzaW5nIHRoaXMgZm9yIFM0IHJlc3VtZSB3b3VsZCBz b2x2ZSB0aGUgaXNzdWUuCgpodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzEwNzM4 ODc5LwoKPiBPbmUgbW9yZSBkZXRhaWwgaW4tbGluZSBiZWxvdy4KPgo+PiBDaGFuZ2VzIHNpbmNl IHYxOgo+PiAtIENhbGwgZW5hYmxlX2JhY2tsaWdodCgpIHdoZW4gYmFja2xpZ2h0LmxldmVsIGlz IHNldC4gT24gc3VzcGVuZAo+PiAgIGJhY2tsaWdodC5lbmFibGVkIGlzIGFsd2F5cyBjbGVhcmVk LCB0aGlzIG1ha2VzIGl0IG5vdCBhIGdvb2QKPj4gICBpbmRpY2F0b3IuIEFsc28gY2hlY2sgZm9y IGNydGMtPnN0YXRlLT5hY3RpdmUuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hv cnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4+IENjOiBUb2xnYSBDYWtp ciA8Y2V2ZWxuZXRAZ21haWwuY29tPgo+PiBDYzogQmFzaWwgRXJpYyBSYWJpIDxlcmljYmFzaWwu cmFiaUBnbWFpbC5jb20+Cj4+IENjOiBIYW5zIGRlIEdvZWRlIDxqd3JkZWdvZWRlQGZlZG9yYXBy b2plY3Qub3JnPgo+PiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4Lmlu dGVsLmNvbT4KPj4gUmVwb3J0ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jIHwgIDIgKysKPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAgICB8 ICAxICsKPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMgICB8IDMwICsrKysr KysrKysrKysrKysrKysrKysrKysrKysKPj4gIDMgZmlsZXMgY2hhbmdlZCwgMzMgaW5zZXJ0aW9u cygrKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+IGluZGV4IDJjM2Yz ZjY4ZDUwNi4uODZlN2IxNDVmZDk4IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCj4+IEBAIC0xNTg4Nyw3ICsxNTg4Nyw5IEBAIHZvaWQgaW50ZWxfZGlzcGxheV9yZXN1 bWUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPj4gIAlpZiAoIXJldCkKPj4gIAkJcmV0ID0gX19p bnRlbF9kaXNwbGF5X3Jlc3VtZShkZXYsIHN0YXRlLCAmY3R4KTsKPj4gIAo+PiArCWludGVsX3Bh bmVsX3Jlc3RvcmVfYmFja2xpZ2h0KGRldl9wcml2KTsKPj4gIAlpbnRlbF9lbmFibGVfaXBjKGRl dl9wcml2KTsKPj4gKwo+PiAgCWRybV9tb2Rlc2V0X2Ryb3BfbG9ja3MoJmN0eCk7Cj4+ICAJZHJt X21vZGVzZXRfYWNxdWlyZV9maW5pKCZjdHgpOwo+PiAgCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Ry di5oCj4+IGluZGV4IGNiM2EwNTVmMThjOC4uYTA1NTE3NDJiY2Y0IDEwMDY0NAo+PiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcnYuaAo+PiBAQCAtMjAwMyw2ICsyMDAzLDcgQEAgaW50IGludGVsX3BhbmVs X2luaXQoc3RydWN0IGludGVsX3BhbmVsICpwYW5lbCwKPj4gIAkJICAgICBzdHJ1Y3QgZHJtX2Rp c3BsYXlfbW9kZSAqZml4ZWRfbW9kZSwKPj4gIAkJICAgICBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9k ZSAqZG93bmNsb2NrX21vZGUpOwo+PiAgdm9pZCBpbnRlbF9wYW5lbF9maW5pKHN0cnVjdCBpbnRl bF9wYW5lbCAqcGFuZWwpOwo+PiArdm9pZCBpbnRlbF9wYW5lbF9yZXN0b3JlX2JhY2tsaWdodChz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+PiAgdm9pZCBpbnRlbF9maXhlZF9w YW5lbF9tb2RlKGNvbnN0IHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICpmaXhlZF9tb2RlLAo+PiAg CQkJICAgIHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICphZGp1c3RlZF9tb2RlKTsKPj4gIHZvaWQg aW50ZWxfcGNoX3BhbmVsX2ZpdHRpbmcoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfcGFuZWwuYwo+PiBpbmRleCBlZTNlMDg0MmQ1NDIuLjc5OTI4NGZjZDU3 ZCAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwuYwo+PiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5jCj4+IEBAIC0xOTAzLDYgKzE5 MDMsMzYgQEAgaW50ZWxfcGFuZWxfaW5pdF9iYWNrbGlnaHRfZnVuY3Moc3RydWN0IGludGVsX3Bh bmVsICpwYW5lbCkKPj4gIAl9Cj4+ICB9Cj4+ICAKPj4gK3ZvaWQgaW50ZWxfcGFuZWxfcmVzdG9y ZV9iYWNrbGlnaHQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+PiArewo+PiAr CXN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvcjsKPj4gKwlzdHJ1Y3QgZHJtX2Nvbm5l Y3Rvcl9saXN0X2l0ZXIgY29ubl9pdGVyOwo+PiArCj4+ICsJLyogS2lsbCBhbGwgdGhlIHdvcmsg dGhhdCBtYXkgaGF2ZSBiZWVuIHF1ZXVlZCBieSBocGQuICovCj4+ICsJZHJtX2Nvbm5lY3Rvcl9s aXN0X2l0ZXJfYmVnaW4oJmRldl9wcml2LT5kcm0sICZjb25uX2l0ZXIpOwo+PiArCWZvcl9lYWNo X2ludGVsX2Nvbm5lY3Rvcl9pdGVyKGNvbm5lY3RvciwgJmNvbm5faXRlcikgewo+PiArCQlzdHJ1 Y3QgaW50ZWxfcGFuZWwgKnBhbmVsID0gJmNvbm5lY3Rvci0+cGFuZWw7Cj4+ICsJCWNvbnN0IHN0 cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpjb25uX3N0YXRlID0KPj4gKwkJCWNvbm5lY3Rvci0+ YmFzZS5zdGF0ZTsKPj4gKwo+PiArCQlpZiAoIXBhbmVsLT5iYWNrbGlnaHQucHJlc2VudCkKPj4g KwkJCWNvbnRpbnVlOwo+PiArCj4+ICsJCWlmIChwYW5lbC0+YmFja2xpZ2h0LmxldmVsICYmIGNv bm5fc3RhdGUtPmNydGMgJiYKPiBwYW5lbC0+YmFja2xpZ2h0LmxldmVsIGlzIG5vdCBuZWNlc3Nh cmlseSAwLWJhc2VkLCBpdCdzIGJldHdlZW4KPiBwYW5lbC0+YmFja2xpZ2h0LnttaW4sbWF4fS4K WWVhaCwgdGhpcyBwYXJ0IGNhbiBiZSByZW1vdmVkLgo+IEJSLAo+IEphbmkuCj4KPj4gKwkJICAg IGNvbm5fc3RhdGUtPmNydGMtPnN0YXRlLT5hY3RpdmUpIHsKPj4gKwkJCWNvbnN0IHN0cnVjdCBp bnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlID0KPj4gKwkJCQl0b19pbnRlbF9jcnRjX3N0YXRl KGNvbm5fc3RhdGUtPmNydGMtPnN0YXRlKTsKPj4gKwo+PiArCQkJaW50ZWxfcGFuZWxfZW5hYmxl X2JhY2tsaWdodChjcnRjX3N0YXRlLCBjb25uX3N0YXRlKTsKPj4gKwkJfSBlbHNlIHsKPj4gKwkJ CVdBUk4ocGFuZWwtPmJhY2tsaWdodC5lbmFibGVkLCAiQmFja2xpZ2h0IGVuYWJsZWQgd2l0aG91 dCBjcnRjXG4iKTsKPj4gKwo+PiArCQkJaW50ZWxfcGFuZWxfZGlzYWJsZV9iYWNrbGlnaHQoY29u bl9zdGF0ZSk7Cj4+ICsJCX0KPj4gKwl9Cj4+ICsJZHJtX2Nvbm5lY3Rvcl9saXN0X2l0ZXJfZW5k KCZjb25uX2l0ZXIpOwo+PiArfQo+PiArCj4+ICBpbnQgaW50ZWxfcGFuZWxfaW5pdChzdHJ1Y3Qg aW50ZWxfcGFuZWwgKnBhbmVsLAo+PiAgCQkgICAgIHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICpm aXhlZF9tb2RlLAo+PiAgCQkgICAgIHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICpkb3duY2xvY2tf bW9kZSkKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK