From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D91BFCD3436 for ; Fri, 8 May 2026 14:44:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3A24A10E5D9; Fri, 8 May 2026 14:44:28 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="LC18WKow"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by gabe.freedesktop.org (Postfix) with ESMTPS id 97E4C10F529; Fri, 8 May 2026 14:44:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778251466; x=1809787466; h=from:to:subject:in-reply-to:references:date:message-id: mime-version; bh=llKcWDyQQwOJLcf+/fCeb3mGeJkL43QCR3X4b8FHSyU=; b=LC18WKowY4pNbNCjOdgQdibExh177KuJ93mDg3m1aYEV/WqIV/z2w1yE VJvJzeXW0KBKlb64soLqIf4YjgV01MNDyATLU7MUhqwro8Hir7l77/n9T vF+NProGa27Kw6KkDFOqN2Vtlk9dFekzONtsLewmJdmqKhHTe81HcEDUg iN0Tbt6fEtntuDgp/en0WVtXJL6F9aBPCeObHVUPggn1CgESuwiP3kbxf 4zlXZxDzjwVG5lk/yiQhj2r4kmJfRju9gSoKDdgRO0Bm3BX89Eup8meAJ z26mN0ldzDs6Oa1Vu/qtecAUEkLuFs1QJdkc/nf5DLVjJPWcvNsuW+vyW A==; X-CSE-ConnectionGUID: 2S2SB0EtQLezlxMFlYttpA== X-CSE-MsgGUID: EddTrNuZRDiJ38PPVa6eQg== X-IronPort-AV: E=McAfee;i="6800,10657,11780"; a="96791430" X-IronPort-AV: E=Sophos;i="6.23,223,1770624000"; d="scan'208";a="96791430" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2026 07:44:26 -0700 X-CSE-ConnectionGUID: cdt2WdmMTCCMb1vQrZi8ag== X-CSE-MsgGUID: 2ReeKODBQwG5RyA/EZEAnA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,223,1770624000"; d="scan'208";a="233726667" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.244.40]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2026 07:44:24 -0700 From: Jani Nikula To: Imre Deak , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH 018/108] drm/i915/dp_link_training: Add helper to reset link recovery state In-Reply-To: <20260428125233.1664668-19-imre.deak@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260428125233.1664668-1-imre.deak@intel.com> <20260428125233.1664668-19-imre.deak@intel.com> Date: Fri, 08 May 2026 17:44:21 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 28 Apr 2026, Imre Deak wrote: > Add link_recovery_reset() to make it explicit when link recovery is no > longer needed and the recovery state can be cleared. > > This also prepares for replacing the sequential link training failure > counter with an enum in a follow-up change. > > Signed-off-by: Imre Deak > --- > .../drm/i915/display/intel_dp_link_training.c | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > index eb922dca69c5b..90bd1b0f1ab7d 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > @@ -1304,6 +1304,18 @@ link_recovery_mark_train_failure(struct intel_dp_link_training *link_training) > return link_recovery_autoretrain_allowed(link_training); > } > > +/** > + * link_recovery_reset - reset the link recovery state > + * @link_training: link training state > + * > + * Reset the link recovery state to indicate that no link recovery is > + * required. What's link recovery? Same as autoretrain? Different? It operates on the same variable as autoretrain. Confused. BR, Jani. > + */ > +static void link_recovery_reset(struct intel_dp_link_training *link_training) > +{ > + link_training->seq_train_failures = 0; > +} > + > /** > * intel_dp_stop_link_train - stop link training > * @intel_dp: DP struct > @@ -1868,7 +1880,7 @@ void intel_dp_start_link_train(struct intel_atomic_state *state, > link_training->force_train_failure--; > lt_dbg(intel_dp, DP_PHY_DPRX, "Forcing link training failure\n"); > } else if (passed) { > - link_training->seq_train_failures = 0; > + link_recovery_reset(link_training); > return; > } > > @@ -2538,7 +2550,7 @@ void intel_dp_link_training_debugfs_add(struct intel_connector *connector) > void intel_dp_link_training_reset(struct intel_dp_link_training *link_training) > { > link_training->retrain_disabled = false; > - link_training->seq_train_failures = 0; > + link_recovery_reset(link_training); > } > > /** -- Jani Nikula, Intel