From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/6] drm/i915: kicking rings stuck on semaphores considered harmful Date: Tue, 11 Oct 2011 16:51:28 +0100 Message-ID: References: <1318343954-14607-1-git-send-email-daniel.vetter@ffwll.ch> <1318343954-14607-2-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 9B6C19E9E2 for ; Tue, 11 Oct 2011 08:51:31 -0700 (PDT) In-Reply-To: <1318343954-14607-2-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Tue, 11 Oct 2011 16:39:10 +0200, Daniel Vetter wrote: > If our semaphore logic gets confused and we have a ring stuck waiting > for one, there's a decent chance it'll just execute garbage when being > kicked. Also, kicking the ring obscures the place where the error > first occured, making error_state decoding much harder. > > So drop this an let gpu reset handle this mess in a clean fashion. > > In contrast, kicking rings stuck on MI_WAIT is rather harmless, at > worst there'll be a bit of screen-flickering. There's also old > broken userspace out there which needs this as a work-around. > > Signed-off-by: Daniel Vetter Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre