From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/3] glamor: turn on glamor. Date: Fri, 11 Nov 2011 09:11:35 +0000 Message-ID: References: <1321000281-5097-1-git-send-email-zhigang.gong@linux.intel.com> <1321000281-5097-2-git-send-email-zhigang.gong@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id D91B39E77F for ; Fri, 11 Nov 2011 01:11:46 -0800 (PST) In-Reply-To: <1321000281-5097-2-git-send-email-zhigang.gong@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Zhigang Gong , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 11 Nov 2011 16:31:20 +0800, Zhigang Gong wrote: > @@ -965,6 +969,9 @@ void intel_uxa_block_handler(intel_screen_private *intel) > * framebuffer until significantly later. > */ > intel_flush_rendering(intel); > +#ifdef GLAMOR > + intel_glamor_block_handler(intel); > +#endif > } I suspect this is the wrong way around as we are not flushing the render cache of glamor's rendering to the scanout until the next block handler. In general, try to keep the #ifdef out of the body of the code. In this case, and others, make intel_glamor_block_handler() be a no-op if GLAMOR is not enabled. -Chris -- Chris Wilson, Intel Open Source Technology Centre