From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/2] dri: Add support for DRI2BufferStencil and DRI2BufferHiz Date: Sun, 05 Jun 2011 10:48:29 +0100 Message-ID: References: <1307232391-26973-1-git-send-email-chad@chad-versace.us> <1307232391-26973-3-git-send-email-chad@chad-versace.us> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id BA7E29ECFF for ; Sun, 5 Jun 2011 02:48:32 -0700 (PDT) In-Reply-To: <1307232391-26973-3-git-send-email-chad@chad-versace.us> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chad Versace , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sat, 4 Jun 2011 17:06:31 -0700, Chad Versace wrote: > Before this commit, if a client were to request a stencil or hiz buffer, then > I830DRI2CreateBuffer() allocated and returned an X-tiled buffer by > accident. (DRI2BufferStencil and DRI2BufferHiz were unintentionally caught > by the default case of a switch statement.) > > Now, I830DRI2CreateBuffer() correctly returns a Y-tiled buffer and handles > the stencil buffer as a special case due its quirky pitch requirements. Yeah, this really highlights how broken the ddx is by conflating Pixmaps and RenderBuffer attachments. However as a short-term feature addition, it looks fine. -Chris -- Chris Wilson, Intel Open Source Technology Centre