From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9A0CCD6E55 for ; Mon, 1 Jun 2026 15:39:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 865EC1134D9; Mon, 1 Jun 2026 15:39:00 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="PyMKU2lR"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 091E21134D9; Mon, 1 Jun 2026 15:39:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780328340; x=1811864340; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=mGRPxwXourr31tDVClLWGqgPyAcgKKcJcmEM5iddfDw=; b=PyMKU2lR6kHmb/37R3RU+mzE23nO8/E3OpASobQXUcqxkHzU0rHfNUur U3cKjAsTaE2hLHSpMsciSrCxw9kR9Xi99CGSIGd+gvF/Dwq0w1JFMSbhB r/7DyFE08Vpoe/wdC/FbaPyEyAyn4nlk6RbwAfcPQszRT1h2GOVPCCb52 vgX9Eua0ZMggcjj9bcWPuAY8ipaic9CCH7zt3SZs4ADAbs7zm884eqNUx ikFIBYlglVy7CPdJSO0BBrqjOzwGxdfosFgytbl4Jwu/FxhmGqYeCIWrj MUlVSI9w9NbrPQy1E18UkZKDiBrUS10fjD6hLowhS03mhtOKC5gWsW8gc Q==; X-CSE-ConnectionGUID: oPJtHnxRQkKbr8isZOw55g== X-CSE-MsgGUID: wI5QemV/Ra6WtEzypjs/VA== X-IronPort-AV: E=McAfee;i="6800,10657,11804"; a="81119564" X-IronPort-AV: E=Sophos;i="6.24,181,1774335600"; d="scan'208";a="81119564" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2026 08:38:59 -0700 X-CSE-ConnectionGUID: lEJQv2Q3TWa4cCxSUtpBsw== X-CSE-MsgGUID: t3ldZQUwTZuEa6SjkoO42Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,181,1774335600"; d="scan'208";a="243428652" Received: from amilburn-desk.amilburn-desk (HELO localhost) ([10.245.245.121]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2026 08:38:54 -0700 From: Jani Nikula To: Thomas Zimmermann , Dave Airlie , Simona Vetter Cc: Joonas Lahtinen , Tvrtko Ursulin , Rodrigo Vivi , Thomas Zimmermann , Maarten Lankhorst , Maxime Ripard , Matthew Brost , Thomas =?utf-8?Q?Hellstr=C3=B6m?= , Oded Gabbay , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dim-tools@lists.freedesktop.org Subject: Re: [PULL] drm-misc-fixes In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260529070009.GA313534@linux.fritz.box> Date: Mon, 01 Jun 2026 18:38:51 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 01 Jun 2026, Jani Nikula wrote: > On Fri, 29 May 2026, Thomas Zimmermann wrote: >> Rajat Gupta (1): >> drm: prevent integer overflows in dumb buffer creation helpers > > Looks like this commit 5ab62dd3687b ("drm: prevent integer overflows in > dumb buffer creation helpers") regressed in our CI, awaiting > confirmation. The IGT test kms_big_fb uses max width and height from GetResources, and i915 and xe use max_width 16384 and max_height 16384 in mode config. The regressing commit adds random hard limits not based on anything: + /* Reject unreasonable inputs early. Dumb buffers are for software + * rendering; nothing legitimate needs more than 8192x8192 at 32bpp. + * This prevents overflows in downstream alignment helpers. + */ + if (args->width >= 8192 || args->height >= 8192 || args->bpp > 32) + return -EINVAL; This is now in v7.1-rc6. Please revert ASAP. BR, Jani. > > No matter what, it's immediately suspect because AFAICT it was not > posted on the lists, and the commit doesn't have a Link: trailer > pointing at the patch. > > This is not how we're supposed to roll. What's going on? > > > BR, > Jani. -- Jani Nikula, Intel