From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Harrison Subject: Re: [igt-dev] [PATCH i-g-t 7/8] trace.pl: Basic preemption support Date: Wed, 18 Jul 2018 13:13:12 -0700 Message-ID: References: <20180718094514.5903-1-tvrtko.ursulin@linux.intel.com> <20180718094514.5903-8-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0376134848==" Return-path: In-Reply-To: <20180718094514.5903-8-tvrtko.ursulin@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , igt-dev@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org This is a multi-part message in MIME format. --===============0376134848== Content-Type: multipart/alternative; boundary="------------D61587B5B24B55D0A85AC99D" Content-Language: en-US This is a multi-part message in MIME format. --------------D61587B5B24B55D0A85AC99D Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 7/18/2018 2:45 AM, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Just forget about earlier request_in events. > > Signed-off-by: Tvrtko Ursulin > --- > scripts/trace.pl | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/scripts/trace.pl b/scripts/trace.pl > index 60d42865acbd..41bedeefb776 100755 > --- a/scripts/trace.pl > +++ b/scripts/trace.pl > @@ -408,7 +408,9 @@ while (<>) { > } elsif ($tp_name eq 'i915:i915_request_in:') { > my %req; > > - die if exists $db{$key}; > + # preemption > + delete $db{$key} if exists $db{$key}; > + > die unless exists $queue{$key}; > die unless exists $submit{$key}; > I've definitely r-b'd this one before too. And no changes so still... Reviewed-by: John Harrison --------------D61587B5B24B55D0A85AC99D Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit On 7/18/2018 2:45 AM, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Just forget about earlier request_in events.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 scripts/trace.pl | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/scripts/trace.pl b/scripts/trace.pl
index 60d42865acbd..41bedeefb776 100755
--- a/scripts/trace.pl
+++ b/scripts/trace.pl
@@ -408,7 +408,9 @@ while (<>) {
 	} elsif ($tp_name eq 'i915:i915_request_in:') {
 		my %req;
 
-		die if exists $db{$key};
+		# preemption
+		delete $db{$key} if exists $db{$key};
+
 		die unless exists $queue{$key};
 		die unless exists $submit{$key};

I've definitely r-b'd this one before too. And no changes so still...
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
--------------D61587B5B24B55D0A85AC99D-- --===============0376134848== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============0376134848==--