From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB7AAC4332F for ; Mon, 21 Nov 2022 11:55:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A2D1F10E2B0; Mon, 21 Nov 2022 11:55:53 +0000 (UTC) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6F46310E2B0 for ; Mon, 21 Nov 2022 11:55:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669031750; x=1700567750; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=WdoCgvroKp96oVvkj5Bcpp7x5UgsjRvqcFq5CrnPipQ=; b=B80bFHa5CNwmnQHpxJ8MsNGDq9ZI5axlybmTEA0w/xQlADpbxMLCxbZ/ 2WQq5m6rJSt3hkcE5qavfMmWbSCs7GMYwRU1xGhXA1DoMF6V04ZzsT0ib ufmCKq2FHVH0yRcmBY1m1Zer/qFaKUY4Fyp9MQFShqK8A5pSRAqon27O8 bg1xPG2/LSkqvliDaKDTug+CpixbxQApQGSmCRusIWooqGXvLKlHNEj1v Vllnj1YOufnvTQwmlPgQfPFv8dHkVKbVXgLwCtYmQxCUsNywELpBJ3lYP y4LwwMdGBFsg1Y5so7OU4HtRnZ44ny/WSVqkxE3Rf8BU+RWfg4qbJt1UG A==; X-IronPort-AV: E=McAfee;i="6500,9779,10537"; a="375685204" X-IronPort-AV: E=Sophos;i="5.96,181,1665471600"; d="scan'208";a="375685204" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2022 03:55:49 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10537"; a="673950827" X-IronPort-AV: E=Sophos;i="5.96,181,1665471600"; d="scan'208";a="673950827" Received: from slarkin-mobl.ger.corp.intel.com (HELO [10.213.201.194]) ([10.213.201.194]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2022 03:55:47 -0800 Message-ID: Date: Mon, 21 Nov 2022 11:55:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US To: "Winkler, Tomas" , "Usyskin, Alexander" , Jani Nikula , Joonas Lahtinen , "Vivi, Rodrigo" , David Airlie , Daniel Vetter References: <20221121092449.328674-1-alexander.usyskin@intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/gsc: Only initialize GSC in tile 0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "intel-gfx@lists.freedesktop.org" , "Lubart, Vitaly" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 21/11/2022 09:35, Winkler, Tomas wrote: >> >> From: José Roberto de Souza >> >> For multi-tile setups the GSC operational only on the tile 0. >> Skip GSC auxiliary device creation for all other tiles in GSC device init code. >> Initialize basic GSC fields and use the same path as HECI1 (HECI_PXP) device >> disable. >> >> Cc: Tomas Winkler >> Cc: Vitaly Lubart >> Signed-off-by: José Roberto de Souza >> Signed-off-by: Alexander Usyskin > > Acked-by: Tomas Winkler Feel free to upgrade to r-b so someone can merge it. :) >> --- >> V2: Move decision to skip initialization into GSC device init code. >> This initializes basic GSC fields and uses the same path >> as HECI1 (HECI_PXP) device disable. >> It is simpler and protects interrupt handler too. >> >> drivers/gpu/drm/i915/gt/intel_gsc.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/gt/intel_gsc.c >> b/drivers/gpu/drm/i915/gt/intel_gsc.c >> index 976fdf27e790..bcc3605158db 100644 >> --- a/drivers/gpu/drm/i915/gt/intel_gsc.c >> +++ b/drivers/gpu/drm/i915/gt/intel_gsc.c >> @@ -174,6 +174,14 @@ static void gsc_init_one(struct drm_i915_private >> *i915, struct intel_gsc *gsc, >> intf->irq = -1; >> intf->id = intf_id; >> >> + /* >> + * On the multi-tile setups the GSC is functional on the first tile only >> + */ >> + if (gsc_to_gt(gsc)->info.id != 0) { >> + drm_dbg(&i915->drm, "Not initializing gsc for remote >> tiles\n"); Is there any value of adding a log message for this? I don't immediately see that it is worth it, but your call. Regards, Tvrtko >> + return; >> + } >> + >> if (intf_id == 0 && !HAS_HECI_PXP(i915)) >> return; >> >> -- >> 2.34.1 >