From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 5/5] drm/i915: rewrite shmem_pread_slow to use copy_to_user Date: Sat, 17 Sep 2011 22:04:20 +0100 Message-ID: References: <1316285749-30130-1-git-send-email-daniel.vetter@ffwll.ch> <1316285749-30130-6-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 244349E77C for ; Sat, 17 Sep 2011 14:04:39 -0700 (PDT) In-Reply-To: <1316285749-30130-6-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Sat, 17 Sep 2011 20:55:49 +0200, Daniel Vetter wrote: > Like for shmem_pwrite_slow. The only difference is that because we > read data, we can leave the fetched cachelines in the cpu: In the case > that the object isn't in the cpu read domain anymore, the clflush for > the next cpu read domain invalidation will simply drop these > cachelines. > > slow_shmem_bit17_copy is now ununsed, so kill it. > > With this patch tests/gem_mmap_gtt now actually works. I have to ask the obvious question: does this have any impact on CPU pwrite performance? Bring on prefaulting ;-) -Chris -- Chris Wilson, Intel Open Source Technology Centre