From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 2/3] drm/i915: Rename HDMI register field
	definitions
Date: Fri, 14 Oct 2011 22:39:08 +0100
Message-ID: <e39f63$2akjtm@fmsmga002.fm.intel.com>
References: <1318510159-12913-1-git-send-email-przanoni@gmail.com>
	<1318627029-10311-1-git-send-email-przanoni@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
	by gabe.freedesktop.org (Postfix) with ESMTP id BE37D9ED2C
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 14 Oct 2011 14:39:17 -0700 (PDT)
In-Reply-To: <1318627029-10311-1-git-send-email-przanoni@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: przanoni@gmail.com, intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, 14 Oct 2011 18:17:09 -0300, przanoni@gmail.com wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> Also making the differences between HDMI{B,C,D} and SDVO registers for
> non-PCH, IBX and CPT more explicit.
> 
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

I'm a little more dubious over the value of this patch. The extra
information is nice, but the patch doesn't impact much upon the
readibility of the code. It seems like this should have the potential to
clarify quite a bit of the logic and make it more consistent, yet that
is not addressed here. Do you have plans to make use of the cleanup?
Does it catch any bugs?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre