Re: [Intel-gfx] [PATCH 26/26] dma-buf: nuke dma_resv_get_excl_unlocked

Daniel Vetter
2021-09-17T14:56:16Z

On Fri, Sep 17, 2021 at 02:35:13PM +0200, Christian König wrote:
> Heureka, that's finally not used any more.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> ---
> include/linux/dma-resv.h | 26 --------------------------
> 1 file changed, 26 deletions(-)
>
> diff --git a/include/linux/dma-resv.h b/include/linux/dma-resv.h
> index 8c968f8c9d33..f42ca254acb5 100644
> --- a/include/linux/dma-resv.h
> +++ b/include/linux/dma-resv.h
> @@ -423,32 +423,6 @@ dma_resv_excl_fence(struct dma_resv *obj)
> return rcu_dereference_check(obj->fence_excl, dma_resv_held(obj));
> }
>
> -/**
> - * dma_resv_get_excl_unlocked - get the reservation object's
> - * exclusive fence, without lock held.
> - * @obj: the reservation object
> - *
> - * If there is an exclusive fence, this atomically increments it's
> - * reference count and returns it.
> - *
> - * RETURNS
> - * The exclusive fence or NULL if none
> - */
> -static inline struct dma_fence *
> -dma_resv_get_excl_unlocked(struct dma_resv *obj)
> -{
> - struct dma_fence *fence;
> -
> - if (!rcu_access_pointer(obj->fence_excl))
> - return NULL;
> -
> - rcu_read_lock();
> - fence = dma_fence_get_rcu_safe(&obj->fence_excl);
> - rcu_read_unlock();
> -
> - return fence;
> -}
> -
> /**
> * dma_resv_shared_list - get the reservation object's shared fence list
> * @obj: the reservation object
> --
> 2.25.1
>

--
Daniel Vetter
Software Engineer, Intel Corporation