From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17FC3C54EBD for ; Fri, 13 Jan 2023 08:03:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A0D4210E9A5; Fri, 13 Jan 2023 08:03:15 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9D1E010E9A3 for ; Fri, 13 Jan 2023 08:03:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673596990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=11A68i/ujjvlvNOTfu4F5ZXcyPx1UEmLo0fXGnHQZCM=; b=fMBJiTWycdwHuq0qkh8vxiwrI8ev5QebDUv6qsJyxf99cc9JQpSwQ/jLD19SrIkNq+oJ4i +SRIz3L0EylSeLdzp1TLuKBi9Vh57KNP9BBmdhq9OWIt5zyBndZassuSbtEPEqUsaLBXwt Q/UZAvzNV8u86jwqhQxlAfbQg4ceLvc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-288-pXUsIYCYNeq-vekgb3vmag-1; Fri, 13 Jan 2023 03:03:08 -0500 X-MC-Unique: pXUsIYCYNeq-vekgb3vmag-1 Received: by mail-wr1-f69.google.com with SMTP id d27-20020adfa35b000000b002bc813ba677so2830054wrb.6 for ; Fri, 13 Jan 2023 00:03:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=11A68i/ujjvlvNOTfu4F5ZXcyPx1UEmLo0fXGnHQZCM=; b=MwCRjDI4bM7of834aCuhFupTrB/A63yGsjVjZNqKKtqTvkIX59vH7O6skAy+BEMxw/ aYPMkHiA7FiLw6X65efmGFixwenRYs5AXZCAX9AbxW8cWTtuuJtTtfVDc+kWlD/9GYZL ihI0XNTucZCoCg5XqPyBBnay6rCWjTJJvUPySRrps01sM1izxA50O/6mGT2fMyNgKwdj zY5hReTTC3LFvUSTrrG3PHRzqoxwMkTPfkkpv5LU4153zlCEhZvh4Gi93mvghrYFItZe o7Z4q3KEEP3q5IPli3RjpHsH0m0vP6QlgqRPW85awHBCk8aiHZ3cQhyQus5x+Rp3FPeq bydw== X-Gm-Message-State: AFqh2krDOK5AZtcHQBEZ7EzMVubEez1pMWM7sV8tkQ5blTy7B1N3AkVF VATjCJqNHECUW/lQ4GjsaYPmsGqMZ22lbpDU+Zir+543sSB4bZR/7JV3hxZL+AE/XSfZK4Z8HL7 wExdRny1x2kyrfVSSgxhe0nQNQaZR X-Received: by 2002:a05:600c:5128:b0:3c6:e62e:2e67 with SMTP id o40-20020a05600c512800b003c6e62e2e67mr58697253wms.2.1673596987504; Fri, 13 Jan 2023 00:03:07 -0800 (PST) X-Google-Smtp-Source: AMrXdXvVwsf1Jjnk65GgTwR1x8Y5bh32fZraLo5RnjXtvxHHUeem4xVwqG2giy3CQPNe9luzSHMqkw== X-Received: by 2002:a05:600c:5128:b0:3c6:e62e:2e67 with SMTP id o40-20020a05600c512800b003c6e62e2e67mr58697233wms.2.1673596987293; Fri, 13 Jan 2023 00:03:07 -0800 (PST) Received: from ?IPV6:2a01:e0a:c:37e0:38da:a7d9:7cc9:db3e? ([2a01:e0a:c:37e0:38da:a7d9:7cc9:db3e]) by smtp.gmail.com with ESMTPSA id n7-20020a05600c4f8700b003c6bd12ac27sm27381636wmq.37.2023.01.13.00.03.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jan 2023 00:03:06 -0800 (PST) Message-ID: Date: Fri, 13 Jan 2023 09:03:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 To: Nathan Chancellor References: <20221013205909.1282545-1-nathan@kernel.org> <4dcf830e-62a5-837b-7590-ac5395f84c14@redhat.com> From: Jocelyn Falempe In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Fix CFI violations in gt_sysfs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: llvm@lists.linux.dev, Kees Cook , Tom Rix , intel-gfx@lists.freedesktop.org, Nick Desaulniers , patches@lists.linux.dev, Sami Tolvanen , dri-devel@lists.freedesktop.org, Andrzej Hajda , Rodrigo Vivi Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 12/01/2023 16:56, Nathan Chancellor wrote: > Hi Jocelyn, > > On Thu, Jan 12, 2023 at 11:08:17AM +0100, Jocelyn Falempe wrote: >> This patch does also solve a kernel crash when reading >> /sys/class/drm/card1/gt/gt0/* on a skylake machine: >> https://bugzilla.redhat.com/show_bug.cgi?id=2154880 > > Interesting, I wonder what aspect of this patch fixes this because I am > not sure that is an intended consequence of this change but that is > still good to hear! I wasn't able to find the root cause, but basically the kobj pointer given in the sysfs callback, is not the good one on this machine, so it either return garbage or crash. By chance I found this patch, tried it, and it solves the issue. > > For the record, this is commit a8a4f0467d70 ("drm/i915: Fix CFI > violations in gt_sysfs") in mainline. > >> Do you think it can be backported to stable releases ? >> Conflicts are trivial on top of v6.0 at least. > > I had a report from another user of this crash affecting them with kCFI > so it is on my TODO to backport it to 6.1 (6.0 just went EOL) but I am > currently out of the office until next Wednesday so I won't be able to > get to it until then (as I would like to test the backport on affected > hardware). If someone wants to beat me to it, I won't complain ;) Thanks for taking care of it, I will wait next week then. > > Cheers, > Nathan > -- Jocelyn