From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FB9DC433F5 for ; Tue, 16 Nov 2021 07:20:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE3CA6137E for ; Tue, 16 Nov 2021 07:20:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BE3CA6137E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 479326EDF9; Tue, 16 Nov 2021 07:20:54 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id E04256EDF9; Tue, 16 Nov 2021 07:20:52 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10169"; a="220525962" X-IronPort-AV: E=Sophos;i="5.87,238,1631602800"; d="scan'208";a="220525962" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2021 23:20:52 -0800 X-IronPort-AV: E=Sophos;i="5.87,238,1631602800"; d="scan'208";a="645376821" Received: from pheino-mobl.ger.corp.intel.com (HELO [10.249.254.142]) ([10.249.254.142]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2021 23:20:50 -0800 Message-ID: Date: Tue, 16 Nov 2021 08:20:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Content-Language: en-US To: Matthew Auld , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20211114111218.623138-1-thomas.hellstrom@linux.intel.com> <20211114111218.623138-6-thomas.hellstrom@linux.intel.com> <12fa8629-d05f-908c-d127-5fe53bc45c1d@intel.com> From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= In-Reply-To: <12fa8629-d05f-908c-d127-5fe53bc45c1d@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH v3 5/6] drm/i915/ttm: Implement asynchronous TTM moves X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 11/15/21 18:16, Matthew Auld wrote: Thanks for reviewing, Matthew, I'll take a look at the comments. /Thomas > On 14/11/2021 11:12, Thomas Hellström wrote: >> Don't wait sync while migrating, but rather make the GPU blit await the >> dependencies and add a moving fence to the object. >> >> This also enables asynchronous VRAM management in that on eviction, >> rather than waiting for the moving fence to expire before freeing VRAM, >> it is freed immediately and the fence is stored with the VRAM manager >> and >> handed out to newly allocated objects to await before clears and >> swapins, >> or for kernel objects before setting up gpu vmas or mapping. >> >> To collect dependencies before migrating, add a set of utilities that >> coalesce these to a single dma_fence. >> >> What is still missing for fully asynchronous operation is >> asynchronous vma >> unbinding, which is still to be implemented. >> >> This commit substantially reduces execution time in the >> gem_lmem_swapping >> test. >> >> v2: >> - Make a couple of functions static.