From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Subject: Re: [PATCH v2 2/2] drm/i915/display: Move the
 commit_tail() disable sequence to separate function
Date: Thu, 29 Aug 2019 09:30:07 +0200
Message-ID: <e7278b7d-01d3-9c85-b791-537a427724dd@linux.intel.com>
References: <20190827221735.29351-3-manasi.d.navare@intel.com>
 <20190828224701.422-1-manasi.d.navare@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTPS id D143989FBC
 for <intel-gfx@lists.freedesktop.org>; Thu, 29 Aug 2019 07:30:09 +0000 (UTC)
In-Reply-To: <20190828224701.422-1-manasi.d.navare@intel.com>
Content-Language: en-US
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Manasi Navare <manasi.d.navare@intel.com>, intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T3AgMjktMDgtMjAxOSBvbSAwMDo0NyBzY2hyZWVmIE1hbmFzaSBOYXZhcmU6Cj4gQ3JlYXRlIGEg
bmV3IGZ1bmN0aW9uIGludGVsX2NvbW1pdF9tb2Rlc2V0X2Rpc2FibGVzKCkgY29uc2lzdGVudCB3
aXRoIHRoZSBuYW1pbmcKPiBpbiBkcm0gYXRvbWljIGhlbHBlcnMgYW5kIHNpbWlsYXIgdG8gdGhl
IGVuYWJsZSBmdW5jdGlvbi4KPiBUaGlzIGhlbHBzIGJldHRlciBvcmdhbml6ZSB0aGUgZGlzYWJs
ZSBzZXF1ZW5jZSBpbiBhdG9taWNfY29tbWl0X3RhaWwoKQo+Cj4gTm8gZnVuY3Rpb25hbCBjaGFu
Z2UKPgo+IHY0Ogo+ICogRG8gbm90IGNyZWF0ZSBhIGZ1bmN0aW9uIHBvaW50ZXIsIGp1c3QgYSBm
dW5jdGlvbiAoTWFhcnRlbikKPiB2MzoKPiAqIFJlYmFzZSAoTWFuYXNpKQo+IHYyOgo+ICogQ3Jl
YXRlIGEgaGVscGVyIGZvciBvbGRfY3J0Y19zdGF0ZSBkaXNhYmxlcyAoTHVjYXMpCj4KPiBTdWdn
ZXN0ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+IENjOiBW
aWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBNYWFy
dGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+IENjOiBN
YXR0IFJvcGVyIDxtYXR0aGV3LmQucm9wZXJAaW50ZWwuY29tPgo+IENjOiBKYW5pIE5pa3VsYSA8
amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IE1hbmFzaSBOYXZhcmUgPG1h
bmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rp
c3BsYXkvaW50ZWxfZGlzcGxheS5jIHwgOTIgKysrKysrKysrKysrLS0tLS0tLS0KPiAgZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgICAgICAgICAgICAgfCAgMSArCj4gIDIgZmlsZXMg
Y2hhbmdlZCwgNTkgaW5zZXJ0aW9ucygrKSwgMzQgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0
IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IDc3ZGZiMGY2YTZl
MC4uNWM1M2I0NWRjMDZlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3Bs
YXkvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9p
bnRlbF9kaXNwbGF5LmMKPiBAQCAtMTM3NTgsNiArMTM3NTgsNjEgQEAgc3RhdGljIHZvaWQgaW50
ZWxfdXBkYXRlX2NydGMoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gIAlpbnRlbF9maW5pc2hf
Y3J0Y19jb21taXQoc3RhdGUsIGNydGMpOwo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZCBpbnRlbF9v
bGRfY3J0Y19zdGF0ZV9kaXNhYmxlcyhzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRlICpzdGF0ZSwK
PiArCQkJCQkgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSwKPiArCQkJ
CQkgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZSwKPiArCQkJCQkgIHN0
cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq
ZGV2X3ByaXYgPSB0b19pOTE1KHN0YXRlLT5iYXNlLmRldik7Cj4gKwo+ICsJaW50ZWxfY3J0Y19k
aXNhYmxlX3BsYW5lcyhzdGF0ZSwgY3J0Yyk7Cj4gKwo+ICsJLyoKPiArCSAqIFdlIG5lZWQgdG8g
ZGlzYWJsZSBwaXBlIENSQyBiZWZvcmUgZGlzYWJsaW5nIHRoZSBwaXBlLAo+ICsJICogb3Igd2Ug
cmFjZSBhZ2FpbnN0IHZibGFuayBvZmYuCj4gKwkgKi8KPiArCWludGVsX2NydGNfZGlzYWJsZV9w
aXBlX2NyYyhjcnRjKTsKPiArCj4gKwlkZXZfcHJpdi0+ZGlzcGxheS5jcnRjX2Rpc2FibGUob2xk
X2NydGNfc3RhdGUsIHN0YXRlKTsKPiArCWNydGMtPmFjdGl2ZSA9IGZhbHNlOwo+ICsJaW50ZWxf
ZmJjX2Rpc2FibGUoY3J0Yyk7Cj4gKwlpbnRlbF9kaXNhYmxlX3NoYXJlZF9kcGxsKG9sZF9jcnRj
X3N0YXRlKTsKPiArCj4gKwkvKgo+ICsJICogVW5kZXJydW5zIGRvbid0IGFsd2F5cyByYWlzZSBp
bnRlcnJ1cHRzLAo+ICsJICogc28gY2hlY2sgbWFudWFsbHkuCj4gKwkgKi8KPiArCWludGVsX2No
ZWNrX2NwdV9maWZvX3VuZGVycnVucyhkZXZfcHJpdik7Cj4gKwlpbnRlbF9jaGVja19wY2hfZmlm
b191bmRlcnJ1bnMoZGV2X3ByaXYpOwo+ICsKPiArCS8qIEZJWE1FIHVuaWZ5IHRoaXMgZm9yIGFs
bCBwbGF0Zm9ybXMgKi8KPiArCWlmICghbmV3X2NydGNfc3RhdGUtPmJhc2UuYWN0aXZlICYmCj4g
KwkgICAgIUhBU19HTUNIKGRldl9wcml2KSAmJgo+ICsJICAgIGRldl9wcml2LT5kaXNwbGF5Lmlu
aXRpYWxfd2F0ZXJtYXJrcykKPiArCQlkZXZfcHJpdi0+ZGlzcGxheS5pbml0aWFsX3dhdGVybWFy
a3Moc3RhdGUsCj4gKwkJCQkJCSAgICAgbmV3X2NydGNfc3RhdGUpOwo+ICt9CgppbnRlbF9vbGRf
Y3J0Y19kaXNhYmxlKCkgPwoKT3RoZXJ3aXNlIGZvciBib3RoIHBhdGNoZXM6CgpSZXZpZXdlZC1i
eTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4K
Cgo+ICsKPiArc3RhdGljIHZvaWQgaW50ZWxfY29tbWl0X21vZGVzZXRfZGlzYWJsZXMoc3RydWN0
IGludGVsX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gK3sKPiArCXN0cnVjdCBpbnRlbF9jcnRjX3N0
YXRlICpuZXdfY3J0Y19zdGF0ZSwgKm9sZF9jcnRjX3N0YXRlOwo+ICsJc3RydWN0IGludGVsX2Ny
dGMgKmNydGM7Cj4gKwlpbnQgaTsKPiArCj4gKwlmb3JfZWFjaF9vbGRuZXdfaW50ZWxfY3J0Y19p
bl9zdGF0ZShzdGF0ZSwgY3J0Yywgb2xkX2NydGNfc3RhdGUsIG5ld19jcnRjX3N0YXRlLCBpKSB7
Cj4gKwkJaWYgKCFuZWVkc19tb2Rlc2V0KG5ld19jcnRjX3N0YXRlKSkKPiArCQkJY29udGludWU7
Cj4gKwo+ICsJCWludGVsX3ByZV9wbGFuZV91cGRhdGUob2xkX2NydGNfc3RhdGUsIG5ld19jcnRj
X3N0YXRlKTsKPiArCj4gKwkJaWYgKG9sZF9jcnRjX3N0YXRlLT5iYXNlLmFjdGl2ZSkKPiArCQkJ
aW50ZWxfb2xkX2NydGNfc3RhdGVfZGlzYWJsZXMoc3RhdGUsCj4gKwkJCQkJCSAgICAgIG9sZF9j
cnRjX3N0YXRlLAo+ICsJCQkJCQkgICAgICBuZXdfY3J0Y19zdGF0ZSwKPiArCQkJCQkJICAgICAg
Y3J0Yyk7Cj4gKwl9Cj4gK30KPiArCj4gIHN0YXRpYyB2b2lkIGludGVsX2NvbW1pdF9tb2Rlc2V0
X2VuYWJsZXMoc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gIHsKPiAgCXN0cnVj
dCBpbnRlbF9jcnRjICpjcnRjOwo+IEBAIC0xMzkzOCw0MiArMTM5OTMsMTAgQEAgc3RhdGljIHZv
aWQgaW50ZWxfYXRvbWljX2NvbW1pdF90YWlsKHN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKnN0
YXRlKQo+ICAJCQlwdXRfZG9tYWluc1tjcnRjLT5waXBlXSA9Cj4gIAkJCQltb2Rlc2V0X2dldF9j
cnRjX3Bvd2VyX2RvbWFpbnMobmV3X2NydGNfc3RhdGUpOwo+ICAJCX0KPiAtCj4gLQkJaWYgKCFu
ZWVkc19tb2Rlc2V0KG5ld19jcnRjX3N0YXRlKSkKPiAtCQkJY29udGludWU7Cj4gLQo+IC0JCWlu
dGVsX3ByZV9wbGFuZV91cGRhdGUob2xkX2NydGNfc3RhdGUsIG5ld19jcnRjX3N0YXRlKTsKPiAt
Cj4gLQkJaWYgKG9sZF9jcnRjX3N0YXRlLT5iYXNlLmFjdGl2ZSkgewo+IC0JCQlpbnRlbF9jcnRj
X2Rpc2FibGVfcGxhbmVzKHN0YXRlLCBjcnRjKTsKPiAtCj4gLQkJCS8qCj4gLQkJCSAqIFdlIG5l
ZWQgdG8gZGlzYWJsZSBwaXBlIENSQyBiZWZvcmUgZGlzYWJsaW5nIHRoZSBwaXBlLAo+IC0JCQkg
KiBvciB3ZSByYWNlIGFnYWluc3QgdmJsYW5rIG9mZi4KPiAtCQkJICovCj4gLQkJCWludGVsX2Ny
dGNfZGlzYWJsZV9waXBlX2NyYyhjcnRjKTsKPiAtCj4gLQkJCWRldl9wcml2LT5kaXNwbGF5LmNy
dGNfZGlzYWJsZShvbGRfY3J0Y19zdGF0ZSwgc3RhdGUpOwo+IC0JCQljcnRjLT5hY3RpdmUgPSBm
YWxzZTsKPiAtCQkJaW50ZWxfZmJjX2Rpc2FibGUoY3J0Yyk7Cj4gLQkJCWludGVsX2Rpc2FibGVf
c2hhcmVkX2RwbGwob2xkX2NydGNfc3RhdGUpOwo+IC0KPiAtCQkJLyoKPiAtCQkJICogVW5kZXJy
dW5zIGRvbid0IGFsd2F5cyByYWlzZQo+IC0JCQkgKiBpbnRlcnJ1cHRzLCBzbyBjaGVjayBtYW51
YWxseS4KPiAtCQkJICovCj4gLQkJCWludGVsX2NoZWNrX2NwdV9maWZvX3VuZGVycnVucyhkZXZf
cHJpdik7Cj4gLQkJCWludGVsX2NoZWNrX3BjaF9maWZvX3VuZGVycnVucyhkZXZfcHJpdik7Cj4g
LQo+IC0JCQkvKiBGSVhNRSB1bmlmeSB0aGlzIGZvciBhbGwgcGxhdGZvcm1zICovCj4gLQkJCWlm
ICghbmV3X2NydGNfc3RhdGUtPmJhc2UuYWN0aXZlICYmCj4gLQkJCSAgICAhSEFTX0dNQ0goZGV2
X3ByaXYpICYmCj4gLQkJCSAgICBkZXZfcHJpdi0+ZGlzcGxheS5pbml0aWFsX3dhdGVybWFya3Mp
Cj4gLQkJCQlkZXZfcHJpdi0+ZGlzcGxheS5pbml0aWFsX3dhdGVybWFya3Moc3RhdGUsCj4gLQkJ
CQkJCQkJICAgICBuZXdfY3J0Y19zdGF0ZSk7Cj4gLQkJfQo+ICAJfQo+ICAKPiArCWludGVsX2Nv
bW1pdF9tb2Rlc2V0X2Rpc2FibGVzKHN0YXRlKTsKPiArCj4gIAkvKiBGSVhNRTogRXZlbnR1YWxs
eSBnZXQgcmlkIG9mIG91ciBjcnRjLT5jb25maWcgcG9pbnRlciAqLwo+ICAJZm9yX2VhY2hfbmV3
X2ludGVsX2NydGNfaW5fc3RhdGUoc3RhdGUsIGNydGMsIG5ld19jcnRjX3N0YXRlLCBpKQo+ICAJ
CWNydGMtPmNvbmZpZyA9IG5ld19jcnRjX3N0YXRlOwo+IEBAIC0xNTkyOSw2ICsxNTk1Miw3IEBA
IHZvaWQgaW50ZWxfaW5pdF9kaXNwbGF5X2hvb2tzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk
ZXZfcHJpdikKPiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5jb21taXRfbW9kZXNldF9lbmFibGVzID0g
c2tsX2NvbW1pdF9tb2Rlc2V0X2VuYWJsZXM7Cj4gIAllbHNlCj4gIAkJZGV2X3ByaXYtPmRpc3Bs
YXkuY29tbWl0X21vZGVzZXRfZW5hYmxlcyA9IGludGVsX2NvbW1pdF9tb2Rlc2V0X2VuYWJsZXM7
Cj4gKwo+ICB9Cj4gIAo+ICBzdGF0aWMgaTkxNV9yZWdfdCBpOTE1X3ZnYWNudHJsX3JlZyhzdHJ1
Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4g
aW5kZXggNzVhNDJlOGRmNjdlLi5kYjc0ODA4MzFlNTIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf
ZHJ2LmgKPiBAQCAtMjg5LDYgKzI4OSw3IEBAIHN0cnVjdCBkcm1faTkxNV9kaXNwbGF5X2Z1bmNz
IHsKPiAgCXZvaWQgKCpjcnRjX2Rpc2FibGUpKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRf
Y3J0Y19zdGF0ZSwKPiAgCQkJICAgICBzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRlICpvbGRfc3Rh
dGUpOwo+ICAJdm9pZCAoKmNvbW1pdF9tb2Rlc2V0X2VuYWJsZXMpKHN0cnVjdCBpbnRlbF9hdG9t
aWNfc3RhdGUgKnN0YXRlKTsKPiArCXZvaWQgKCpjb21taXRfbW9kZXNldF9kaXNhYmxlcykoc3Ry
dWN0IGludGVsX2F0b21pY19zdGF0ZSAqc3RhdGUpOwo+ICAJdm9pZCAoKmF1ZGlvX2NvZGVjX2Vu
YWJsZSkoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAkJCQkgICBjb25zdCBzdHJ1
Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPiAgCQkJCSAgIGNvbnN0IHN0cnVjdCBk
cm1fY29ubmVjdG9yX3N0YXRlICpjb25uX3N0YXRlKTsKCgpfX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm
eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp
bG1hbi9saXN0aW5mby9pbnRlbC1nZng=