From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.
Date: Thu, 27 Jan 2022 13:45:27 +0100 [thread overview]
Message-ID: <e73bb44a-04fe-a7ca-abab-da1002ec9623@linux.intel.com> (raw)
In-Reply-To: <44532d97-6701-93f2-dd06-4429b523f666@linux.intel.com>
On 1/27/22 13:38, Maarten Lankhorst wrote:
> Op 27-01-2022 om 13:09 schreef Thomas Hellström:
>> On 1/27/22 13:05, Thomas Hellström wrote:
>>>> The bug on vm_close is a separate bug, and would probably best be
>>>> fixed in a separate patch.
>>>>
>>>> Could I get a r-b on this? It should fix some issues, even if the
>>>> unbind there is a separate bug.
>>>>
>>>> ~Maarten
>>>>
>>> Recognizing that it doesn't fix the vm_close issue,
>>>
>>> Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>> Oh, BTW should probably carefully review those seemingly unrelated stall warnings from BAT to check whether the newly introduced object lock might stall a workqueue causing those.
>>
>> /Thomas
> Which ones? I mostly see ext4 failures, where it doesn't seem to have any i915 lock held at all.
>
Oh, I was looking at v1 version of the patch, but just noticed a hang.
Didn't look to carefully at what was the cause.
/Thomas
next prev parent reply other threads:[~2022-01-27 12:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 7:37 [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2 Maarten Lankhorst
2022-01-26 8:23 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-01-26 8:55 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-01-26 12:55 ` [Intel-gfx] [PATCH] " Gwan-gyeong Mun
2022-01-27 12:02 ` Maarten Lankhorst
2022-01-27 12:05 ` Thomas Hellström
2022-01-27 12:09 ` Thomas Hellström
2022-01-27 12:38 ` Maarten Lankhorst
2022-01-27 12:45 ` Thomas Hellström [this message]
2022-01-28 8:54 ` Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e73bb44a-04fe-a7ca-abab-da1002ec9623@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gwan-gyeong.mun@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox