From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2974AC433FE for ; Thu, 27 Jan 2022 12:45:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4FB3B10E64E; Thu, 27 Jan 2022 12:45:34 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7330F10E64E; Thu, 27 Jan 2022 12:45:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643287532; x=1674823532; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=YuH2RZG+RGvt74U74UpO3K39XsULoPyARyVDyhZ+PbI=; b=b79ZuSzbCyaDmr5cWwgyTbwz7ZHMcO4C8RlUg/gWBv7PKE//JIjiFVb1 AuFbkgnoamzk30mWvl4zN2Oq8NCUxDMamjdPMl/fhSS3M8lq3OqzghgmC MlIces+XzlhhERLQGSWMQBK2x04VaHmEhEf13ugM9lWNKZkhuBe4EFa7p rn/W3/qeeWSLMMHMu76sCJXn3Nz1m9v9Q0WFY8NmXmVngGNff+4FzhtSE duQzwGeNYmOKBN7vdqElhdg618dadR44n+SuNz6N6BZSKCKHeoOtcgcDp Te6jaWt+m0G2cQo3FHKvDgfy4vleXGr3W4taLtQHPGWrrn/13IF+rfMhT Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10239"; a="244441394" X-IronPort-AV: E=Sophos;i="5.88,320,1635231600"; d="scan'208";a="244441394" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2022 04:45:31 -0800 X-IronPort-AV: E=Sophos;i="5.88,320,1635231600"; d="scan'208";a="480276665" Received: from cmathias-mobl1.ger.corp.intel.com (HELO [10.249.254.207]) ([10.249.254.207]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2022 04:45:30 -0800 Message-ID: Date: Thu, 27 Jan 2022 13:45:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Content-Language: en-US To: Maarten Lankhorst , Gwan-gyeong Mun , intel-gfx@lists.freedesktop.org References: <20220126073703.1215696-1-maarten.lankhorst@linux.intel.com> <83aec5cf-2e5c-77ec-b716-0416551c3f2a@linux.intel.com> <27506ac8eff06662f063d563662555cb08f2ce64.camel@linux.intel.com> <982820d1-0d9a-ac01-e4f5-9a11556d8690@linux.intel.com> <44532d97-6701-93f2-dd06-4429b523f666@linux.intel.com> From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= In-Reply-To: <44532d97-6701-93f2-dd06-4429b523f666@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2. X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 1/27/22 13:38, Maarten Lankhorst wrote: > Op 27-01-2022 om 13:09 schreef Thomas Hellström: >> On 1/27/22 13:05, Thomas Hellström wrote: >>>> The bug on vm_close is a separate bug, and would probably best be >>>> fixed in a separate patch. >>>> >>>> Could I get a r-b on this? It should fix some issues, even if the >>>> unbind there is a separate bug. >>>> >>>> ~Maarten >>>> >>> Recognizing that it doesn't fix the vm_close issue, >>> >>> Reviewed-by: Thomas Hellström >> Oh, BTW should probably carefully review those seemingly unrelated stall warnings from BAT to check whether the newly introduced object lock might stall a workqueue causing those. >> >> /Thomas > Which ones? I mostly see ext4 failures, where it doesn't seem to have any i915 lock held at all. > Oh, I was looking at v1 version of the patch, but just noticed a hang. Didn't look to carefully at what was the cause. /Thomas