From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 12/16] drm/i915: Swap if(enable_execlists) in i915_gem_request_alloc for a vfunc Date: Fri, 9 Dec 2016 15:16:33 +0000 Message-ID: References: <20161207135833.32740-1-chris@chris-wilson.co.uk> <20161207135833.32740-13-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4A4EF6EA2B for ; Fri, 9 Dec 2016 15:16:44 +0000 (UTC) In-Reply-To: <20161207135833.32740-13-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA3LzEyLzIwMTYgMTM6NTgsIENocmlzIFdpbHNvbiB3cm90ZToKPiBBIGZhaXJseSB0cml2 aWFsIG1vdmUgb2YgYSBtYXRjaGluZyBwYWlyIG9mIHJvdXRpbmVzIChmb3IgcHJlcGFyaW5nIGEK PiByZXF1ZXN0IGZvciBjb25zdHJ1Y3Rpb24pIG9udG8gYW4gZW5naW5lIHZmdW5jLiBUaGUgdWx0 ZXJpb3IgbW90aXZlIGlzCj4gdG8gYmUgYWJsZSB0byBjcmVhdGUgYSBtb2NrIHJlcXVlc3QgaW1w bGVtZW50YXRpb24uCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlz LXdpbHNvbi5jby51az4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVx dWVzdC5jIHwgNSArLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyAgICAg ICAgfCA0ICsrKy0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmggICAgICAgIHwg MiAtLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMgfCA0ICsrKy0K PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oIHwgMyArLS0KPiAgNSBm aWxlcyBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuYwo+IGluZGV4IDA2ZTlhNjA3ZDkzNC4uODgx YmVkNTM0N2ZiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3Jl cXVlc3QuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuYwo+ IEBAIC02MjIsMTAgKzYyMiw3IEBAIGk5MTVfZ2VtX3JlcXVlc3RfYWxsb2Moc3RydWN0IGludGVs X2VuZ2luZV9jcyAqZW5naW5lLAo+ICAJcmVxLT5yZXNlcnZlZF9zcGFjZSA9IE1JTl9TUEFDRV9G T1JfQUREX1JFUVVFU1Q7Cj4gIAlHRU1fQlVHX09OKHJlcS0+cmVzZXJ2ZWRfc3BhY2UgPCBlbmdp bmUtPmVtaXRfYnJlYWRjcnVtYl9zeik7Cj4KPiAtCWlmIChpOTE1LmVuYWJsZV9leGVjbGlzdHMp Cj4gLQkJcmV0ID0gaW50ZWxfbG9naWNhbF9yaW5nX2FsbG9jX3JlcXVlc3RfZXh0cmFzKHJlcSk7 Cj4gLQllbHNlCj4gLQkJcmV0ID0gaW50ZWxfcmluZ19hbGxvY19yZXF1ZXN0X2V4dHJhcyhyZXEp Owo+ICsJcmV0ID0gZW5naW5lLT5yZXF1ZXN0X2FsbG9jKHJlcSk7Cj4gIAlpZiAocmV0KQo+ICAJ CWdvdG8gZXJyX2N0eDsKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9scmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gaW5kZXggMjJkZWQ5 MmQwMzQ2Li4zZjUzNmVmMzc5NjggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfbHJjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IEBA IC04NDUsNyArODQ1LDcgQEAgc3RhdGljIHZvaWQgZXhlY2xpc3RzX2NvbnRleHRfdW5waW4oc3Ry dWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLAo+ICAJaTkxNV9nZW1fY29udGV4dF9wdXQoY3R4 KTsKPiAgfQo+Cj4gLWludCBpbnRlbF9sb2dpY2FsX3JpbmdfYWxsb2NfcmVxdWVzdF9leHRyYXMo c3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0KQo+ICtzdGF0aWMgaW50IGV4ZWNs aXN0c19yZXF1ZXN0X2FsbG9jKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCkK PiAgewo+ICAJc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lID0gcmVxdWVzdC0+ZW5naW5l Owo+ICAJc3RydWN0IGludGVsX2NvbnRleHQgKmNlID0gJnJlcXVlc3QtPmN0eC0+ZW5naW5lW2Vu Z2luZS0+aWRdOwo+IEBAIC0xODE2LDYgKzE4MTYsOCBAQCBsb2dpY2FsX3JpbmdfZGVmYXVsdF92 ZnVuY3Moc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAJZW5naW5lLT5jb250ZXh0 X3BpbiA9IGV4ZWNsaXN0c19jb250ZXh0X3BpbjsKPiAgCWVuZ2luZS0+Y29udGV4dF91bnBpbiA9 IGV4ZWNsaXN0c19jb250ZXh0X3VucGluOwo+Cj4gKwllbmdpbmUtPnJlcXVlc3RfYWxsb2MgPSBl eGVjbGlzdHNfcmVxdWVzdF9hbGxvYzsKPiArCj4gIAllbmdpbmUtPmVtaXRfZmx1c2ggPSBnZW44 X2VtaXRfZmx1c2g7Cj4gIAllbmdpbmUtPmVtaXRfYnJlYWRjcnVtYiA9IGdlbjhfZW1pdF9icmVh ZGNydW1iOwo+ICAJZW5naW5lLT5lbWl0X2JyZWFkY3J1bWJfc3ogPSBnZW44X2VtaXRfYnJlYWRj cnVtYl9zejsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmgg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuaAo+IGluZGV4IGI1NjMwMzMxMDg2YS4u MDFiYTM2ZWExMjVlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xy Yy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmgKPiBAQCAtNjMsOCAr NjMsNiBAQCBlbnVtIHsKPiAgfTsKPgo+ICAvKiBMb2dpY2FsIFJpbmdzICovCj4gLWludCBpbnRl bF9sb2dpY2FsX3JpbmdfYWxsb2NfcmVxdWVzdF9leHRyYXMoc3RydWN0IGRybV9pOTE1X2dlbV9y ZXF1ZXN0ICpyZXF1ZXN0KTsKPiAtaW50IGludGVsX2xvZ2ljYWxfcmluZ19yZXNlcnZlX3NwYWNl KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCk7Cj4gIHZvaWQgaW50ZWxfbG9n aWNhbF9yaW5nX3N0b3Aoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKTsKPiAgdm9pZCBp bnRlbF9sb2dpY2FsX3JpbmdfY2xlYW51cChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUp Owo+ICBpbnQgbG9naWNhbF9yZW5kZXJfcmluZ19pbml0KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3Mg KmVuZ2luZSk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Jpbmdi dWZmZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+IGluZGV4 IGE1N2ViNWRlYzk5MS4uYTQyYjliZjQ1YjQyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3JpbmdidWZmZXIuYwo+IEBAIC0yMTAyLDcgKzIxMDIsNyBAQCB2b2lkIGludGVsX2xlZ2Fj eV9zdWJtaXNzaW9uX3Jlc3VtZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4g IAl9Cj4gIH0KPgo+IC1pbnQgaW50ZWxfcmluZ19hbGxvY19yZXF1ZXN0X2V4dHJhcyhzdHJ1Y3Qg ZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3QpCj4gK3N0YXRpYyBpbnQgcmluZ19yZXF1ZXN0 X2FsbG9jKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCkKPiAgewo+ICAJaW50 IHJldDsKPgo+IEBAIC0yNTk3LDYgKzI1OTcsOCBAQCBzdGF0aWMgdm9pZCBpbnRlbF9yaW5nX2Rl ZmF1bHRfdmZ1bmNzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCWVuZ2lu ZS0+Y29udGV4dF9waW4gPSBpbnRlbF9yaW5nX2NvbnRleHRfcGluOwo+ICAJZW5naW5lLT5jb250 ZXh0X3VucGluID0gaW50ZWxfcmluZ19jb250ZXh0X3VucGluOwo+Cj4gKwllbmdpbmUtPnJlcXVl c3RfYWxsb2MgPSByaW5nX3JlcXVlc3RfYWxsb2M7Cj4gKwo+ICAJZW5naW5lLT5lbWl0X2JyZWFk Y3J1bWIgPSBpOXh4X2VtaXRfYnJlYWRjcnVtYjsKPiAgCWVuZ2luZS0+ZW1pdF9icmVhZGNydW1i X3N6ID0gaTl4eF9lbWl0X2JyZWFkY3J1bWJfc3o7Cj4gIAlpZiAoaTkxNS5zZW1hcGhvcmVzKSB7 Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaCBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+IGluZGV4IDBiNjlhNTBh YjgzMy4uMTJmNGRkMWNiZjljIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3JpbmdidWZmZXIuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Jpbmdi dWZmZXIuaAo+IEBAIC0yNzIsNiArMjcyLDcgQEAgc3RydWN0IGludGVsX2VuZ2luZV9jcyB7Cj4g IAkJCQkgICAgICAgc3RydWN0IGk5MTVfZ2VtX2NvbnRleHQgKmN0eCk7Cj4gIAl2b2lkCQkoKmNv bnRleHRfdW5waW4pKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwKPiAgCQkJCQkgc3Ry dWN0IGk5MTVfZ2VtX2NvbnRleHQgKmN0eCk7Cj4gKwlpbnQJCSgqcmVxdWVzdF9hbGxvYykoc3Ry dWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXEpOwo+ICAJaW50CQkoKmluaXRfY29udGV4dCko c3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXEpOwo+Cj4gIAlpbnQJCSgqZW1pdF9mbHVz aCkoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0LAo+IEBAIC00NzYsOCArNDc3 LDYgQEAgdm9pZCBpbnRlbF9lbmdpbmVfY2xlYW51cChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpl bmdpbmUpOwo+Cj4gIHZvaWQgaW50ZWxfbGVnYWN5X3N1Ym1pc3Npb25fcmVzdW1lKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7Cj4KPiAtaW50IGludGVsX3JpbmdfYWxsb2NfcmVx dWVzdF9leHRyYXMoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0KTsKPiAtCj4g IGludCBfX211c3RfY2hlY2sgaW50ZWxfcmluZ19iZWdpbihzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3Jl cXVlc3QgKnJlcSwgaW50IG4pOwo+ICBpbnQgX19tdXN0X2NoZWNrIGludGVsX3JpbmdfY2FjaGVs aW5lX2FsaWduKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxKTsKPgo+CgpJbiBkZXZf cHJpdi0+Z3QgYW5kIG5vdCBwZXIgZW5naW5lIHdvdWxkIGJlIGJldHRlci4gSSB0aGluayB3ZSB0 YWxrZWQgCmFib3V0IHRoaXMgaW4gc29tZSBvdGhlciBjb250ZXh0IGFzIHdlbGwuCgpCbGFzdCwg dGhlIHNhbWUgdGhlbiBhcHBsaWVzIHRvIGVuZ2luZS0+Y29udGV4dF8odW4pcGluLiA6KQoKV2hh dCBkbyB5b3UgdGhpbms/CgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=